From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nbd.name ([46.4.11.11]:45931 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbcL1Vfp (ORCPT ); Wed, 28 Dec 2016 16:35:45 -0500 Subject: Re: [PATCH 1/2] dt-bindings: document common IEEE 802.11 frequency properties To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo , linux-wireless@vger.kernel.org References: <20161228155955.25518-1-zajec5@gmail.com> Cc: Martin Blumenstingl , Arnd Bergmann , devicetree@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= From: Felix Fietkau Message-ID: (sfid-20161228_223548_706734_C3E6648F) Date: Wed, 28 Dec 2016 22:35:39 +0100 MIME-Version: 1.0 In-Reply-To: <20161228155955.25518-1-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2016-12-28 16:59, Rafał Miłecki wrote: > From: Rafał Miłecki > > This new file should be used for properties handled at higher level and > so usable with all drivers. > > Signed-off-by: Rafał Miłecki > --- > .../devicetree/bindings/net/wireless/ieee80211.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > new file mode 100644 > index 0000000..c762769 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > @@ -0,0 +1,16 @@ > +Common IEEE 802.11 properties > + > +This provides documentation of common properties that are handled by a proper > +net layer and don't require extra driver code. > + > +Optional properties: > + - ieee80211-min-center-freq : minimal supported frequency in KHz > + - ieee80211-max-center-freq : maximal supported frequency in KHz > + > +Example: > + > +pcie@0,0 { > + reg = <0x0000 0 0 0 0>; > + ieee80211-min-center-freq = <2437000>; > + ieee80211-max-center-freq = <2457000>; I'm not sure that's the best way to deal with enabling/disabling bands. If we get more bands in the future, there might be unsupported ones in the middle, which min/max won't cover. - Felix From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [PATCH 1/2] dt-bindings: document common IEEE 802.11 frequency properties Date: Wed, 28 Dec 2016 22:35:39 +0100 Message-ID: References: <20161228155955.25518-1-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20161228155955.25518-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Martin Blumenstingl , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= List-Id: devicetree@vger.kernel.org On 2016-12-28 16:59, Rafał Miłecki wrote: > From: Rafał Miłecki > > This new file should be used for properties handled at higher level and > so usable with all drivers. > > Signed-off-by: Rafał Miłecki > --- > .../devicetree/bindings/net/wireless/ieee80211.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee80211.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.txt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > new file mode 100644 > index 0000000..c762769 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt > @@ -0,0 +1,16 @@ > +Common IEEE 802.11 properties > + > +This provides documentation of common properties that are handled by a proper > +net layer and don't require extra driver code. > + > +Optional properties: > + - ieee80211-min-center-freq : minimal supported frequency in KHz > + - ieee80211-max-center-freq : maximal supported frequency in KHz > + > +Example: > + > +pcie@0,0 { > + reg = <0x0000 0 0 0 0>; > + ieee80211-min-center-freq = <2437000>; > + ieee80211-max-center-freq = <2457000>; I'm not sure that's the best way to deal with enabling/disabling bands. If we get more bands in the future, there might be unsupported ones in the middle, which min/max won't cover. - Felix