From: <Codrin.Ciubotariu@microchip.com>
To: <linux@armlinux.org.uk>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <wsa@kernel.org>,
<alpawi@amazon.com>
Subject: Re: [PATCH] i2c: pxa: move to generic GPIO recovery
Date: Sat, 3 Oct 2020 22:46:13 +0000 [thread overview]
Message-ID: <dde8b782-9193-a044-a328-98955e9fa35e@microchip.com> (raw)
In-Reply-To: <20201003185404.GH1551@shell.armlinux.org.uk>
>> static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> i2c_pxa_do_reset(i2c);
>> }
>>
>> - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default));
>> -
>
> This won't fly. We need to put the pinctrl back into i2c mode _before_
> we re-enable the I2C module, otherwise the I2C block will see logic 0
> on both SCL and SDA which could confuse the block.
Right, I will add it back.
Best regards,
Codrin
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <linux@armlinux.org.uk>
Cc: wsa@kernel.org, alpawi@amazon.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: pxa: move to generic GPIO recovery
Date: Sat, 3 Oct 2020 22:46:13 +0000 [thread overview]
Message-ID: <dde8b782-9193-a044-a328-98955e9fa35e@microchip.com> (raw)
In-Reply-To: <20201003185404.GH1551@shell.armlinux.org.uk>
>> static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> i2c_pxa_do_reset(i2c);
>> }
>>
>> - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default));
>> -
>
> This won't fly. We need to put the pinctrl back into i2c mode _before_
> we re-enable the I2C module, otherwise the I2C block will see logic 0
> on both SCL and SDA which could confuse the block.
Right, I will add it back.
Best regards,
Codrin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-03 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 16:21 [PATCH] i2c: pxa: move to generic GPIO recovery Codrin Ciubotariu
2020-10-03 16:21 ` Codrin Ciubotariu
2020-10-03 18:54 ` Russell King - ARM Linux admin
2020-10-03 18:54 ` Russell King - ARM Linux admin
2020-10-03 22:46 ` Codrin.Ciubotariu [this message]
2020-10-03 22:46 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde8b782-9193-a044-a328-98955e9fa35e@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alpawi@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.