From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jerome Brunet <jbrunet@baylibre.com>, Mark Brown <broonie@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: da7219: do not request a new clock consummer reference
Date: Wed, 28 Apr 2021 10:17:35 -0500 [thread overview]
Message-ID: <ddf546e9-e160-d865-0a49-a25a1ea4ca96@linux.intel.com> (raw)
In-Reply-To: <20210428122632.46244-3-jbrunet@baylibre.com>
On 4/28/21 7:26 AM, Jerome Brunet wrote:
> This reverts commit 12f8127fe9e6154dd4197df97e44f3fd67583071.
>
> There is problem with clk_hw_get_hw(). Using it pins the clock provider to
> itself, making it impossible to remove the module.
>
> Revert commit 12f8127fe9e6 ("ASoC: da7219: properly get clk from the
> provider") until this gets sorted out.
>
> Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
I added this patch in the SOF tree and the CI results are back to
normal: https://sof-ci.01.org/linuxpr/PR2879/build5689/devicetest/
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Jerome, this was a surprising/hard-to-detect side effect.
> ---
> sound/soc/codecs/da7219.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index bd3c523a8617..13009d08b09a 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -2181,10 +2181,7 @@ static int da7219_register_dai_clks(struct snd_soc_component *component)
> ret);
> goto err;
> }
> -
> - da7219->dai_clks[i] = devm_clk_hw_get_clk(dev, dai_clk_hw, NULL);
> - if (IS_ERR(da7219->dai_clks[i]))
> - return PTR_ERR(da7219->dai_clks[i]);
> + da7219->dai_clks[i] = dai_clk_hw->clk;
>
> /* For DT setup onecell data, otherwise create lookup */
> if (np) {
>
next prev parent reply other threads:[~2021-04-28 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 12:26 [PATCH 0/2] ASoC: Revert clk_hw_get_clk() cleanup Jerome Brunet
2021-04-28 12:26 ` Jerome Brunet
2021-04-28 12:26 ` [PATCH 1/2] ASoC: stm32: do not request a new clock consummer reference Jerome Brunet
2021-04-28 12:26 ` Jerome Brunet
2021-04-28 12:26 ` [PATCH 2/2] ASoC: da7219: " Jerome Brunet
2021-04-28 12:26 ` Jerome Brunet
2021-04-28 15:17 ` Pierre-Louis Bossart [this message]
2021-04-28 16:53 ` [PATCH 0/2] ASoC: Revert clk_hw_get_clk() cleanup Mark Brown
2021-04-28 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddf546e9-e160-d865-0a49-a25a1ea4ca96@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.