From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: fix checking of device features Date: Thu, 29 Jun 2017 09:37:34 +0200 Message-ID: References: <1498653631-15307-1-git-send-email-i.dyukov@samsung.com> <3b44a715-612d-2ef7-aac2-15f74ac4aa07@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: i.maximets@samsung.com, heetae82.ahn@samsung.com, stable@dpdk.org To: Ivan Dyukov , yliu@fridaylinux.org, dev@dpdk.org Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/29/2017 09:21 AM, Maxime Coquelin wrote: > > > On 06/29/2017 08:07 AM, Ivan Dyukov wrote: >> On 06/28/2017 03:54 PM, Maxime Coquelin wrote: >>> >>> >>> On 06/28/2017 02:40 PM, Ivan Dyukov wrote: >>>> To compare enabled features in current device we must use bit >>>> mask instead of bit position. >>>> >>>> CC: stable@dpdk.org >>>> Fixes: c843af3aa13e ("vhost: access header only") >>>> >>>> Signed-off-by: Ivan Dyukov >>>> --- >>>> lib/librte_vhost/virtio_net.c | 8 +++++--- >>>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> Thanks for the fix Ivan, and sorry for introducing this bug. >>> Out of curiosity, did you noticed it because it broke offloading, >>> or just by code review? >> I didn't see any breakages. It's just code review. > > Ok, thanks. FYI, I just found another case in vhost.c, sending patch soon. Cheers, Maxime