From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33517C433F5 for ; Mon, 27 Dec 2021 12:21:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A3AA83838; Mon, 27 Dec 2021 13:21:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qF1zcpqw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 28E9183839; Mon, 27 Dec 2021 13:21:25 +0100 (CET) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97E2183837 for ; Mon, 27 Dec 2021 13:21:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pf1-x436.google.com with SMTP id 196so13535782pfw.10 for ; Mon, 27 Dec 2021 04:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=PkURtD+NsPwF/zxSOnKIjWgNUjssf2a1PQbV4ifY9aI=; b=qF1zcpqwaD7hvZddwHywjoFVKUEv6sey8cyVpbWh5TDO24H/0/ac8lIR5fjRLeQ20Q TV1kJl1phivaCElyH+2FW/XXMoYS1O5bhDST3VkfMAVwUzRvLYWVPtkDViiVIB8qfyv7 oIBFdW19CWKiPMwpAeTNADB3CKi1LbNaUCCLwA8qm1OD78jG1qjNOpO6A/qS3OVOIV3L 9WHgkq3/WSUg/bR78axiJcIXJGWNascB4wuJ1ObhsKxxCOhcDRfTtdU7x4ROchSpCsOz Azyy4TglCcIIvACtlYFLKSO0WYvvyL6Ego4viRfZY/0xiwp9ZWXQa5Y2B3kr0+I3e5Pq aSeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=PkURtD+NsPwF/zxSOnKIjWgNUjssf2a1PQbV4ifY9aI=; b=jiOOgPZslnEx9YqTXBCiqcGgIWNmS/FhHdHxFzrBzxcPoEsxaaLHmp1OBUcp38hADk 6n+pgGWsvBaWoj0J2rNWA4Dp3PugQqDAGT6LZ0QeoLoy0INKLHjxdqY7NrZi1zZgStTe JFMkTqa6MFAb3DXk8SwdMQ15O2wUw/8GYxHHu/rTPKpvwG1HU7EDxyO9vu1zf+r5FzN7 RRdOsuJDs1KuARO9mWN/niFqAyO4LDCAA9hxzSDhghwh0LlYe6lGEribypXlYQ4hlvd7 U+3h3V1KkmDAry7Kc77js8U/IUuZH/N2CUwBUz/1wSeDsiPNa9U3AIskOTy2/lwWzDW9 gUSQ== X-Gm-Message-State: AOAM5322ZzOZjrIAjIejjIbdqvC1H67d5Cvq9uD3urWxiGEhHVzwBDSg CcjYEvN4lrj7NQw9VoMBiH0= X-Google-Smtp-Source: ABdhPJy+F7/2X42u2TNvCcp1ldTfkCCpkmoB7AEjcNPwH7G2MuM/k0eH7BOUzv3e9S60QMrey7ifpg== X-Received: by 2002:a62:cd8b:0:b0:4ba:e907:c8d7 with SMTP id o133-20020a62cd8b000000b004bae907c8d7mr17479204pfg.35.1640607680076; Mon, 27 Dec 2021 04:21:20 -0800 (PST) Received: from [192.168.0.52] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id p32sm12638283pgb.49.2021.12.27.04.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Dec 2021 04:21:19 -0800 (PST) Subject: Re: [PATCH v2 3/3] power: domain: Add Apple pmgr driver To: Mark Kettenis , u-boot@lists.denx.de Cc: sjg@chromium.org, jh80.chung@samsung.com References: <20211223213418.68994-1-kettenis@openbsd.org> <20211223213418.68994-4-kettenis@openbsd.org> From: Jaehoon Chung Message-ID: Date: Mon, 27 Dec 2021 21:21:17 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211223213418.68994-4-kettenis@openbsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/24/21 6:34 AM, Mark Kettenis wrote: > This driver supports power domains for the power management > controller found on Apple SoCs. > > Signed-off-by: Mark Kettenis Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/arm/Kconfig | 3 + > drivers/power/domain/Kconfig | 8 +++ > drivers/power/domain/Makefile | 1 + > drivers/power/domain/apple-pmgr.c | 113 ++++++++++++++++++++++++++++++ > 4 files changed, 125 insertions(+) > create mode 100644 drivers/power/domain/apple-pmgr.c > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 59e031de04..40d3f66acb 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -938,6 +938,9 @@ config ARCH_APPLE > select OF_BOARD > select PINCTRL > select POSITION_INDEPENDENT > + select POWER_DOMAIN > + select REGMAP > + select SYSCON > select SYSRESET > select SYSRESET_WATCHDOG > select SYSRESET_WATCHDOG_AUTO > diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig > index 99b3f9ae71..6ef7a3b3a7 100644 > --- a/drivers/power/domain/Kconfig > +++ b/drivers/power/domain/Kconfig > @@ -9,6 +9,14 @@ config POWER_DOMAIN > domains). This may be used to save power. This API provides the > means to control such power management hardware. > > +config APPLE_PMGR_POWER_DOMAIN > + bool "Enable the Apple PMGR power domain driver" > + depends on POWER_DOMAIN > + default y if ARCH_APPLE > + help > + Enable support for manipulating the Apple M1 power domains via > + MMIO mapped registers. > + > config BCM6328_POWER_DOMAIN > bool "Enable the BCM6328 power domain driver" > depends on POWER_DOMAIN && ARCH_BMIPS > diff --git a/drivers/power/domain/Makefile b/drivers/power/domain/Makefile > index 3d1e5f073c..530ae35671 100644 > --- a/drivers/power/domain/Makefile > +++ b/drivers/power/domain/Makefile > @@ -4,6 +4,7 @@ > # > > obj-$(CONFIG_$(SPL_)POWER_DOMAIN) += power-domain-uclass.o > +obj-$(CONFIG_APPLE_PMGR_POWER_DOMAIN) += apple-pmgr.o > obj-$(CONFIG_BCM6328_POWER_DOMAIN) += bcm6328-power-domain.o > obj-$(CONFIG_IMX8_POWER_DOMAIN) += imx8-power-domain-legacy.o imx8-power-domain.o > obj-$(CONFIG_IMX8M_POWER_DOMAIN) += imx8m-power-domain.o > diff --git a/drivers/power/domain/apple-pmgr.c b/drivers/power/domain/apple-pmgr.c > new file mode 100644 > index 0000000000..08a30c8ebf > --- /dev/null > +++ b/drivers/power/domain/apple-pmgr.c > @@ -0,0 +1,113 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2021 Mark Kettenis > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define APPLE_PMGR_PS_TARGET GENMASK(3, 0) > +#define APPLE_PMGR_PS_ACTUAL GENMASK(7, 4) > + > +#define APPLE_PMGR_PS_ACTIVE 0xf > +#define APPLE_PMGR_PS_PWRGATE 0x0 > + > +#define APPLE_PMGR_PS_SET_TIMEOUT 100 > + > +struct apple_pmgr_priv { > + struct regmap *regmap; > + u32 offset; > +}; > + > +static int apple_pmgr_request(struct power_domain *power_domain) > +{ > + return 0; > +} > + > +static int apple_pmgr_rfree(struct power_domain *power_domain) > +{ > + return 0; > +} > + > +static int apple_pmgr_ps_set(struct power_domain *power_domain, u32 pstate) > +{ > + struct apple_pmgr_priv *priv = dev_get_priv(power_domain->dev); > + uint reg; > + > + regmap_update_bits(priv->regmap, priv->offset, APPLE_PMGR_PS_TARGET, > + FIELD_PREP(APPLE_PMGR_PS_TARGET, pstate)); > + > + return regmap_read_poll_timeout( > + priv->regmap, priv->offset, reg, > + (FIELD_GET(APPLE_PMGR_PS_ACTUAL, reg) == pstate), 1, > + APPLE_PMGR_PS_SET_TIMEOUT); > +} > + > +static int apple_pmgr_on(struct power_domain *power_domain) > +{ > + return apple_pmgr_ps_set(power_domain, APPLE_PMGR_PS_ACTIVE); > +} > + > +static int apple_pmgr_off(struct power_domain *power_domain) > +{ > + return 0; > +} > + > +static int apple_pmgr_of_xlate(struct power_domain *power_domain, > + struct ofnode_phandle_args *args) > +{ > + if (args->args_count != 0) { > + debug("Invalid args_count: %d\n", args->args_count); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static const struct udevice_id apple_pmgr_ids[] = { > + { .compatible = "apple,pmgr-pwrstate" }, > + { /* sentinel */ } > +}; > + > +static int apple_pmgr_probe(struct udevice *dev) > +{ > + struct apple_pmgr_priv *priv = dev_get_priv(dev); > + int ret; > + > + ret = dev_power_domain_on(dev); > + if (ret) > + return ret; > + > + priv->regmap = syscon_get_regmap(dev->parent); > + if (IS_ERR(priv->regmap)) > + return PTR_ERR(priv->regmap); > + > + ret = dev_read_u32(dev, "reg", &priv->offset); > + if (ret < 0) > + return ret; > + > + return 0; > +} > + > +struct power_domain_ops apple_pmgr_ops = { > + .request = apple_pmgr_request, > + .rfree = apple_pmgr_rfree, > + .on = apple_pmgr_on, > + .off = apple_pmgr_off, > + .of_xlate = apple_pmgr_of_xlate, > +}; > + > +U_BOOT_DRIVER(apple_pmgr) = { > + .name = "apple_pmgr", > + .id = UCLASS_POWER_DOMAIN, > + .of_match = apple_pmgr_ids, > + .ops = &apple_pmgr_ops, > + .probe = apple_pmgr_probe, > + .priv_auto = sizeof(struct apple_pmgr_priv), > +};