From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7245C433ED for ; Fri, 2 Apr 2021 14:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6D6161006 for ; Fri, 2 Apr 2021 14:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234831AbhDBOqL (ORCPT ); Fri, 2 Apr 2021 10:46:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:40102 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234361AbhDBOqK (ORCPT ); Fri, 2 Apr 2021 10:46:10 -0400 IronPort-SDR: y8Zet9CI5jWvuRxlN6t6ACVBVIvIhCyk6EAcGZhLSFJFd50h7ySMIQoHi9pX51nIA+TBkpDSEH PY53YU3ziR4g== X-IronPort-AV: E=McAfee;i="6000,8403,9942"; a="180008390" X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="180008390" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 07:46:08 -0700 IronPort-SDR: CSsqwVgnkpUyABPya9YjKXv0gBtS3CvlbKsTVuUFjb31UqWZqChSE3ZcwLqoqYO4Cj/vP/hfmO lgNfuu+B111Q== X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="378106000" Received: from elizondo-mobl.amr.corp.intel.com ([10.212.205.64]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 07:46:08 -0700 Message-ID: Subject: Re: [PATCH] HID: intel-ish-hid: Remove an unused variable 'ret' From: Srinivas Pandruvada To: Yang Li Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 02 Apr 2021 07:46:08 -0700 In-Reply-To: <1617357988-108792-1-git-send-email-yang.lee@linux.alibaba.com> References: <1617357988-108792-1-git-send-email-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-02 at 18:06 +0800, Yang Li wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable > ‘ret’ > set but not used > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: Srinivas Pandruvada > --- > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > index 06081cf..61efc30 100644 > --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > @@ -261,7 +261,6 @@ static void __maybe_unused > ish_resume_handler(struct work_struct *work) > struct pci_dev *pdev = to_pci_dev(ish_resume_device); > struct ishtp_device *dev = pci_get_drvdata(pdev); > uint32_t fwsts = dev->ops->get_fw_status(dev); > - int ret; > > if (ish_should_leave_d0i3(pdev) && !dev->suspend_flag > && IPC_IS_ISH_ILUP(fwsts)) { > @@ -273,7 +272,7 @@ static void __maybe_unused > ish_resume_handler(struct work_struct *work) > > /* Waiting to get resume response */ > if (dev->resume_flag) > - ret = wait_event_interruptible_timeout(dev- > >resume_wait, > + wait_event_interruptible_timeout(dev- > >resume_wait, > !dev->resume_flag, > msecs_to_jiffies(WAIT_FOR_RESUME_ACK_MS > )); >