All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 10/16] x86: don't setup legacy syscall vector when !CONFIG_PV
Date: Mon, 22 Oct 2018 12:21:01 +0100	[thread overview]
Message-ID: <de402941-79c3-8f6d-9d10-324f07088f46@citrix.com> (raw)
In-Reply-To: <20181022111235.az4o3k7wcewhiorq@zion.uk.xensource.com>

On 22/10/18 12:12, Wei Liu wrote:
> On Fri, Oct 19, 2018 at 05:09:43PM +0100, Andrew Cooper wrote:
>> On 19/10/18 15:28, Wei Liu wrote:
>>> Put the code in smpboot.c under CONFIG_PV. Not that we don't need to
>>> set up a stub here because entry.S already does that.
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>> The stub isn't the purpose of the code.  This code is to switch between
>> SYS_DESC_trap_gate and SYS_DESC_irq_gate depending on whether we're
>> intending to use XPTI.  All other details in the IDT entry are already
>> configured correctly for int80_direct_trap.
>>
>> The patch is fine, but with an tweaked commit message, Reviewed-by:
>> Andrew Cooper <andrew.cooper3@citrix.com>
> I have updated the commit message to the following:
>
> The code snippet is to switch between SYS_DECS_trap_gate and
> SYS_DESC_irq_gate depending on whether XPTI is used. When PV is disabled
> there is no need to switch.
>
> Does that look OK to you?

Yup.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-10-22 11:21 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 14:28 [PATCH v2 00/16] Make CONFIG_PV work on x86 Wei Liu
2018-10-19 14:28 ` [PATCH v2 01/16] x86: make mm.c build with !CONFIG_PV Wei Liu
2018-10-26 15:57   ` Jan Beulich
2018-10-19 14:28 ` [PATCH v2 02/16] x86: put some code in arch_set_info_guest under CONFIG_PV Wei Liu
2018-10-26 15:58   ` Jan Beulich
2018-10-19 14:28 ` [PATCH v2 03/16] x86: make traps.c build with !CONFIG_PV Wei Liu
2018-10-26 16:02   ` Jan Beulich
2018-10-30 17:48     ` Wei Liu
2018-10-19 14:28 ` [PATCH v2 04/16] x86: make construct_dom0 " Wei Liu
2018-10-19 15:04   ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 05/16] x86/pv: make guest_io_{read, write} local functions Wei Liu
2018-10-19 15:10   ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 06/16] x86/amd: call post outb hook for both PV and HVM Wei Liu
2018-10-19 15:55   ` Wei Liu
2018-10-29 14:00   ` Jan Beulich
2018-10-19 14:28 ` [PATCH v2 07/16] x86: put XEN_DOMCTL_{set, get}_address_size under CONFIG_PV Wei Liu
2018-10-19 15:18   ` Andrew Cooper
2018-10-30 21:08     ` Wei Liu
2018-10-29 14:28   ` Jan Beulich
2018-10-30 20:50     ` Wei Liu
2018-10-31  9:00       ` Jan Beulich
2018-10-31  9:33         ` Wei Liu
2018-10-31  9:47           ` Jan Beulich
2018-10-31  9:54             ` Wei Liu
2018-10-31 10:12               ` Jan Beulich
2018-10-19 14:28 ` [PATCH v2 08/16] x86: connect guest creation with CONFIG_PV Wei Liu
2018-10-19 15:36   ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 09/16] x86: don't setup PV hypercall stubs and entries when !CONFIG_PV Wei Liu
2018-10-19 15:59   ` Andrew Cooper
2018-10-29 14:37     ` Jan Beulich
2018-10-30 18:08       ` Andrew Cooper
2018-10-31  8:58         ` Jan Beulich
2018-11-02 12:57           ` Wei Liu
2018-11-02 13:03             ` Jan Beulich
2018-10-29 14:33   ` Jan Beulich
2018-10-19 14:28 ` [PATCH v2 10/16] x86: don't setup legacy syscall vector " Wei Liu
2018-10-19 16:09   ` Andrew Cooper
2018-10-22 11:12     ` Wei Liu
2018-10-22 11:21       ` Andrew Cooper [this message]
2018-10-19 14:28 ` [PATCH v2 11/16] x86: don't set sysenter_entry in vmcs " Wei Liu
2018-10-19 15:42   ` Andrew Cooper
2018-10-19 16:00     ` Wei Liu
2018-10-19 16:16       ` Andrew Cooper
2018-11-02 14:05   ` Wei Liu
2018-11-02 14:32     ` Jan Beulich
2018-11-02 14:33       ` Wei Liu
2018-10-19 14:28 ` [PATCH v2 12/16] x86: stub out PV only code in do_debug Wei Liu
2018-10-19 15:43   ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 13/16] x86: rearrange x86_64/entry.S Wei Liu
2018-10-29 14:57   ` Jan Beulich
2018-11-02 12:54     ` Wei Liu
2018-10-19 14:28 ` [PATCH v2 14/16] x86: make entry point code build when !CONFIG_PV Wei Liu
2018-10-29 15:03   ` Jan Beulich
2018-11-02 13:08     ` Wei Liu
2018-11-02 13:45       ` Jan Beulich
2018-11-02 14:14         ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 15/16] x86: expose CONFIG_PV Wei Liu
2018-10-19 15:51   ` Andrew Cooper
2018-10-19 14:28 ` [PATCH v2 16/16] x86: update help string for CONFIG_HVM Wei Liu
2018-10-19 15:55   ` Andrew Cooper
2018-10-29 14:14   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de402941-79c3-8f6d-9d10-324f07088f46@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.