From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 209296F23C for ; Thu, 10 Jan 2019 09:59:31 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Thu, 10 Jan 2019 10:59:29 +0100 In-Reply-To: <20190108152001.5367-1-maxime.ripard@bootlin.com> References: <20190108152001.5367-1-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 01/13] igt: fb: Add subsampling parameters to the formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: T24gVHVlLCAyMDE5LTAxLTA4IGF0IDE2OjE5ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ IEluIG9yZGVyIHRvIGltcHJvdmUgdGhlIFlVViBzdXBwb3J0LCBsZXQncyBhZGQgdGhlIGhvcml6 b250YWwgYW5kIHZlcnRpY2FsCj4gc3Vic2FtcGxpbmcgcGFyYW1ldGVycyB0byB0aGUgSUdUIGZv cm1hdHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBi b290bGluLmNvbT4KClJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxr b3dza2lAYm9vdGxpbi5jb20+Cgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgfCAzNSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9u cygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGli L2lndF9mYi5jCj4gaW5kZXggODI0NGU1MTc2YTZmLi4wMGRiMmVlNTdjYWQgMTAwNjQ0Cj4gLS0t IGEvbGliL2lndF9mYi5jCj4gKysrIGIvbGliL2lndF9mYi5jCj4gQEAgLTcxLDg1ICs3MSwxMDQg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3Qgewo+ICAJaW50IGRlcHRo Owo+ICAJaW50IG51bV9wbGFuZXM7Cj4gIAlpbnQgcGxhbmVfYnBwWzRdOwo+ICsJdWludDhfdCBo c3ViOwo+ICsJdWludDhfdCB2c3ViOwo+ICB9IGZvcm1hdF9kZXNjW10gPSB7Cj4gIAl7IC5uYW1l ID0gIkFSR0IxNTU1IiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX0FSR0IxNTU1 LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfSU5WQUxJRCwKPiAgCSAgLnBpeG1hbl9p ZCA9IFBJWE1BTl9hMXI1ZzViNSwKPiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0g eyAxNiwgfSwKPiArCSAgLmhzdWIgPSAxLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9 ICJYUkdCMTU1NSIsIC5kZXB0aCA9IC0xLCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9YUkdCMTU1NSwK PiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX0lOVkFMSUQsCj4gIAkgIC5waXhtYW5faWQg PSBQSVhNQU5feDFyNWc1YjUsCj4gIAkgIC5udW1fcGxhbmVzID0gMSwgLnBsYW5lX2JwcCA9IHsg MTYsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ICAJfSwKPiAgCXsgLm5hbWUgPSAi UkdCNTY1IiwgLmRlcHRoID0gMTYsIC5kcm1faWQgPSBEUk1fRk9STUFUX1JHQjU2NSwKPiAgCSAg LmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX1JHQjE2XzU2NSwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJ WE1BTl9yNWc2YjUsCj4gIAkgIC5udW1fcGxhbmVzID0gMSwgLnBsYW5lX2JwcCA9IHsgMTYsIH0s Cj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ICAJfSwKPiAgCXsgLm5hbWUgPSAiQkdSNTY1 IiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX0JHUjU2NSwKPiAgCSAgLmNhaXJv X2lkID0gQ0FJUk9fRk9STUFUX0lOVkFMSUQsCj4gIAkgIC5waXhtYW5faWQgPSBQSVhNQU5fYjVn NnI1LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDE2LCB9LAo+ICsJICAu aHN1YiA9IDEsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIkJHUjg4OCIsIC5kZXB0 aCA9IC0xLCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9CR1I4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENB SVJPX0ZPUk1BVF9JTlZBTElELAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX2I4ZzhyOCwKPiAg CSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAyNCwgfSwKPiArCSAgLmhzdWIgPSAx LCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJSR0I4ODgiLCAuZGVwdGggPSAtMSwg LmRybV9pZCA9IERSTV9GT1JNQVRfUkdCODg4LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JN QVRfSU5WQUxJRCwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJWE1BTl9yOGc4YjgsCj4gIAkgIC5udW1f cGxhbmVzID0gMSwgLnBsYW5lX2JwcCA9IHsgMjQsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIg PSAxLAo+ICAJfSwKPiAgCXsgLm5hbWUgPSAiWFlVVjg4ODgiLCAuZGVwdGggPSAtMSwgLmRybV9p ZCA9IERSTV9GT1JNQVRfWFlVVjg4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9S R0IyNCwKPiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAzMiwgfSwKPiArCSAg LmhzdWIgPSAxLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJYUkdCODg4OCIsIC5k ZXB0aCA9IDI0LCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9YUkdCODg4OCwKPiAgCSAgLmNhaXJvX2lk ID0gQ0FJUk9fRk9STUFUX1JHQjI0LAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX3g4cjhnOGI4 LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1 YiA9IDEsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIlhCR1I4ODg4IiwgLmRlcHRo ID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1hCR1I4ODg4LAo+ICAJICAuY2Fpcm9faWQgPSBD QUlST19GT1JNQVRfSU5WQUxJRCwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJWE1BTl94OGI4ZzhyOCwK PiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAzMiwgfSwKPiArCSAgLmhzdWIg PSAxLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJYUkdCMjEwMTAxMCIsIC5kZXB0 aCA9IDMwLCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMCwKPiAgCSAgLmNhaXJvX2lk ID0gQ0FJUk9fRk9STUFUX1JHQjMwLAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX3gycjEwZzEw YjEwLAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAu aHN1YiA9IDEsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIkFSR0I4ODg4IiwgLmRl cHRoID0gMzIsIC5kcm1faWQgPSBEUk1fRk9STUFUX0FSR0I4ODg4LAo+ICAJICAuY2Fpcm9faWQg PSBDQUlST19GT1JNQVRfQVJHQjMyLAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX2E4cjhnOGI4 LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1 YiA9IDEsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIkFCR1I4ODg4IiwgLmRlcHRo ID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX0FCR1I4ODg4LAo+ICAJICAuY2Fpcm9faWQgPSBD QUlST19GT1JNQVRfSU5WQUxJRCwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJWE1BTl9hOGI4ZzhyOCwK PiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAzMiwgfSwKPiArCSAgLmhzdWIg PSAxLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJOVjEyIiwgLmRlcHRoID0gLTEs IC5kcm1faWQgPSBEUk1fRk9STUFUX05WMTIsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1B VF9SR0IyNCwKPiAgCSAgLm51bV9wbGFuZXMgPSAyLCAucGxhbmVfYnBwID0geyA4LCAxNiwgfSwK PiArCSAgLmhzdWIgPSAyLCAudnN1YiA9IDIsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJZVVlWIiwg LmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1lVWVYsCj4gIAkgIC5jYWlyb19pZCA9 IENBSVJPX0ZPUk1BVF9SR0IyNCwKPiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0g eyAxNiwgfSwKPiArCSAgLmhzdWIgPSAyLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9 ICJZVllVIiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1lWWVUsCj4gIAkgIC5j YWlyb19pZCA9IENBSVJPX0ZPUk1BVF9SR0IyNCwKPiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxh bmVfYnBwID0geyAxNiwgfSwKPiArCSAgLmhzdWIgPSAyLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJ eyAubmFtZSA9ICJVWVZZIiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1VZVlks Cj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9SR0IyNCwKPiAgCSAgLm51bV9wbGFuZXMg PSAxLCAucGxhbmVfYnBwID0geyAxNiwgfSwKPiArCSAgLmhzdWIgPSAyLCAudnN1YiA9IDEsCj4g IAl9LAo+ICAJeyAubmFtZSA9ICJWWVVZIiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1fRk9S TUFUX1ZZVVksCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9SR0IyNCwKPiAgCSAgLm51 bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAxNiwgfSwKPiArCSAgLmhzdWIgPSAyLCAudnN1 YiA9IDEsCj4gIAl9LAo+ICB9Owo+ICAjZGVmaW5lIGZvcl9lYWNoX2Zvcm1hdChmKQlcCj4gQEAg LTIzOSwxMCArMjU4LDEyIEBAIHZvaWQgaWd0X2dldF9mYl90aWxlX3NpemUoaW50IGZkLCB1aW50 NjRfdCB0aWxpbmcsIGludCBmYl9icHAsCj4gIAo+ICBzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVf d2lkdGgoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAgewo+IC0JaWYgKGZi LT5kcm1fZm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMiAmJiBwbGFuZSA9PSAxKQo+IC0JCXJldHVy biBESVZfUk9VTkRfVVAoZmItPndpZHRoLCAyKTsKPiArCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVz Y19zdHJ1Y3QgKmZvcm1hdCA9IGxvb2t1cF9kcm1fZm9ybWF0KGZiLT5kcm1fZm9ybWF0KTsKPiAg Cj4gLQlyZXR1cm4gZmItPndpZHRoOwo+ICsJaWYgKHBsYW5lID09IDApCj4gKwkJcmV0dXJuIGZi LT53aWR0aDsKPiArCj4gKwlyZXR1cm4gRElWX1JPVU5EX1VQKGZiLT53aWR0aCwgZm9ybWF0LT5o c3ViKTsKPiAgfQo+ICAKPiAgc3RhdGljIHVuc2lnbmVkIGZiX3BsYW5lX2JwcChjb25zdCBzdHJ1 Y3QgaWd0X2ZiICpmYiwgaW50IHBsYW5lKQo+IEBAIC0yNTQsMTAgKzI3NSwxMiBAQCBzdGF0aWMg dW5zaWduZWQgZmJfcGxhbmVfYnBwKGNvbnN0IHN0cnVjdCBpZ3RfZmIgKmZiLCBpbnQgcGxhbmUp Cj4gIAo+ICBzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfaGVpZ2h0KGNvbnN0IHN0cnVjdCBpZ3Rf ZmIgKmZiLCBpbnQgcGxhbmUpCj4gIHsKPiAtCWlmIChmYi0+ZHJtX2Zvcm1hdCA9PSBEUk1fRk9S TUFUX05WMTIgJiYgcGxhbmUgPT0gMSkKPiAtCQlyZXR1cm4gRElWX1JPVU5EX1VQKGZiLT5oZWln aHQsIDIpOwo+ICsJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0ID0gbG9v a3VwX2RybV9mb3JtYXQoZmItPmRybV9mb3JtYXQpOwo+ICAKPiAtCXJldHVybiBmYi0+aGVpZ2h0 Owo+ICsJaWYgKHBsYW5lID09IDApCj4gKwkJcmV0dXJuIGZiLT5oZWlnaHQ7Cj4gKwo+ICsJcmV0 dXJuIERJVl9ST1VORF9VUChmYi0+aGVpZ2h0LCBmb3JtYXQtPnZzdWIpOwo+ICB9Cj4gIAo+ICBz dGF0aWMgaW50IGZiX251bV9wbGFuZXMoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIpCi0tIApQYXVs IEtvY2lhbGtvd3NraSwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQga2VybmVsIGVuZ2luZWVy aW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aWd0LWRldgo=