From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 33/38] net/dpaa: add support for flow control
Date: Fri, 30 Jun 2017 15:07:45 +0530
Message-ID: <de492cbb-ec56-16df-0a2f-3f7de7ea7f40@nxp.com>
References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com>
 <1497591668-3320-34-git-send-email-shreyansh.jain@nxp.com>
 <108d2db3-8154-c108-13a7-722f861537af@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0065.outbound.protection.outlook.com [104.47.34.65])
 by dpdk.org (Postfix) with ESMTP id D98A237A0
 for <dev@dpdk.org>; Fri, 30 Jun 2017 11:28:38 +0200 (CEST)
In-Reply-To: <108d2db3-8154-c108-13a7-722f861537af@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 28 June 2017 09:17 PM, Ferruh Yigit wrote:
> On 6/16/2017 6:41 AM, Shreyansh Jain wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
>>  static int
>> +dpaa_flow_ctrl_set(struct rte_eth_dev *dev,
>> +		   struct rte_eth_fc_conf *fc_conf)
>> +{
>> +	struct dpaa_if *dpaa_intf = dev->data->dev_private;
>> +	struct rte_eth_fc_conf *net_fc;
>> +
>> +	PMD_INIT_FUNC_TRACE();
>> +
>> +	if (!(dpaa_intf->fc_conf)) {
>> +		dpaa_intf->fc_conf = rte_zmalloc(NULL,
>> +			sizeof(struct rte_eth_fc_conf), MAX_CACHELINE);
> 
> Should this be freed in rte_dpaa_remove()

Will fix this in v2.

> 
>> +		if (!dpaa_intf->fc_conf) {
>> +			PMD_DRV_LOG(ERR, "unable to save flow control info");
>> +			return -ENOMEM;
>> +		}
>> +	}
>> +	net_fc = dpaa_intf->fc_conf;
>> +
> <...>
> 
>