From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E3C35CAA for ; Mon, 10 Oct 2022 19:56:11 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 10B2C2B06B7D; Mon, 10 Oct 2022 15:56:09 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Mon, 10 Oct 2022 15:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1665431769; x=1665435369; bh=OmVrkyV7eb RAniQNae83Idny89aIU9Df0QWBCsfk6KE=; b=JNm+uyKxoucwEtoyKmec9bMOpb y12Xis5RpW/jjxp8Hfm7qdm2PN5XdMzNcNJBx6OO0pOHMDp4K00NHVc6HKrrOLKT YGOSlwZCDNwQoogvWcqyEtiwuSAUHDOhdQlBYY8Pj2A31q523BNxoR4VwvSC0cJS j6IJv/O/y7HUWnPH8CmFYvsDBvS1VtONHMV3NMFU6gOF8uax2+s7aW3ViDzZ1p7a R/P8BeBULT0cUNMI8lcfwoV61G08rOvpcRpLEC4Dxb8pymKfXROdzcwZJRPVEEUX WlXnz1Tosj30qlf6rAV7UBJQRDb0BPEODMnPgAxUbQajh3HoHAWgSp7tkjMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665431769; x=1665435369; bh=OmVrkyV7ebRAniQNae83Idny89aI U9Df0QWBCsfk6KE=; b=PQkHsoMEdaUsHl4egguO1a/yl/ZupKLf2bUv2UYnXXTl S7gvAJlItxcj2GI3cXGV8AHOFQ1MqL5C12GoU8nvpafTWEt1xie713xF6Yi5txJo ZCPofn7GDvUOkoir19j839VbtTsnEkP4V7o8ffjxBwGgcORZyc8IMHDALHUs6LXq mYqM8//y3Yw9JqoE+R7M3NlI4JuvIzdd95O49y2gZZCnTFLlAL51dE3+dYdxZNCe piVOfG+cfoByA9Z3bmtWy5yr4TJcqqBkxqv+Jc02GqNLKDcmBXcKD5GMdd2BQdat jhIp08+BSU7zEt/Mp3DaHoIsdz8X2k5yvH2tBE2xrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejgedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B066EB60086; Mon, 10 Oct 2022 15:56:08 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1015-gaf7d526680-fm-20220929.001-gaf7d5266 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-Id: In-Reply-To: <20221007201140.1744961-1-ndesaulniers@google.com> References: <20221007201140.1744961-1-ndesaulniers@google.com> Date: Mon, 10 Oct 2022 21:55:47 +0200 From: "Arnd Bergmann" To: "Nick Desaulniers" , "Andrew Morton" Cc: "Alexander Viro" , "Nathan Chancellor" , "Tom Rix" , "Xiaoming Ni" , "Luis Chamberlain" , "Andi Kleen" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, "Christoph Hellwig" , "Eric Dumazet" , "Darrick J. Wong" , "Greg Kroah-Hartman" Subject: Re: [PATCH] fs/select: mark do_select noinline_for_stack for 32b Content-Type: text/plain On Fri, Oct 7, 2022, at 10:11 PM, Nick Desaulniers wrote: > +#ifdef CONFIG_64BIT > +#define noinline_for_stack_32b > +#else > +#define noinline_for_stack_32b noinline_for_stack > +#endif > + > +noinline_for_stack_32b I don't see much value in making it behave differently for 32 bit: it doesn't reduce the total frame size on 32-bit machines but only hides the warning. The bug you are working around also looks i386 specific (because of limited number of registers vs ubsan needing a lot of them), so just make it a simple 'noinline_for_stack'. Arnd