From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: John Fastabend <john.fastabend@gmail.com>,
Paul Blakey <paulb@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Hadar Hen Zion <hadarh@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>, Roi Dayan <roid@mellanox.com>,
Roman Mashak <mrv@mojatatu.com>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [PATCH net-next] net/sched: cls_flower: Add user specified data
Date: Sat, 14 Jan 2017 10:03:17 -0500 [thread overview]
Message-ID: <de59c019-8a7d-6747-ddc1-9a21f40d3e04@mojatatu.com> (raw)
In-Reply-To: <20170114144855.GA1886@nanopsycho.orion>
On 17-01-14 09:48 AM, Jiri Pirko wrote:
> Sat, Jan 14, 2017 at 01:56:35PM CET, jhs@mojatatu.com wrote:
>> I think the feature makes a lot of sense (as is the action variant).
>> But can we make it:
>> a) fixed size
>
> Can you elaborate on why is this needed?
>
My experience with the action bits its easier to debug
and enforces some discipline to not abuse the amount of RAM used.
If you have 1M rules, one extra 128M is easier on the system than
a few Gigs.
>
>> b) apply to all classifiers
>> c) please post a usage example via iproute2/tc
>>
>> I am going to post the action variant in the next while - will do some more
>> testing first.
>
> I believe we have to make the cls and ats cookies exactly the same.
>
Probably - they are both needed. See the patch I just posted.
cheers,
jamal
next prev parent reply other threads:[~2017-01-14 15:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 13:13 [PATCH net-next] net/sched: cls_flower: Add user specified data Paul Blakey
2017-01-02 14:59 ` Jamal Hadi Salim
2017-01-02 18:23 ` John Fastabend
2017-01-02 22:21 ` Jamal Hadi Salim
2017-01-02 22:58 ` John Fastabend
2017-01-03 1:22 ` Jamal Hadi Salim
2017-01-03 4:33 ` John Fastabend
2017-01-03 11:44 ` Jamal Hadi Salim
2017-01-03 12:22 ` Paul Blakey
2017-01-04 10:14 ` Simon Horman
2017-01-04 11:45 ` Paul Blakey
2017-01-05 8:03 ` Simon Horman
2017-01-14 13:06 ` Jamal Hadi Salim
2017-01-08 17:19 ` Jiri Pirko
2017-01-09 18:23 ` John Fastabend
2017-01-14 12:56 ` Jamal Hadi Salim
2017-01-14 14:48 ` Jiri Pirko
2017-01-14 15:03 ` Jamal Hadi Salim [this message]
2017-01-14 15:29 ` Jiri Pirko
2017-01-14 17:46 ` Jamal Hadi Salim
2017-01-08 17:15 ` Jiri Pirko
2017-01-08 17:12 ` Jiri Pirko
2017-01-15 17:36 ` Paul Blakey
2017-01-15 19:08 ` John Fastabend
2017-01-16 7:54 ` Paul Blakey
2017-01-16 9:51 ` Jiri Pirko
2017-01-17 11:23 ` Jamal Hadi Salim
2017-01-17 11:53 ` Paul Blakey
2017-01-18 11:06 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de59c019-8a7d-6747-ddc1-9a21f40d3e04@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.