From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933263AbcHYW4R (ORCPT ); Thu, 25 Aug 2016 18:56:17 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32784 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933198AbcHYW4P (ORCPT ); Thu, 25 Aug 2016 18:56:15 -0400 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: hbathini@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf: add container identifier entry in perf sample data To: Peter Zijlstra References: <147212627442.20120.6106492652250934757.stgit@hbathini.in.ibm.com> <20160825130139.GF10138@twins.programming.kicks-ass.net> Cc: ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, sargun@sargun.me, Aravinda Prasad , "Naveen N. Rao" , Ananth N Mavinakayanahalli , daniel@iogearbox.net From: Hari Bathini Date: Thu, 25 Aug 2016 22:50:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160825130139.GF10138@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082517-0052-0000-0000-000001BEF9C8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082517-0053-0000-0000-000006A49759 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-25_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608250200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 August 2016 06:31 PM, Peter Zijlstra wrote: > On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote: > >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h >> index c66a485..fb4f902 100644 >> --- a/include/uapi/linux/perf_event.h >> +++ b/include/uapi/linux/perf_event.h >> @@ -139,8 +139,9 @@ enum perf_event_sample_format { >> PERF_SAMPLE_IDENTIFIER = 1U << 16, >> PERF_SAMPLE_TRANSACTION = 1U << 17, >> PERF_SAMPLE_REGS_INTR = 1U << 18, >> + PERF_SAMPLE_CID = 1U << 19, >> >> - PERF_SAMPLE_MAX = 1U << 19, /* non-ABI */ >> + PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ >> }; > This forgets to update the comment that goes with PERF_RECORD_SAMPLE. > This patch would also need an update to the manpage: > > http://git.kernel.org/cgit/docs/man-pages/man-pages.git/tree/man2/perf_event_open.2 > > http://www.man7.org/linux/man-pages/man2/perf_event_open.2.html > >> + if (sample_type & PERF_SAMPLE_CID) { >> + int size = sizeof(u64); >> + >> + /* >> + * Container identifier for a given task. >> + * Using cgroup namespace inode number for this. >> + */ >> + data->cid_entry.cid = current->nsproxy->cgroup_ns->ns.inum; >> + data->cid_entry.reserved = 0; >> + header->size += size; >> + } >> } > Does this compile with CONFIG_CGROUP=n ? > My bad. Will update.. Actually, on second thought, how about using inode number of some other namespace that any container would have (mount, probably?).. Thanks Hari