All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: corbet@lwn.net, konstantin@linuxfoundation.org,
	Theodore Ts'o <tytso@mit.edu>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux@leemhuis.info, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed
Date: Mon, 3 Oct 2022 08:04:07 +0900	[thread overview]
Message-ID: <de5e732e-4857-dc69-a6c1-f0c1d52f99ef@gmail.com> (raw)
In-Reply-To: <f7f6a67c5ee662f24885579ba09b281a5d597b0a.camel@perches.com>

Hello Joe,

Thank you for chiming in.

On 2022/10/03 0:49, Joe Perches wrote:
> On Sun, 2022-10-02 at 09:58 +0200, Krzysztof Kozlowski wrote:
>> The easiest to achieve it is to run with --no-git-fallback and CC entire
>> output. However it does not mean submitter must run with
>> --no-git-fallback. It is only for this generic rule - CC entire output
>> of get_maintainers.pl.
>>
>> If you add such rule "CC entire output of get_maintainers.pl" and do not
>> mention no-git-fallback, some folks will think they need to CC all these
>> people who made one commit to your file...
> 
> false.
> 
> git-fallback is _not_ used when there is a listed maintainer for a
> specific file.
> 
> If there is a use of git-fallback, it's because there is _no_
> specified maintainer for a specific file.
> 
>    --git-fallback => use git when no exact MAINTAINERS pattern (default: 1)
> 
> i.e.: It's not "your file" if you don't maintain it.

Joe, I sometimes see unexpected output WRT --git-fallback.

Example:

    $ ./get_maintainer.pl -f Documentation/doc-guide/sphinx.rst
    Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION,commit_signer:1/1=100%)
  <-- ???
    Lukas Bulwahn <lukas.bulwahn@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
    <-- ???
    linux-doc@vger.kernel.org (open list:DOCUMENTATION)

    linux-kernel@vger.kernel.org (open list)

As you see, --git-fallback is used in this case. Why?
It looks strange to me as Jon is listed as a "maintainer".

Having "F:	Documentation/" in MAINTAINERS does not suffice?

Can you elaborate?

Regards,
Akira




  reply	other threads:[~2022-10-02 23:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  6:46 [PATCH v3 0/1] Expand get_maintainer to be explicit about supporters Bryan O'Donoghue
2022-09-30  6:46 ` [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed Bryan O'Donoghue
2022-09-30 14:47   ` Akira Yokosawa
2022-09-30 16:18     ` Bryan O'Donoghue
2022-09-30 16:34       ` Bryan O'Donoghue
2022-10-01  2:37       ` Theodore Ts'o
2022-10-01 10:37         ` Bryan O'Donoghue
2022-10-02  0:27           ` Akira Yokosawa
2022-10-02  7:58           ` Krzysztof Kozlowski
2022-10-02 15:49             ` Joe Perches
2022-10-02 23:04               ` Akira Yokosawa [this message]
2022-10-02 23:55                 ` Joe Perches
2022-10-03  1:17                   ` Akira Yokosawa
2022-10-03  1:28                     ` Joe Perches
2022-09-30 18:41     ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de5e732e-4857-dc69-a6c1-f0c1d52f99ef@gmail.com \
    --to=akiyks@gmail.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=corbet@lwn.net \
    --cc=joe@perches.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.