From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB669C433DF for ; Fri, 26 Jun 2020 03:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D495620767 for ; Fri, 26 Jun 2020 03:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgFZDMJ (ORCPT ); Thu, 25 Jun 2020 23:12:09 -0400 Received: from smtprelay0025.hostedemail.com ([216.40.44.25]:44656 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728169AbgFZDMI (ORCPT ); Thu, 25 Jun 2020 23:12:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 2F2C918224D89; Fri, 26 Jun 2020 03:12:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: flame27_2100af926e52 X-Filterd-Recvd-Size: 2409 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Fri, 26 Jun 2020 03:12:04 +0000 (UTC) Message-ID: Subject: Re: [net-next v3 12/15] iecm: Add singleq TX/RX From: Joe Perches To: Jeff Kirsher , davem@davemloft.net Cc: Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Date: Thu, 25 Jun 2020 20:12:03 -0700 In-Reply-To: <20200626020737.775377-13-jeffrey.t.kirsher@intel.com> References: <20200626020737.775377-1-jeffrey.t.kirsher@intel.com> <20200626020737.775377-13-jeffrey.t.kirsher@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement legacy single queue model for TX/RX flows. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c b/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c [] > @@ -145,7 +508,63 @@ static void iecm_rx_singleq_csum(struct iecm_queue *rxq, struct sk_buff *skb, > struct iecm_singleq_base_rx_desc *rx_desc, > u8 ptype) > { [] > + if (ipv4 && (rx_error & (BIT(IECM_RX_BASE_DESC_ERROR_IPE_S) | > + BIT(IECM_RX_BASE_DESC_ERROR_EIPE_S)))) > + goto checksum_fail; > + else if (ipv6 && (rx_status & > + (BIT(IECM_RX_BASE_DESC_STATUS_IPV6EXADD_S)))) > + goto checksum_fail; > + > + /* check for L4 errors and handle packets that were not able to be > + * checksummed due to arrival speed > + */ > + if (rx_error & BIT(IECM_RX_BASE_DESC_ERROR_L3L4E_S)) > + goto checksum_fail; [] > +checksum_fail: > + dev_dbg(rxq->dev, "RX Checksum not available\n"); If there's an actual checksum arrival speed issue, then likely this dbg output should be ratelimited too.