From: Randy Dunlap <rdunlap@infradead.org>
To: Andreas Dilger <adilger@dilger.ca>,
Christian Brauner <christian.brauner@ubuntu.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org, serge@hallyn.com
Subject: Re: [PATCH 2/6] statfs: use << to align with fs header
Date: Fri, 13 Apr 2018 10:55:23 -0700 [thread overview]
Message-ID: <de6ba300-fbef-07ae-651e-87e25ffd701d@infradead.org> (raw)
In-Reply-To: <833FF27F-CFAD-4011-A21C-86B3947BB7D5@dilger.ca>
On 04/13/2018 10:35 AM, Andreas Dilger wrote:
> On Apr 13, 2018, at 10:11 AM, Christian Brauner <christian.brauner@ubuntu.com> wrote:
>>
>> Consistenly use << to define ST_* constants. This also aligns them with
>> their MS_* counterparts in fs.h
>
> IMHO, using (1 << 10) makes the code harder to debug. If you see a field
> in a structure like 0x8354, it is non-trivial to map this to the ST_*
> flags if they are declared in the form (1 << 10) or BIT(10). If they are
> declared in the form 0x100 (as they are now) then it is trivial that the
> ST_APPEND flag is set in 0x8354, and easy to understand the other flags.
>
> So, my preference would be to NOT land this or the previous patch.
That makes sense to me.
--
~Randy
next prev parent reply other threads:[~2018-04-13 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 16:11 [PATCH 0/6] statfs: handle mount propagation Christian Brauner
2018-04-13 16:11 ` [PATCH 1/6] fs: use << for MS_* flags Christian Brauner
2018-04-13 16:45 ` Randy Dunlap
2018-04-13 20:19 ` Greg KH
2018-04-13 16:11 ` [PATCH 2/6] statfs: use << to align with fs header Christian Brauner
2018-04-13 16:47 ` Randy Dunlap
2018-04-13 17:35 ` Andreas Dilger
2018-04-13 17:55 ` Randy Dunlap [this message]
2018-04-13 18:32 ` Christian Brauner
2018-04-13 16:11 ` [PATCH 3/6] statfs: add ST_UNBINDABLE Christian Brauner
2018-04-13 16:11 ` [PATCH 4/6] statfs: add ST_SHARED Christian Brauner
2018-04-13 16:11 ` [PATCH 5/6] statfs: add ST_PRIVATE Christian Brauner
2018-04-13 16:11 ` [PATCH 6/6] statfs: add ST_SLAVE Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6ba300-fbef-07ae-651e-87e25ffd701d@infradead.org \
--to=rdunlap@infradead.org \
--cc=adilger@dilger.ca \
--cc=christian.brauner@ubuntu.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.