From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E69C4727C for ; Wed, 30 Sep 2020 16:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAFCA20789 for ; Wed, 30 Sep 2020 16:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbgI3QX3 (ORCPT ); Wed, 30 Sep 2020 12:23:29 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:56245 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgI3QX3 (ORCPT ); Wed, 30 Sep 2020 12:23:29 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1hQ73nhRz1qs0w; Wed, 30 Sep 2020 18:23:27 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1hQ72Qnyz1sM9L; Wed, 30 Sep 2020 18:23:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id g69DTHQxIRaJ; Wed, 30 Sep 2020 18:23:25 +0200 (CEST) X-Auth-Info: ycFD6wgpeN0gOP0f0ATVRJatmmW7lXFni5Y0klNoyMI= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:23:25 +0200 (CEST) Subject: Re: [PATCH 04/11] soc: imx: gpcv2: wait for ADB400 handshake To: Lucas Stach , Shawn Guo , Rob Herring Cc: devicetree@vger.kernel.org, Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-5-l.stach@pengutronix.de> <818925c0-b45f-67b4-02a1-8db49ccc491e@denx.de> <9533c2b81a9866aec45d2604befe7cdda79d0679.camel@pengutronix.de> From: Marek Vasut Message-ID: Date: Wed, 30 Sep 2020 18:23:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <9533c2b81a9866aec45d2604befe7cdda79d0679.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/30/20 6:19 PM, Lucas Stach wrote: > On Mi, 2020-09-30 at 18:11 +0200, Marek Vasut wrote: >> On 9/30/20 5:49 PM, Lucas Stach wrote: >> >> [...] >> >>> @@ -176,9 +180,19 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) >>> GPC_PGC_CTRL_PCR, 0); >>> >>> /* request the ADB400 to power up */ >>> - if (domain->bits.hsk) >>> + if (domain->bits.hskreq) { >>> regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, >>> - domain->bits.hsk, domain->bits.hsk); >>> + domain->bits.hskreq, domain->bits.hskreq); >>> + >>> + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, >>> + reg_val, >>> + (reg_val & domain->bits.hskack), >>> + 0, USEC_PER_MSEC); >>> + if (ret) { >>> + dev_err(domain->dev, "failed to power up ADB400\n"); >> >> The ADB400 is a bus bridge, so the bus is being attached here, not >> powered up, right ? > > The bits in the PWRHSK register are called "power down" bits, so I kept > this nomenclature. Also I think the ADB400 is mostly isolating the bus > in the power domains from the rest of the NoC, "attaching" of the bus > is really disabling the isolation. > > As there are multiple valid naming choices I kept the naming from the > RM. Maybe NXP can finally explain what these bits really do ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21754C4727C for ; Wed, 30 Sep 2020 16:25:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99F2C20674 for ; Wed, 30 Sep 2020 16:25:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PatliPiy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99F2C20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AaRRhjWcL/xYc9WnIhmX16uwLW3QgFfDOmJhUphRwJs=; b=PatliPiyxCkxXwt5/dLi6jE65 A8keZGn5MQASYwTgcaErHoV8xT0Ee4MvNKve2ct113IP5j8dihQ+0rtBJaOz5GAeTPo453UxE5zGv EBWUq7Ux0yaELtZvn1h8S3AL2MFNMUYsZ3pFTrbxzKRemN0Q5qtHeHDs8Ewh4+DcP045At+ugaQYj CpQq5vB9NWVZKiYxnMmKwrmaDiUJ9RPXWZf/vsOoDhYC4ESSfR+Pm45JKiZ8KNGZIfiJjpPnvV10W IOl6XToDMW9Tvd58ZofwBhZdgaXXmdwwqVUCK8tmuzJtWkjAY5pqmAPDLmnxCjlyvGnYBuwTxYYkC RMo/aFReA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNetd-0003mb-Sz; Wed, 30 Sep 2020 16:24:02 +0000 Received: from mail-out.m-online.net ([212.18.0.9]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNet7-0003eh-Kw for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 16:23:41 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1hQ73nhRz1qs0w; Wed, 30 Sep 2020 18:23:27 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1hQ72Qnyz1sM9L; Wed, 30 Sep 2020 18:23:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id g69DTHQxIRaJ; Wed, 30 Sep 2020 18:23:25 +0200 (CEST) X-Auth-Info: ycFD6wgpeN0gOP0f0ATVRJatmmW7lXFni5Y0klNoyMI= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:23:25 +0200 (CEST) Subject: Re: [PATCH 04/11] soc: imx: gpcv2: wait for ADB400 handshake To: Lucas Stach , Shawn Guo , Rob Herring References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-5-l.stach@pengutronix.de> <818925c0-b45f-67b4-02a1-8db49ccc491e@denx.de> <9533c2b81a9866aec45d2604befe7cdda79d0679.camel@pengutronix.de> From: Marek Vasut Message-ID: Date: Wed, 30 Sep 2020 18:23:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <9533c2b81a9866aec45d2604befe7cdda79d0679.camel@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_122329_873323_163B9FFB X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/20 6:19 PM, Lucas Stach wrote: > On Mi, 2020-09-30 at 18:11 +0200, Marek Vasut wrote: >> On 9/30/20 5:49 PM, Lucas Stach wrote: >> >> [...] >> >>> @@ -176,9 +180,19 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) >>> GPC_PGC_CTRL_PCR, 0); >>> >>> /* request the ADB400 to power up */ >>> - if (domain->bits.hsk) >>> + if (domain->bits.hskreq) { >>> regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, >>> - domain->bits.hsk, domain->bits.hsk); >>> + domain->bits.hskreq, domain->bits.hskreq); >>> + >>> + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, >>> + reg_val, >>> + (reg_val & domain->bits.hskack), >>> + 0, USEC_PER_MSEC); >>> + if (ret) { >>> + dev_err(domain->dev, "failed to power up ADB400\n"); >> >> The ADB400 is a bus bridge, so the bus is being attached here, not >> powered up, right ? > > The bits in the PWRHSK register are called "power down" bits, so I kept > this nomenclature. Also I think the ADB400 is mostly isolating the bus > in the power domains from the rest of the NoC, "attaching" of the bus > is really disabling the isolation. > > As there are multiple valid naming choices I kept the naming from the > RM. Maybe NXP can finally explain what these bits really do ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel