From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Eliminate the horrendous
 format check code
Date: Fri, 26 Oct 2018 13:08:01 -0700
Message-ID: <de6edce61101f5f063f33dd25400b1e7c2654a04.camel@intel.com>
References: <20180309151450.20365-1-ville.syrjala@linux.intel.com>
 <20180309151450.20365-2-ville.syrjala@linux.intel.com>
Reply-To: dhinakaran.pandiyan@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180309151450.20365-2-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gRnJpLCAyMDE4LTAzLTA5IGF0IDE3OjE0ICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+
IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g
Cj4gUmVwbGFjZSB0aGUgbWVzc3kgZnJhbWVidWZmZXIgZm9ybWF0L21vZGlmaWVyIHZhbGlkYXRp
b24gY29kZQo+IHdpdGggYSBzaW5nbGUgY2FsbCB0byBkcm1fYW55X3BsYW5lX2hhc19mb3JtYXQo
KS4gVGhlIGNvZGUgd2FzCj4gZXh0cmVtZWx5IGFubm95aW5nIHRvIG1haW50YWluIGFzIHlvdSBo
YWQgdG8gaGF2ZSBhIGxvdCBvZiBwbGF0Zm9ybQo+IGNoZWNrcyBmb3IgZGlmZmVyZW50IGZvcm1h
dHMuIFRoZSBuZXcgY29kZSByZXF1aXJlcyB6ZXJvIG1haW50ZW5hbmNlLgo+IAo+IHYyOiBOdWtl
IHRoZSBtb2RpZmllciBjaGVja3MgYXMgd2VsbCBzaW5jZSB0aGUgY29yZSBkb2VzIHRoYXQgdG9v
IG5vdwo+IHYzOiBDYWxsIGRybV9hbnlfcGxhbmVfaGFzX2Zvcm1hdCgpIGZyb20gdGhlIGRyaXZl
ciBjb2RlCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh
QGxpbnV4LmludGVsLmNvbT4KClBhdGNoIGxvb2tzIGdvb2QgdG8gbWUsIGJ1dCBkb2VzIG5vdCBh
cHBseSBjbGVhbmx5IG5vdy4KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMgfCA5MCArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAtLS0tLS0tLS0tLS0KPiAg
MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgODIgZGVsZXRpb25zKC0pCj4gCj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMjkzM2FkMzgwOTRmLi43ZjA2
ZmE4M2Q4OTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh
eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEz
OTg5LDcgKzEzOTg5LDYgQEAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVj
dAo+IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShvYmotPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBk
cm1fZnJhbWVidWZmZXIgKmZiID0gJmludGVsX2ZiLT5iYXNlOwo+IC0Jc3RydWN0IGRybV9mb3Jt
YXRfbmFtZV9idWYgZm9ybWF0X25hbWU7Cj4gIAl1MzIgcGl0Y2hfbGltaXQ7Cj4gIAl1bnNpZ25l
ZCBpbnQgdGlsaW5nLCBzdHJpZGU7Cj4gIAlpbnQgcmV0ID0gLUVJTlZBTDsKPiBAQCAtMTQwMjAs
MzMgKzE0MDE5LDE0IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QK
PiBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxfZmIsCj4gIAkJfQo+ICAJfQo+ICAKPiAtCS8qIFBh
c3NlZCBpbiBtb2RpZmllciBzYW5pdHkgY2hlY2tpbmcuICovCj4gLQlzd2l0Y2ggKG1vZGVfY21k
LT5tb2RpZmllclswXSkgewo+IC0JY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1M6Cj4g
LQljYXNlIEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1M6Cj4gLQkJc3dpdGNoIChtb2RlX2Nt
ZC0+cGl4ZWxfZm9ybWF0KSB7Cj4gLQkJY2FzZSBEUk1fRk9STUFUX1hCR1I4ODg4Ogo+IC0JCWNh
c2UgRFJNX0ZPUk1BVF9BQkdSODg4ODoKPiAtCQljYXNlIERSTV9GT1JNQVRfWFJHQjg4ODg6Cj4g
LQkJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+IC0JCQlicmVhazsKPiAtCQlkZWZhdWx0Ogo+
IC0JCQlEUk1fREVCVUdfS01TKCJSQyBzdXBwb3J0ZWQgb25seSB3aXRoIFJHQjg4ODgKPiBmb3Jt
YXRzXG4iKTsKPiAtCQkJZ290byBlcnI7Cj4gLQkJfQo+IC0JCS8qIGZhbGwgdGhyb3VnaCAqLwo+
IC0JY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRDoKPiAtCWNhc2UgSTkxNV9GT1JNQVRfTU9E
X1lmX1RJTEVEOgo+IC0JCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOSkgewo+IC0JCQlEUk1f
REVCVUdfS01TKCJVbnN1cHBvcnRlZCB0aWxpbmcgMHglbGx4IVxuIiwKPiAtCQkJCSAgICAgIG1v
ZGVfY21kLT5tb2RpZmllclswXSk7Cj4gLQkJCWdvdG8gZXJyOwo+IC0JCX0KPiAtCWNhc2UgRFJN
X0ZPUk1BVF9NT0RfTElORUFSOgo+IC0JY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRDoKPiAt
CQlicmVhazsKPiAtCWRlZmF1bHQ6Cj4gLQkJRFJNX0RFQlVHX0tNUygiVW5zdXBwb3J0ZWQgZmIg
bW9kaWZpZXIgMHglbGx4IVxuIiwKPiArCWlmICghZHJtX2FueV9wbGFuZV9oYXNfZm9ybWF0KCZk
ZXZfcHJpdi0+ZHJtLAo+ICsJCQkJICAgICAgbW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwKPiArCQkJ
CSAgICAgIG1vZGVfY21kLT5tb2RpZmllclswXSkpIHsKPiArCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9u
YW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiArCj4gKwkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQg
cGl4ZWwgZm9ybWF0ICVzIC8gbW9kaWZpZXIKPiAweCVsbHhcbiIsCj4gKwkJCSAgICAgIGRybV9n
ZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtCj4gPnBpeGVsX2Zvcm1hdCwKPiArCQkJCQkJICAmZm9y
bWF0X25hbWUpLAo+ICAJCQkgICAgICBtb2RlX2NtZC0+bW9kaWZpZXJbMF0pOwo+ICAJCWdvdG8g
ZXJyOwo+ICAJfQo+IEBAIC0xNDA4MSw2MCArMTQwNjEsNiBAQCBzdGF0aWMgaW50IGludGVsX2Zy
YW1lYnVmZmVyX2luaXQoc3RydWN0Cj4gaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAo+ICAJ
CWdvdG8gZXJyOwo+ICAJfQo+ICAKPiAtCS8qIFJlamVjdCBmb3JtYXRzIG5vdCBzdXBwb3J0ZWQg
YnkgYW55IHBsYW5lIGVhcmx5LiAqLwo+IC0Jc3dpdGNoIChtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0
KSB7Cj4gLQljYXNlIERSTV9GT1JNQVRfQzg6Cj4gLQljYXNlIERSTV9GT1JNQVRfUkdCNTY1Ogo+
IC0JY2FzZSBEUk1fRk9STUFUX1hSR0I4ODg4Ogo+IC0JY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4
Ogo+IC0JCWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFUX1hSR0IxNTU1Ogo+IC0JCWlmIChJTlRF
TF9HRU4oZGV2X3ByaXYpID4gMykgewo+IC0JCQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRlZCBw
aXhlbCBmb3JtYXQ6ICVzXG4iLAo+IC0JCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2Rl
X2NtZC0KPiA+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsKPiAtCQkJZ290byBlcnI7Cj4g
LQkJfQo+IC0JCWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFUX0FCR1I4ODg4Ogo+IC0JCWlmICgh
SVNfVkFMTEVZVklFVyhkZXZfcHJpdikgJiYKPiAhSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikgJiYK
PiAtCQkgICAgSU5URUxfR0VOKGRldl9wcml2KSA8IDkpIHsKPiAtCQkJRFJNX0RFQlVHX0tNUygi
dW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwKPiAtCQkJCSAgICAgIGRybV9nZXRfZm9y
bWF0X25hbWUobW9kZV9jbWQtCj4gPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJ
CWdvdG8gZXJyOwo+IC0JCX0KPiAtCQlicmVhazsKPiAtCWNhc2UgRFJNX0ZPUk1BVF9YQkdSODg4
ODoKPiAtCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMDoKPiAtCWNhc2UgRFJNX0ZPUk1BVF9Y
QkdSMjEwMTAxMDoKPiAtCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDQpIHsKPiAtCQkJRFJN
X0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwKPiAtCQkJCSAgICAg
IGRybV9nZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtCj4gPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9u
YW1lKSk7Cj4gLQkJCWdvdG8gZXJyOwo+IC0JCX0KPiAtCQlicmVhazsKPiAtCWNhc2UgRFJNX0ZP
Uk1BVF9BQkdSMjEwMTAxMDoKPiAtCQlpZiAoIUlTX1ZBTExFWVZJRVcoZGV2X3ByaXYpICYmCj4g
IUlTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9y
dGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCj4gLQkJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1l
KG1vZGVfY21kLQo+ID5waXhlbF9mb3JtYXQsICZmb3JtYXRfbmFtZSkpOwo+IC0JCQlnb3RvIGVy
cjsKPiAtCQl9Cj4gLQkJYnJlYWs7Cj4gLQljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiAtCWNhc2Ug
RFJNX0ZPUk1BVF9VWVZZOgo+IC0JY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4gLQljYXNlIERSTV9G
T1JNQVRfVllVWToKPiAtCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDUgJiYgIUlTX0c0WChk
ZXZfcHJpdikpIHsKPiAtCQkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0
OiAlc1xuIiwKPiAtCQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtCj4gPnBp
eGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJCWdvdG8gZXJyOwo+IC0JCX0KPiAtCQli
cmVhazsKPiAtCWRlZmF1bHQ6Cj4gLQkJRFJNX0RFQlVHX0tNUygidW5zdXBwb3J0ZWQgcGl4ZWwg
Zm9ybWF0OiAlc1xuIiwKPiAtCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0K
PiA+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsKPiAtCQlnb3RvIGVycjsKPiAtCX0KPiAt
Cj4gIAkvKiBGSVhNRSBuZWVkIHRvIGFkanVzdCBMSU5PRkYvVElMRU9GRiBhY2NvcmRpbmdseS4g
Ki8KPiAgCWlmIChtb2RlX2NtZC0+b2Zmc2V0c1swXSAhPSAwKQo+ICAJCWdvdG8gZXJyOwoKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h
aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==