From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: Issues while running Xen with new RR scheduler Date: Mon, 27 Apr 2009 21:41:43 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ananth Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org You need to pass the arguments to xen on the xen command line, not the dom0 kernel command line. So the following line should be: kernel /boot/xen.gz sched=3Drrobin (I haven't checked to make sure that "sched" is the right parameter.) -George On Mon, Apr 27, 2009 at 7:39 PM, Ananth wrote: > Hi, > In continuation with my previous post, I am able to login to the compiled > Xen. But it is continuing to run on credit scheduler even if i modify the > kernel parameters to run using round robin scheduler. > I have pasted the contents of the /boot/grub/menu.lst file. > > title Xen -- openSUSE 11.0 - 2.6.18.8 manually compiled AGAIN > root (hd0,4) > kernel /boot/xen.gz > module /boot/vmlinuz-2.6.18.8-xen0 > root=3D/dev/disk/by-id/scsi-SATA_Hitachi_HTS5416_SB2D04E4CE7YEE-part5 sho= wopts > sched=3Drrobin vga=3D0x314 > module /boot/initrd-2.6.18-xen0 > > Incidentally, even if i give sched=3Dsedf, it still runs only on credit > scheduler. Please let me know your feedback on this issue. My aim is to > study the performance statistics of credit, sedf and new RR scheduler. It > would be great if you could give me any pointers to measure scheduler > performance or get statistics from the system. > > Thanks & Regards > Ananth > > ---------- Forwarded message ---------- > From: Ananth > Date: Mon, Apr 27, 2009 at 6:45 PM > Subject: Re: [Xen-devel] Fwd: Error while compiling with new RR scheduler > To: George Dunlap > Cc: "xen-devel@lists.xensource.com" > > > Hello, > Thank you so much for pointing it out. How could I miss something so > obvious. I am able to compile it now. I will get back to you in case I ge= t > into any issues during run time. > > Thank you. > > Regards > Ananth > > On Mon, Apr 27, 2009 at 6:29 PM, George Dunlap wrote: >> >> The message says it pretty clearly: =A0you return the value of ret, but >> there are control paths in the function for which ret.task is not set. >> =A0Namely, if list_empty(runq) is true, then you will return an >> uninitialized value, which may be anything (garbage on the stack, >> NULL, &c). =A0This will most likely cause Xen to crash, as >> xen/common/schedule.c assumes that ret.task will be a valid, non-NULL >> pointer. >> >> If you happen to know that runq is never empty, then you don't need >> the if statement. =A0If it may be empty, then you need an else clause to >> return the idle vcpu for that processor. >> >> =A0-George >> >> 2009/4/24 Ananth : >> > Hi, >> > I figured out that the error was because of a missing ' ; ' . This has >> > been fixed now. I have attached the modified code. >> > While compiling I am getting the below error message. >> > >> > cc1: warnings being treated as errors >> > sched_rrobin.c: In function =91rrobin_schedule=92: >> > sched_rrobin.c:74: error: =91ret.task=92 may be used uninitialized in = this >> > function >> > >> > Please guide. >> > >> > Thanks & Regards >> > Ananth >> > >> > >> > ---------- Forwarded message ---------- >> > From: Ananth >> > Date: Fri, Apr 24, 2009 at 7:25 PM >> > Subject: Error while compiling with new RR scheduler >> > To: "xen-devel@lists.xensource.com" >> > >> > >> > Hi, >> > Please find attached the source code of Round Robin scheduler which I = am >> > trying to add to Xen 3.3.1. >> > I am facing the following error messages while compiling the same. >> > >> > sched_rrobin.c:31: error: two or more data types in declaration >> > specifiers >> > >> > sched_rrobin.c: In function =91rrobin_vcpu_init=92: >> > >> > sched_rrobin.c:34: error: incompatible types in return >> > >> > sched_rrobin.c:51: error: incompatible types in return >> > >> > sched_rrobin.c:94: error: initialization from incompatible pointer typ= e >> > >> > I believe the error in line 94 is causing the rest of the error >> > messages. I have checked with the structure definition in sched-if.h a= s well >> > as the implementation of the same in other schedulers such as SEDF and >> > Credit. >> > >> > Request you to kindly provide your feedback regarding the same. >> > >> > Thanks & Regards >> > Ananth >> > >> > >> > _______________________________________________ >> > Xen-devel mailing list >> > Xen-devel@lists.xensource.com >> > http://lists.xensource.com/xen-devel >> > >> > > > >