On 08.10.18 21:34, John Snow wrote:
> 
> 
> On 10/05/2018 07:39 PM, Max Reitz wrote:
>> This function queries a node; since we cannot do that right now, it
>> executes query-named-block-nodes and returns the matching node's object.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  tests/qemu-iotests/iotests.py | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
>> index 5c45788dac..604f200600 100644
>> --- a/tests/qemu-iotests/iotests.py
>> +++ b/tests/qemu-iotests/iotests.py
>> @@ -465,6 +465,13 @@ class VM(qtest.QEMUQtestMachine):
>>                  else:
>>                      iotests.log(ev)
>>  
>> +    def node_info(self, node_name):
>> +        nodes = self.qmp('query-named-block-nodes')
>> +        for x in nodes['return']:
>> +            if x['node-name'] == node_name:
>> +                return x
>> +        return None
>> +
>>  
>>  index_re = re.compile(r'([^\[]+)\[([^\]]+)\]')
>>  
>>
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 
> Do we ever want to revisit the idea that our API should not do any
> pre-filtering and that it's always up to the client to do so?

I mean we certainly want to revisit the idea that we should have a
proper query API.

But what exactly do you mean by pre-filtering?

Max