From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35074C18E5A for ; Wed, 11 Mar 2020 11:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B77521D7E for ; Wed, 11 Mar 2020 11:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="YWIhUzw4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729106AbgCKLfe (ORCPT ); Wed, 11 Mar 2020 07:35:34 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:58360 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbgCKLfd (ORCPT ); Wed, 11 Mar 2020 07:35:33 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 02BBZT02056168; Wed, 11 Mar 2020 06:35:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1583926529; bh=MUwhEHVo/riTzodDBSkEu4Ak1a02re6fLtL21+ejVxE=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=YWIhUzw4sKCVY0QCQy86cdUmgiEHKnQ64IJdNSyq9ORDHzv0rGtjdPShg4qfamtqm axO1PVj42MqfBlXB3Sn2c2CSdHO5ooDEPZe2fTvWygbJqCeEdC8KgBS2pEMqVeGBZD wBf3tfEbZixCJa8B1O/XNAVx2YWXMycCyIYJ7utI= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 02BBZTE5002667 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Mar 2020 06:35:29 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 11 Mar 2020 06:35:29 -0500 Received: from localhost.localdomain (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 11 Mar 2020 06:35:29 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by localhost.localdomain (8.15.2/8.15.2) with ESMTP id 02BBZSRQ114003; Wed, 11 Mar 2020 06:35:28 -0500 Subject: Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header To: Sebastian Reichel , Sandeep Patil CC: , , References: <20200116175039.1317-1-dmurphy@ti.com> <20200116175039.1317-3-dmurphy@ti.com> <20200117010658.iqs2zpwl6bsomkuo@earth.universe> <20200306235548.GA187098@google.com> <20200310213050.si7gcr2wbmjgr7jf@earth.universe> From: Dan Murphy Message-ID: Date: Wed, 11 Mar 2020 06:29:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200310213050.si7gcr2wbmjgr7jf@earth.universe> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian On 3/10/20 4:30 PM, Sebastian Reichel wrote: > Hi Sandeep, > > On Fri, Mar 06, 2020 at 03:55:48PM -0800, Sandeep Patil wrote: >> On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote: >>> Hi, >>> >>> On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote: >>>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum. >>>> >>>> Signed-off-by: Dan Murphy >>>> --- >>> Looks good. But I will not merge it without a user and have comments >>> for the driver. >> Android has been looking for these properties for a while now [1]. >> It was added[2] when we saw that the manufacturers were implementing these >> properties in the driver. I didn't know the properties were absent upstream >> until yesterday. Somebody pointed out in our ongoing effort to make sure >> all core kernel changes that android depends on are present upstream. >> >> I think those values are also propagated in application facing APIs in >> Android (but I am not sure yet, let me know if that's something you want >> to find out). >> >> I wanted to chime in and present you a 'user' for this if that helps. > With user I meant an upstream kernel driver, which exposes the > values. But thanks for the pointer. This should be mentioned in > the patch description, also the fact that the status values are > directly taken from JEITA spec. I mentioned the JEITA in the cover letter but I guess you would like the description in the commit message as well Dan