From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E43C432C0 for ; Fri, 22 Nov 2019 13:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44E2220718 for ; Fri, 22 Nov 2019 13:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbfKVNAE (ORCPT ); Fri, 22 Nov 2019 08:00:04 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:45132 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726813AbfKVNAE (ORCPT ); Fri, 22 Nov 2019 08:00:04 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iY8Xa-0003lh-4d; Fri, 22 Nov 2019 14:00:02 +0100 Message-ID: Subject: Re: [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com Date: Fri, 22 Nov 2019 14:00:01 +0100 In-Reply-To: <87tv6w3w92.fsf@toke.dk> References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net> <87tv6w3w92.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Well, one calculates bitrates while the other calculates airtime? ;) :) > But yeah, I get what you mean. I think Felix went through quite some > pains to structure this code to avoid divisions in the fast path. I > guess that is the main blocker for cfg80211_calculate_bitrate() to be > used instead (assuming we do want to consolidate them eventually). Not > sure if that can be fixed easily though? We could also do it the other way around? Or maybe we should keep both and use them as a sanity check for each other :P johannes