All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] make-mod-scripts: change how some kernel module tools are built
Date: Tue, 20 Feb 2018 11:26:28 -0500	[thread overview]
Message-ID: <deba09ee-bc72-224b-85d3-887670a26b9d@windriver.com> (raw)
In-Reply-To: <1519083917.24236.261.camel@linuxfoundation.org>

On 02/19/2018 06:45 PM, Richard Purdie wrote:
> On Mon, 2018-02-19 at 10:37 -0500, Bruce Ashfield wrote:
>> From: Joe Slater <jslater@windriver.com>
>>
>> Remove do_make_scripts() from module-base.bbclass and put
>> functionality in a recipe.  This will build the scripts only
>> once instead of each time an external module is built.
>>
>> [YOCTO #12228]
>>
>> Signed-off-by: Joe Slater <jslater@windriver.com>
>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>> ---
>>
>> v2: added the LIC_FILES_CHECKSUM
>>
> 
> Sadly this doesn't pass all our tests:
> 
> https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/827/steps/Running%20oe-selftest/logs/stdio
> 
> oe-selftest -r sstatetests.SStateTests.test_sstate_sametune_samesigs
> 
> should reproduce.
> 
> I suspect that the recipe may need:
> 
> PACKAGE_ARCH = "${MACHINE_ARCH}"

v3 has been sent for the two patches in this series. With the
kernel-devsrc and other scripts/prepare work in progress, I'm sure
there will be more changes coming. But the dependencies and and
build steps are definitely easier to express in the separate recipe
versus being buried in the various bbclasses.

Cheers,

Bruce

> 
> Cheers,
> 
> Richard
> 



      parent reply	other threads:[~2018-02-20 16:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 15:37 [PATCH v2] linux-yocto/4.12: update to v4.12.20 Bruce Ashfield
2018-02-19 15:37 ` [PATCH v2] make-mod-scripts: change how some kernel module tools are built Bruce Ashfield
2018-02-19 23:45   ` Richard Purdie
2018-02-20  2:13     ` Bruce Ashfield
2018-02-20 15:50     ` Bruce Ashfield
2018-02-20 16:26     ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deba09ee-bc72-224b-85d3-887670a26b9d@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.