All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yan, Xiaoping (NSB - CN/Hangzhou)" <xiaoping.yan@nokia-sbell.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] remove dpdk-pdump pcap file, disk space is not freed
Date: Mon, 23 Aug 2021 04:14:28 +0000	[thread overview]
Message-ID: <dec96a33e6a74dfe958c466be60a93ab@nokia-sbell.com> (raw)

Hi,

Before I run pdump, 21MB is used in /tmp
tmpfs                        63G   21M   63G   1% /tmp
Then I run pdump with such command:
dpdk-pdump  -c 0x4001000400100 -a 0000:03:00.6 -a 0000:03:06.1 --legacy-mem --base-virtaddr 0x2aaa2aa000 --file-prefix l2rt --  --pdump port=1,queue=*,rx-dev=/tmp/l2biprt.pcap,tx-dev=/tmp/l2biprt.pcap,mbuf-size=10240,total-num-mbufs=10000
After stop, it generates a 14MB file
              -rw-rw-r--. 1 9999 9999  14M Aug 23 03:58 l2biprt.pcap
And 35M is used in /tmp
              tmpfs                        63G   35M   63G   1% /tmp
And fuser show there are still several users of this file. (all these pids are of running dpdk primary and secondary processes )
              # fuser /tmp/l2biprt.pcap
/tmp/l2biprt.pcap:     139   342   347   434
Then after I rm the file (l2biprt.pcap), disk space in tmp is not freed (still 35MB used)
              rm l2biprt.pcap
              df -h
              tmpfs                        63G   35M   63G   1% /tmp


It seems it goes like this:
             pdump start->pdump send vdev hotplug add request->primary and secondary process calls pmd_pcap_probe() which opens the pcap file->
              pdump stop-> pdump send vdev hotplug remove request-> primary and secondary process does not close the pcap file

To properly close the pcap file and release disk space, it seems we should:

  *   somehow close the pcap file in "vdev hotplug remove", or
  *   don't open the pcap file in "vdev hotplug add"( pmd_pcap_probe()), it seems pcap eth_dev_start will open the pcap file in case it was not opened.

Any comment is appreciated, thank you.

Best regards
Yan Xiaoping


             reply	other threads:[~2021-08-23  4:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23  4:14 Yan, Xiaoping (NSB - CN/Hangzhou) [this message]
2021-08-23 10:04 ` [dpdk-dev] remove dpdk-pdump pcap file, disk space is not freed Ferruh Yigit
2021-08-24  7:36   ` Yan, Xiaoping (NSB - CN/Hangzhou)
2021-08-24  8:59     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dec96a33e6a74dfe958c466be60a93ab@nokia-sbell.com \
    --to=xiaoping.yan@nokia-sbell.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.