From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset() Date: Mon, 24 Jul 2017 21:41:21 +0200 Message-ID: References: <1499867165-60925-1-git-send-email-noralf@tronnes.org> <1499867165-60925-2-git-send-email-noralf@tronnes.org> <87h8y8dtu3.fsf@eliezer.anholt.net> <20170720080049.lzsb4osur7ek6jd2@phenom.ffwll.local> <8788a365-9805-883b-a94c-9786f1c2f647@tronnes.org> <20170724082850.twxe6drjxmz2vnf6@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 609D86E33C for ; Mon, 24 Jul 2017 19:41:26 +0000 (UTC) In-Reply-To: <20170724082850.twxe6drjxmz2vnf6@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAyNC4wNy4yMDE3IDEwLjI4LCBza3JldiBEYW5pZWwgVmV0dGVyOgo+IE9uIEZyaSwgSnVs IDIxLCAyMDE3IGF0IDA4OjQxOjUwUE0gKzAyMDAsIE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPj4g RGVuIDIwLjA3LjIwMTcgMTAuMDAsIHNrcmV2IERhbmllbCBWZXR0ZXI6Cj4+PiBPbiBUaHUsIEp1 bCAyMCwgMjAxNyBhdCAxMjoxMzowN0FNICswMjAwLCBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4+ Pj4gRGVuIDE5LjA3LjIwMTcgMjMuMDEsIHNrcmV2IEVyaWMgQW5ob2x0Ogo+Pj4+PiBOb3JhbGYg VHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4gd3JpdGVzOgo+Pj4+Pgo+Pj4+Pj4gQWRkIGEg Y29tbW9uIGRybV9kcml2ZXIuZHVtYl9tYXBfb2Zmc2V0IGZ1bmN0aW9uIGZvciBHRU0gYmFja2Vk IGRyaXZlcnMuCj4+Pj4+Pgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxu b3JhbGZAdHJvbm5lcy5vcmc+Cj4+Pj4+IEluc3RlYWQgb2YganVzdCBpbnRyb2R1Y2luZyB0aGUg bmV3IGNvZGUsIGNvdWxkIHdlIHJlcGxhY2UgQ01BJ3MgY29kZQo+Pj4+PiB3aXRoIGNhbGxzIHRv IHRoaXMgYXQgdGhlIHNhbWUgdGltZT8KPj4+PiBJIGhhdmUgZ29uZSB0aHJvdWdoIGFsbCB0aGUg ZHJtX2RyaXZlci0+ZHVtYl9tYXBfb2Zmc2V0Cj4+Pj4gaW1wbGVtZW50YXRpb25zIGFuZCBmb3Vu ZCAyMyBkcml2ZXJzIHRoYXQgY291bGQgdXNlIGl0Ogo+Pj4+IC0gMTggZHJpdmVycyB1c2UgZHJt X2dlbV9jbWFfZHVtYl9tYXBfb2Zmc2V0KCkKPj4+PiAtIGV4eW5vc19kcm1fZ2VtX2R1bWJfbWFw X29mZnNldCgpCj4+Pj4gLSBtdGtfZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoKQo+Pj4+IC0gcHNi X2dlbV9kdW1iX21hcF9ndHQoKQo+Pj4+IC0gcm9ja2NoaXBfZ2VtX2R1bWJfbWFwX29mZnNldCgp Cj4+Pj4gLSB0ZWdyYV9ib19kdW1iX21hcF9vZmZzZXQoKQo+Pj4+Cj4+Pj4gdmdlbV9nZW1fZHVt Yl9tYXAoKSBjYW4ndCB1c2UgaXQgYmVjYXVzZSBvZiB0aGlzIGNoZWNrOgo+Pj4+ICAgICAgIGlm ICghb2JqLT5maWxwKSB7Cj4+Pj4gICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4+Pj4gICAgICAg ICAgIGdvdG8gdW5yZWY7Cj4+Pj4gICAgICAgfQo+Pj4+Cj4+Pj4gYXJtYWRhX2dlbV9kdW1iX21h cF9vZmZzZXQoKSBjYW4ndCB1c2UgaXQgYmVjYXVzZSBvZiB0aGlzIGNoZWNrOgo+Pj4+ICAgICAg IC8qIERvbid0IGFsbG93IGltcG9ydGVkIG9iamVjdHMgdG8gYmUgbWFwcGVkICovCj4+Pj4gICAg ICAgaWYgKG9iai0+b2JqLmltcG9ydF9hdHRhY2gpIHsKPj4+PiAgICAgICAgICAgcmV0ID0gLUVJ TlZBTDsKPj4+PiAgICAgICAgICAgZ290byBlcnJfdW5yZWY7Cj4+Pj4gICAgICAgfQo+Pj4+Cj4+ Pj4gSSBzZWUgdGhhdCBkcml2ZXJzIG11c3QgaW1wbGVtZW50IGFsbCAzIC5kdW1iXyogY2FsbGJh Y2tzOgo+Pj4+Cj4+Pj4gICAgKiBUbyBzdXBwb3J0IGR1bWIgb2JqZWN0cyBkcml2ZXJzIG11c3Qg aW1wbGVtZW50IHRoZQo+Pj4+ICZkcm1fZHJpdmVyLmR1bWJfY3JlYXRlLAo+Pj4+ICAgICogJmRy bV9kcml2ZXIuZHVtYl9kZXN0cm95IGFuZCAmZHJtX2RyaXZlci5kdW1iX21hcF9vZmZzZXQgb3Bl cmF0aW9ucy4gU2VlCj4+Pj4gICAgKiB0aGVyZSBmb3IgZnVydGhlciBkZXRhaWxzLgo+Pj4+Cj4+ Pj4gSSdtIGEgZmFuIG9mIGRlZmF1bHRzLCBpcyB0aGVyZSBhbnkgcmVhc29uIHdlIGNhbid0IGRv IHRoaXM6Cj4+PiBTbyBpbiBnZW5lcmFsIHdlIHRyeSBub3QgdG8gc2V0IGRlZmF1bHRzIGZvciB0 aGUgbWFpbiBkcml2ZXIgZW50cnkgaG9va3MsCj4+PiB0byBhdm9pZCB0aGUgaGVscGVyIGZ1bmN0 aW9ucyBsZWFraW5nIGludG8gY29yZSBhbmQgYmVjb21pbmcgbWFuZGF0b3J5Lgo+Pj4gU28gZS5n LiAtPmF0b21pY19jb21taXQgc2hvdWxkIG5ldmVyIGhhdmUgYSBkZWZhdWx0IG9mCj4+PiBkcm1f YXRvbWljX2hlbHBlcl9jb21taXQuCj4+Pgo+Pj4gU2FtZSB0aG91Z2h0IGFwcGxpZWQgaGVyZSBm b3IgdGhlIGR1bWIgYnVmZmVycyAtIHRoZSBpZGVhIGlzIHRoYXQgZHJpdmVycwo+Pj4gdXNpbmcg YW55IGtpbmQgb2YgYnVmZmVyIG1hbmFnZXIgc2NoZW1lIGNvdWxkIGhhdmUgZHVtYiBidWZmZXJz LCBpbmNsdWRpbmcKPj4+IG1heWJlIG5vdCBoYXZpbmcgYSBidWZmZXIgbWFuYWdlciBhdCBhbGwg KGFuZCB5b3UgZ2V0IHNvbWUgY29va2llIHRvCj4+PiBkaXJlY3QgdnJhbSBhbGxvY2F0aW9ucyBv ciB3aGF0ZXZlcikuIEJ1dCBldmVyeW9uZSBlbmRlZCB1cCB3aXRoIGdlbSwganVzdAo+Pj4gd2l0 aCBkaWZmZXJlbnQga2luZHMgb2YgYmFja2luZyBzdG9yYWdlIGltcGxlbWVudGF0aW9ucyAoY21h LCBzaG1lbSBvcgo+Pj4gdHRtKS4KPj4+Cj4+PiBJIHRoaW5rIGl0IG1ha2VzIHNlbnNlIHRvIG1h a2UgdGhlc2UgdGhlIGRlZmF1bHRzIGFuZCByaXAgb3V0IHRoZSBkZWZhdWx0Cj4+PiBhc3NpZ25t ZW50IGZyb20gYWxsIGRyaXZlcnMuCj4+Pj4gICAgaW50IGRybV9tb2RlX21tYXBfZHVtYl9pb2N0 bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+Pj4+ICAgICAgICAgICAgICAgICAgICAgdm9pZCAq ZGF0YSwgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYpCj4+Pj4gICAgewo+Pj4+ICAgICAgICBz dHJ1Y3QgZHJtX21vZGVfbWFwX2R1bWIgKmFyZ3MgPSBkYXRhOwo+Pj4+Cj4+Pj4gICAgICAgIC8q IGNhbGwgZHJpdmVyIGlvY3RsIHRvIGdldCBtbWFwIG9mZnNldCAqLwo+Pj4+IC0gICAgIGlmICgh ZGV2LT5kcml2ZXItPmR1bWJfbWFwX29mZnNldCkKPj4+PiArICAgIGlmICghZGV2LT5kcml2ZXIt PmR1bWJfY3JlYXRlKQo+Pj4+ICAgICAgICAgICByZXR1cm4gLUVOT1NZUzsKPj4+Pgo+Pj4+IC0g ICAgIHJldHVybiBkZXYtPmRyaXZlci0+ZHVtYl9tYXBfb2Zmc2V0KGZpbGVfcHJpdiwgZGV2LCBh cmdzLT5oYW5kbGUsCj4+Pj4gJmFyZ3MtPm9mZnNldCk7Cj4+Pj4gKyAgICAgaWYgKGRldi0+ZHJp dmVyLT5kdW1iX21hcF9vZmZzZXQpCj4+Pj4gKyAgICAgICAgcmV0dXJuIGRldi0+ZHJpdmVyLT5k dW1iX21hcF9vZmZzZXQoZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwKPj4+PiAmYXJncy0+ b2Zmc2V0KTsKPj4+PiArICAgIGVsc2UKPj4+PiArICAgICAgICByZXR1cm4gZHJtX2dlbV9kdW1i X21hcF9vZmZzZXQoZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSwKPj4+PiAmYXJncy0+b2Zm c2V0KTsKPj4+PiAgICB9Cj4+Pj4KPj4+PiAgICBpbnQgZHJtX21vZGVfZGVzdHJveV9kdW1iX2lv Y3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4gICAgICAgICAgICAgICAgICAgIHZvaWQg KmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2KQo+Pj4+ICAgIHsKPj4+PiAgICAgICAg c3RydWN0IGRybV9tb2RlX2Rlc3Ryb3lfZHVtYiAqYXJncyA9IGRhdGE7Cj4+Pj4KPj4+PiAtICAg ICBpZiAoIWRldi0+ZHJpdmVyLT5kdW1iX2Rlc3Ryb3kpCj4+Pj4gKyAgICBpZiAoIWRldi0+ZHJp dmVyLT5kdW1iX2NyZWF0ZSkKPj4+PiAgICAgICAgICAgIHJldHVybiAtRU5PU1lTOwo+Pj4+Cj4+ Pj4gLSAgICByZXR1cm4gZGV2LT5kcml2ZXItPmR1bWJfZGVzdHJveShmaWxlX3ByaXYsIGRldiwg YXJncy0+aGFuZGxlKTsKPj4+PiArICAgICBpZiAoZGV2LT5kcml2ZXItPmR1bWJfZGVzdHJveSkK Pj4+PiArICAgICAgICByZXR1cm4gZGV2LT5kcml2ZXItPmR1bWJfZGVzdHJveShmaWxlX3ByaXYs IGRldiwgYXJncy0+aGFuZGxlKTsKPj4+PiArICAgIGVsc2UKPj4+PiArICAgICAgICByZXR1cm4g ZHJtX2dlbV9kdW1iX2Rlc3Ryb3koZmlsZV9wcml2LCBkZXYsIGFyZ3MtPmhhbmRsZSk7Cj4+Pj4g ICAgfQo+Pj4+Cj4+Pj4gVGhlcmUgYXJlIDM2IGRyaXZlcnMgdGhhdCB1c2UgZHJtX2dlbV9kdW1i X2Rlc3Ryb3koKSBkaXJlY3RseS4KPj4+PiB2Z2VtIHZpb2xhdGVzIHRoZSBkb2NzIGFuZCBkb2Vz bid0IHNldCAuZHVtYl9kZXN0cm95Lgo+Pj4gSW50ZXJlc3RpbmcsIHN1cHJpc2luZyBpdCBkb2Vz bid0IGxlYWsgbGlrZSBtYWQuCj4+Pj4+IEkgc3VzcGVjdCB0aGF0IGlmIHdlIGhhZCBDTUEgc3Vi Y2xhc3MgZnJvbSBkcm1fZmJfZ2VtIChvciB3ZSBtb3ZlIHRoZQo+Pj4+PiBnZW0gb2JqZWN0cyB0 byB0aGUgYmFzZSBjbGFzcyksIHdlIGNvdWxkIHJlbW92ZSBhIGxvdCBvZiBpdHMgY29kZSB0aGF0 Cj4+Pj4+IHlvdSdyZSBjb3B5aW5nIGluIHBhdGNoIDIsIGFzIHdlbGwuCj4+Pj4gWWVzLCB0aGF0 IHdhcyB0aGUgaW50ZW50aW9uLgo+Pj4gSSBndWVzcyB3ZSdkIG5lZWQgdG8gc2VlIG1vcmUgb2Yg dGhlIGdyYW5kIHBsYW4gLi4uCj4+IEN1cnJlbnRseSBpdCBsb29rcyBsaWtlIDQgcGF0Y2hzZXRz Ogo+Pgo+PiAxLiBBZGQgZHJtX2dlbV9kdW1iX21hcF9vZmZzZXQoKSBhbmQgaW1wbGVtZW50IGRl ZmF1bHRzIGFzIGRpc2N1c3NlZCBhYm92ZS4KPj4KPj4gMi4gQWRkIGRybV9nZW1fb2JqZWN0IHBv aW50ZXJzIHRvIGRybV9mcmFtZWJ1ZmZlciBhbmQgY3JlYXRlIG1hdGNoaW5nCj4+ICAgICBoZWxw ZXJzIGZvcjoKPj4gICAgICAgZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzLT5jcmVhdGVfaGFuZGxlCj4+ ICAgICAgIGRybV9mcmFtZWJ1ZmZlcl9mdW5jcy0+ZGVzdHJveQo+PiAgICAgICBkcm1fbW9kZV9j b25maWdfZnVuY3MtPmZiX2NyZWF0ZQo+PiAgICAgICBTaG91bGQgSSBwdXQgdGhlIGZ1bmN0aW9u cyBpbiBkcm1fZnJhbWVidWZmZXJfaGVscGVyLltoLGNdID8KPiBJJ2QgY2FsbCB0aGVtIGRybV9n ZW1fZnJhbWVidWZmZXJfaGVscGVyLltoY10sIGp1c3QgdG8gaGlnaGxpZ2h0IHRoZQo+IGdlbTwt PmttcyBjb25uZWN0aW9uIGEgYml0IG1vcmUuCj4KPj4gICAgIFVzZSB0aGVzZSBoZWxwZXJzIGlu IHRoZSBjbWEgbGlicmFyeQo+Pgo+PiAzLiBBZGQgZHJtX2ZiX2hlbHBlcl9zaW1wbGVfaW5pdCgp IGFuZCBkcm1fZmJfaGVscGVyX3NpbXBsZV9maW5pKCkKPj4gICAgIFVzZSB0aGVtIGluIGRyaXZl cnMgd2hlcmUgYXBwbGljYWJsZS4KPj4KPj4gNC4gQWRkIHNobWVtIGxpYnJhcnkKPj4gICAgIENv bnZlcnQgdGlueWRybSB0byBzaG1lbS4KPiBTb3VuZHMgbGlrZSBhIGdvb2QgcGxhbi4gSSdsbCB0 cnkgdG8gc2NyYXBlIGF3YXkgc29tZSByZXZpZXcgYmFuZHdpZHRoIHRvCj4gbG9vayBhdCB5b3Vy IHBhdGNoZXMuCgpUaGFua3MsIHRoaXMgZmFubmVkIG91dCBhIGJpdCBtb3JlIHRoYW4gZmlyc3Qg ZXhwZWN0ZWQuCgpOb3JhbGYuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK