From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 05/11] ethdev: add probing finish function
Date: Wed, 23 May 2018 11:09:13 +0100
Message-ID: <dedcc13f-571a-94c2-d1ed-6ba2e469753a@intel.com>
References: <20180509094337.26112-1-thomas@monjalon.net>
 <20180510235836.1099-1-thomas@monjalon.net>
 <20180510235836.1099-6-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: matan@mellanox.com, arybchenko@solarflare.com,
 stephen@networkplumber.org, Keith Wiles <keith.wiles@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id ABA072C8
 for <dev@dpdk.org>; Wed, 23 May 2018 12:09:16 +0200 (CEST)
In-Reply-To: <20180510235836.1099-6-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/11/2018 12:58 AM, Thomas Monjalon wrote:
> A new hook function is added and called inside the PMDs at the end
> of the device probing:
> 	- in primary process, after allocating, init and config
> 	- in secondary process, after attaching and local init
> 
> This new function is almost empty for now.
> It will be used later to add some post-initialization processing.
> 
> For the PMDs calling the helpers rte_eth_dev_create() or
> rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish()
> is called from here, and not in the PMD itself.
> 
> Note that the helper rte_eth_dev_create() could be used more,
> especially for vdevs, avoiding some code duplication in PMDs.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>

Hi Thomas,

This change forces PMDs to call rte_eth_dev_probing_finish() to have them in
proper state. But this requirement is not very clear and documented, it is easy
to miss!

Does it make sense update release notes and highlight to say all PMDs should
call rte_eth_dev_probing_finish(), directly or via helper functions?


Thanks,
ferruh