From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 25 Sep 2017 21:50:13 +0200 Subject: [Buildroot] [PATCH] axel: bump to version 2.14.1 In-Reply-To: <20170925174107.GC25135@pirotess.bf.iodev.co.uk> References: <20170922044545.18813-1-ismael@iodev.co.uk> <20170925142720.GA25135@pirotess.bf.iodev.co.uk> <20170925174107.GC25135@pirotess.bf.iodev.co.uk> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 25-09-17 19:41, Ismael Luceno wrote: > On 25/Sep/2017 18:44, Arnout Vandecappelle wrote: >> >> >> On 25-09-17 16:27, Ismael Luceno wrote: >>> Thanks for the feedback. >>> >>> On 24/Sep/2017 16:09, Arnout Vandecappelle wrote: >>> <...> >>>> If upstream has a v in their version, you should also have it. So >>>> >>>> AXEL_VERSION = v2.14.1 >>>> >>>> Note that as of today, the github helper no longer requires the third >>>> argument. >>> >>> The "v" is not part of the version number, so I would prefer to leave it >>> out of AXEL_VERSION... >> >> No, the v *is* part of the version number. If you use the github helper, the >> _VERSION variable must be identical to the upstream tag. > > Well, that's a matter of interpretation, the project considers it a > prefix, and Github agrees with common practice and removes the "v" > prefix when building the archive... > > So if using the github macro, AXEL_VERSION must be a tag or commit id? Quoting [1]: "The FOO_VERSION can either be a tag or a commit ID." Regards, Arnout [1] https://buildroot.org/downloads/manual/manual.html#github-download-url -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF