From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCNO4-0005iL-SV for qemu-devel@nongnu.org; Mon, 13 Jun 2016 04:38:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCNNz-0004uc-Ss for qemu-devel@nongnu.org; Mon, 13 Jun 2016 04:38:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCNNz-0004uX-NH for qemu-devel@nongnu.org; Mon, 13 Jun 2016 04:38:19 -0400 References: <145641255678.30097.2919142707547689749.stgit@localhost> <145641258612.30097.7127731954660712163.stgit@localhost> <20160609120756.GA15369@stefanha-x1.localdomain> <871t4630rc.fsf@fimbulvetr.bsc.es> <20160610162524.GF3855@stefanha-x1.localdomain> <87bn39j5in.fsf@fimbulvetr.bsc.es> From: Paolo Bonzini Message-ID: Date: Mon, 13 Jun 2016 10:38:14 +0200 MIME-Version: 1.0 In-Reply-To: <87bn39j5in.fsf@fimbulvetr.bsc.es> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Stefan Hajnoczi , Eduardo Habkost , Riku Voipio , qemu-devel@nongnu.org, Blue Swirl , =?UTF-8?Q?Andreas_F=c3=a4rber?= On 10/06/2016 19:52, Llu=C3=ADs Vilanova wrote: > Fair point. But now I feel tempted to change both trace_events_dstate a= nd > trace_events_enabled_count into unsigned int... it burns me when I see = signed > types used only on their positives by design. >=20 > But don't worry, I'll change trace_events_dstate into int :) unsigned int would be fine too. Paolo