Re: [PATCH 2/5] arm64: dts: qcom: Add base SM4450 QRD DTS

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
Cc: quic_tsoni@quicinc.com, quic_shashim@quicinc.com,
	quic_kaushalk@quicinc.com, quic_tdas@quicinc.com,
	quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: Add base SM4450 QRD DTS
Date: Wed, 19 Jul 2023 12:23:42 +0200	[thread overview]
Message-ID: <def2f081-49a6-3ab9-6bf4-d8672fa28a31@linaro.org> (raw)
In-Reply-To: <20230719100135.21325-3-quic_tengfan@quicinc.com>

On 19/07/2023 12:01, Tengfei Fan wrote:
> Add DTS for Qualcomm QRD platform which uses SM4450 SoC.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile       |  1 +
>  arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 337abc4ceb17..a0cfd37e674b 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -215,3 +215,4 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-sony-xperia-nagara-pdx223.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-sony-xperia-nagara-pdx224.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8550-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8550-qrd.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= sm4450-qrd.dtb

Messed order.

> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> new file mode 100644
> index 000000000000..851a6761a6ea
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "sm4450.dtsi"
> +/ {
> +	model = "Qualcomm Technologies, Inc. SM4450 QRD";
> +	compatible = "qcom,sm4450-qrd", "qcom,sm4450";

Missing bindings.

> +
> +	aliases { };
> +
> +	chosen {
> +		bootargs = " ";

Drop, useless.

OTOH, you miss here several properties. This is not even a basic board -
nothing works here, right? Please submit when you have at least serial
working.

> +	};
> +};

Best regards,
Krzysztof