From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FF4C54FCF for ; Wed, 25 Mar 2020 15:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4788520774 for ; Wed, 25 Mar 2020 15:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="1JyTDKPi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgCYPkt (ORCPT ); Wed, 25 Mar 2020 11:40:49 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38576 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727722AbgCYPkt (ORCPT ); Wed, 25 Mar 2020 11:40:49 -0400 Received: by mail-pl1-f194.google.com with SMTP id w3so934272plz.5 for ; Wed, 25 Mar 2020 08:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VJQwrHc5KYK1Moq3YLhA+cPCCwDV01vQIttVxXnXwtc=; b=1JyTDKPiJO30x26Vu1Vfe2MkHut80Eu7Wdc4i8X+qy6dwmGmseVAFDQ6WszS+sKQ2G JGg7ozTNVg/8hbbXyrmJcMb34TSODC1+oR+UUqOhQNnDwVgsxbZM13xKBFAXwnURMDYh VedK/p7dYdTAin6MFLxB5cx80u2rLqPr8EJYYYnyIMtaWe4Ifxdsqq8qgR3BE78h6jsM bAM98SrCRGfZBjL5yHHGuhvvmLqXIHS9zxoC9cz11gN+PHCiyFUcxDuH0PzZozte/Sri CTONI7IyWiE6+Tvq3jj4sHaGO8jtye+9L1Mz8y6kR4ovsdNjyaSl5RDhXCUS0bpG5v8v 4WVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VJQwrHc5KYK1Moq3YLhA+cPCCwDV01vQIttVxXnXwtc=; b=iCRMBg50FiwNvq7411SX1SzoBcDPLtNW4/BdaUHwLbKVKL9JBpN7FTi3SRZWRMM1zu Cspva4JEfqJEk8/kCAPVqU1vdPvUU3E4aLpttER1tHr0nCHK/cv5cFw3jiholvIwkyv/ 0TZHNjHJsNUktXhXir55JZiSWAb2SFg9k+vGVT+gSZ7Ri8SG0O/m8QgsVBJXurJNU7An JcPwmchxK5/76URW9enGbhqTMYBFsalSlEwy8WdH7XSMRdsgqZEfWub7mxqn/Lr0FLTx Zb4ujAGFWae8l+Vud6/4Rv4iLx58VRfiZ0ZOBWUKUPULjhmofubsMpuWAvcNK1SsDsoK zcSQ== X-Gm-Message-State: ANhLgQ1fXHh3nLkruc+DpDO+9CWYwPzG8pQWJbRbcI8odNnluvYCZpIk STM2zSxhbDDq13DG3Yof/VEATg== X-Google-Smtp-Source: ADFU+vt11pwSKIyZE73gAeB7bBFUnxt1iyuPeAwqagoBJzJF0qoXWAvo44C06Qoa0vIxZF23n5jzXw== X-Received: by 2002:a17:902:9a46:: with SMTP id x6mr3879020plv.80.1585150847821; Wed, 25 Mar 2020 08:40:47 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id g2sm11445369pfh.193.2020.03.25.08.40.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2020 08:40:46 -0700 (PDT) Subject: Re: [PATCH v2 01/11] block: factor out requeue handling from dispatch code To: Christoph Hellwig , Johannes Thumshirn Cc: linux-block , Damien Le Moal , Keith Busch , "linux-scsi @ vger . kernel . org" , "Martin K . Petersen" , "linux-fsdevel @ vger . kernel . org" , "Darrick J . Wong" , Christoph Hellwig References: <20200324152454.4954-1-johannes.thumshirn@wdc.com> <20200324152454.4954-2-johannes.thumshirn@wdc.com> <20200325084030.GB11943@infradead.org> From: Jens Axboe Message-ID: Date: Wed, 25 Mar 2020 09:40:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200325084030.GB11943@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/25/20 2:40 AM, Christoph Hellwig wrote: > On Wed, Mar 25, 2020 at 12:24:44AM +0900, Johannes Thumshirn wrote: >> Factor out the requeue handling from the dispatch code, this will make >> subsequent addition of different requeueing schemes easier. >> >> Signed-off-by: Johannes Thumshirn >> Reviewed-by: Christoph Hellwig > > Jens, can you pick this up? I think it already is a nice improvement > even without the rest of the series. Sure, applied for 5.7. -- Jens Axboe