From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33758 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933977AbcKWKUX (ORCPT ); Wed, 23 Nov 2016 05:20:23 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Wed, 23 Nov 2016 15:50:17 +0530 From: Tamizh chelvam To: Rob Herring Cc: c_traja@qti.qualcomm.com, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt In-Reply-To: <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> References: <1479383064-25718-1-git-send-email-c_traja@qti.qualcomm.com> <1479383064-25718-4-git-send-email-c_traja@qti.qualcomm.com> <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> Message-ID: (sfid-20161123_112106_288918_538B53EF) Sender: linux-wireless-owner@vger.kernel.org List-ID: Thanks for the comments. On 2016-11-18 20:14, Rob Herring wrote: > On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_traja@qti.qualcomm.com > wrote: >> From: Tamizh chelvam >> >> There two things done in this patch. >> >> 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. >> 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for >> BTCOEX priority feature support. >> >> Signed-off-by: Tamizh chelvam >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 74d7f0a..08150e2d 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -46,6 +46,10 @@ Optional properties: >> hw versions. >> - qcom,ath10k-pre-calibration-data : pre calibration data as an >> array, >> the length can vary between hw versions. >> +- btcoex_support : should contain eithr "0" or "1" to indicate >> btcoex >> + support by the hardware. > > This is BT coexistence? Make this boolean and n Yes, this is BT coexistence. And I didn't get what are you trying to say in this "Make this boolean and n" > >> +- btcoex_gpio_pin : btcoex gpio pin number for the device which >> + supports BTCOEX. > > This is a pin number on the chip, not any pin number Linux GPIO subsys > cares about, right? Is there a connection to the host too, or this is > internal between BT and WiFi? This is internal between BT and wifi. > > Do you really need 2 properties? Does supporting this feature require > the GPIO? If so, then the first property is redundant. > Target/driver can hard copy this gpio pin for some chipsets and there we will need btcoex_support flag to find the btcoex support. > Needs vendor prefix and don't use '_'. Should be something like > 'qcom,bt-coexist-gpio-pin'. > Sure I'll update this and send in v3 patch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamizh chelvam Subject: Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt Date: Wed, 23 Nov 2016 15:50:17 +0530 Message-ID: References: <1479383064-25718-1-git-send-email-c_traja@qti.qualcomm.com> <1479383064-25718-4-git-send-email-c_traja@qti.qualcomm.com> <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: c_traja-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org, ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Thanks for the comments. On 2016-11-18 20:14, Rob Herring wrote: > On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_traja-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org > wrote: >> From: Tamizh chelvam >> >> There two things done in this patch. >> >> 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. >> 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for >> BTCOEX priority feature support. >> >> Signed-off-by: Tamizh chelvam >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 74d7f0a..08150e2d 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -46,6 +46,10 @@ Optional properties: >> hw versions. >> - qcom,ath10k-pre-calibration-data : pre calibration data as an >> array, >> the length can vary between hw versions. >> +- btcoex_support : should contain eithr "0" or "1" to indicate >> btcoex >> + support by the hardware. > > This is BT coexistence? Make this boolean and n Yes, this is BT coexistence. And I didn't get what are you trying to say in this "Make this boolean and n" > >> +- btcoex_gpio_pin : btcoex gpio pin number for the device which >> + supports BTCOEX. > > This is a pin number on the chip, not any pin number Linux GPIO subsys > cares about, right? Is there a connection to the host too, or this is > internal between BT and WiFi? This is internal between BT and wifi. > > Do you really need 2 properties? Does supporting this feature require > the GPIO? If so, then the first property is redundant. > Target/driver can hard copy this gpio pin for some chipsets and there we will need btcoex_support flag to find the btcoex support. > Needs vendor prefix and don't use '_'. Should be something like > 'qcom,bt-coexist-gpio-pin'. > Sure I'll update this and send in v3 patch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c9UfT-0003wm-95 for ath10k@lists.infradead.org; Wed, 23 Nov 2016 10:20:47 +0000 MIME-Version: 1.0 Date: Wed, 23 Nov 2016 15:50:17 +0530 From: Tamizh chelvam Subject: Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt In-Reply-To: <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> References: <1479383064-25718-1-git-send-email-c_traja@qti.qualcomm.com> <1479383064-25718-4-git-send-email-c_traja@qti.qualcomm.com> <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rob Herring Cc: c_traja@qti.qualcomm.com, devicetree@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org Thanks for the comments. On 2016-11-18 20:14, Rob Herring wrote: > On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_traja@qti.qualcomm.com > wrote: >> From: Tamizh chelvam >> >> There two things done in this patch. >> >> 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. >> 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for >> BTCOEX priority feature support. >> >> Signed-off-by: Tamizh chelvam >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 74d7f0a..08150e2d 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -46,6 +46,10 @@ Optional properties: >> hw versions. >> - qcom,ath10k-pre-calibration-data : pre calibration data as an >> array, >> the length can vary between hw versions. >> +- btcoex_support : should contain eithr "0" or "1" to indicate >> btcoex >> + support by the hardware. > > This is BT coexistence? Make this boolean and n Yes, this is BT coexistence. And I didn't get what are you trying to say in this "Make this boolean and n" > >> +- btcoex_gpio_pin : btcoex gpio pin number for the device which >> + supports BTCOEX. > > This is a pin number on the chip, not any pin number Linux GPIO subsys > cares about, right? Is there a connection to the host too, or this is > internal between BT and WiFi? This is internal between BT and wifi. > > Do you really need 2 properties? Does supporting this feature require > the GPIO? If so, then the first property is redundant. > Target/driver can hard copy this gpio pin for some chipsets and there we will need btcoex_support flag to find the btcoex support. > Needs vendor prefix and don't use '_'. Should be something like > 'qcom,bt-coexist-gpio-pin'. > Sure I'll update this and send in v3 patch _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k