From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B54C31E46 for ; Wed, 12 Jun 2019 20:07:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 891F520896 for ; Wed, 12 Jun 2019 20:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UCQMeQgn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 891F520896 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34636 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb9X2-0007lR-Pz for qemu-devel@archiver.kernel.org; Wed, 12 Jun 2019 16:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46386) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb9Uz-00067z-L1 for qemu-devel@nongnu.org; Wed, 12 Jun 2019 16:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb9Uw-0004Jy-Gb for qemu-devel@nongnu.org; Wed, 12 Jun 2019 16:05:32 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:40387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb9Uu-0004Do-Jw for qemu-devel@nongnu.org; Wed, 12 Jun 2019 16:05:30 -0400 Received: by mail-pg1-x543.google.com with SMTP id d30so9517571pgm.7 for ; Wed, 12 Jun 2019 13:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NDEljNEiOPAUddn9rpYioR3XrTttvPAys7PCiBhFn48=; b=UCQMeQgng5MC2brB+6W4OeTNfpHyiJFZUZALd3WukRvpQ/Jb0pabxRGJ1lezx4qJES z+SVYkeRszAloRMlJ1UZHwxwyk46jwcuXWAtXy0Yrl9In/NjXI0HktPcxO0CFlsoUehp D9a1qk6CUfMChpLCdMdyl/NFQdUc1g/5s5q7x7nKJbLNk+4cO8Nt8F/Qr/65c/2VrVCo 9dG3Y0HLSW+YIC3tI3Os0C3TO2rELi76u0vhIAVJkYnHfpRmiILN2yYPItc+C7Ka0xsv jHaHZNCVHIScjJnzp9IfnGK663lZRAdlG1MfjRmksRRYfMR3lva+WWv4esR0k5HuECVN hVpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NDEljNEiOPAUddn9rpYioR3XrTttvPAys7PCiBhFn48=; b=lODcyfAakSQtfItU9IcNHfE5VnKdVTEbzTUYmuMH18BIxQtrsd26WR5eI1M7ZKCuZ7 3JXLc2pNuXZmLQAy4ZtmPYltrZ58dTyM7YlXSqpolznpqlgZNVVpZfxtEoipUVEfKsLr 6RMp82HX/UrWVCC2lZ78yBeU2GltRyKfO7ujqikAmqs9+ATRBQnjRV07WKPisL4mpMpD h8RN8qFcRHzLDcl16Si4EpAb6D8VzrBqzjPV+Yu/UKlrOPHZ2eNNopku6Hue9ZefqS6R 8kpHeYcetwFKeZPgS2pWjtGnHfd9J/wvy8AfnikDs1kSrOxKYEo846QJhtIEPCm83dP0 ZxUA== X-Gm-Message-State: APjAAAXwtkVqs/MyHcUgPoSYdTaN/q1+plMOTJpQOq5D/L5zNziCycnt gWlpCoDun6pguKOKaS+TUzMYhw== X-Google-Smtp-Source: APXvYqwATc9JIio0ugVO5wJzS+D2stJgoajcdiYslInfqyb94RyJdZy/JV+B9+xmv/azQRYL+YVIdQ== X-Received: by 2002:a63:d652:: with SMTP id d18mr27868641pgj.112.1560369924949; Wed, 12 Jun 2019 13:05:24 -0700 (PDT) Received: from [192.168.1.11] (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id w132sm385661pfd.78.2019.06.12.13.05.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2019 13:05:24 -0700 (PDT) To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net, gkurz@kaod.org References: <20190602110903.3431-1-mark.cave-ayland@ilande.co.uk> <20190602110903.3431-8-mark.cave-ayland@ilande.co.uk> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Wed, 12 Jun 2019 13:05:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190602110903.3431-8-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: Re: [Qemu-devel] [PATCH v2 07/15] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: > Rather than perform the VSR register decoding within the helper itself, > introduce a new GEN_VSX_HELPER_X2 macro which performs the decode based > upon xT and xB at translation time. > > With the previous change to the xscvqpdp generator and helper functions the > opcode parameter is no longer required in the common case and can be > removed. > > Signed-off-by: Mark Cave-Ayland > --- > target/ppc/fpu_helper.c | 36 +++------- > target/ppc/helper.h | 120 ++++++++++++++++---------------- > target/ppc/translate/vsx-impl.inc.c | 135 ++++++++++++++++++++---------------- > 3 files changed, 144 insertions(+), 147 deletions(-) Reviewed-by: Richard Henderson r~