From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtprelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E19A68
	for <linux-staging@lists.linux.dev>; Mon,  1 Nov 2021 04:31:30 +0000 (UTC)
Received: from omf04.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
	by smtprelay01.hostedemail.com (Postfix) with ESMTP id E181C100E5214;
	Mon,  1 Nov 2021 04:31:22 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id 5F65BD1514;
	Mon,  1 Nov 2021 04:31:21 +0000 (UTC)
Message-ID: <df0f1d2a911acce47eb4525ff4791c751b72821a.camel@perches.com>
Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement
From: Joe Perches <joe@perches.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>, Pavel Skripkin
	 <paskripkin@gmail.com>, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, 
	gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, 
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Date: Sun, 31 Oct 2021 21:31:20 -0700
In-Reply-To: <7f406b96-fbfd-bd3e-182b-3ca8b3056635@gmail.com>
References: <YX7cCtVss2RWOJ/a@Sauravs-MacBook-Air.local>
	 <f26b4aec-c0a1-8c93-b34e-8b1a36ac81b3@gmail.com>
	 <bc976b72692512f33ae90183f588af38a06a2aa1.camel@perches.com>
	 <7f406b96-fbfd-bd3e-182b-3ca8b3056635@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1 
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.38
X-Stat-Signature: f1rap3rt6r4iick1wtz1o3nh4ehw4rnd
X-Rspamd-Server: rspamout03
X-Rspamd-Queue-Id: 5F65BD1514
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX1+jEJ6gS/hjU1Ex8EJKzyQu6Ji0Itq6+hk=
X-HE-Tag: 1635741081-964563

On Mon, 2021-11-01 at 09:58 +0530, Saurav Girepunje wrote:
> On 01/11/21 12:47 am, Joe Perches wrote:
> > On Sun, 2021-10-31 at 21:43 +0300, Pavel Skripkin wrote:
> > > On 10/31/21 21:10, Saurav Girepunje wrote:
> > > > Remove the goto statement from rtw_init_drv_sw(). In this function goto
> > > > can be replace by return statement. As on goto label exit, function
> > > > only return it is not performing any cleanup. Avoiding goto will
> > > > improve the function readability.
[]
> > > And just `return _SUCCESS;` here.
> > 
> > And maybe one day s/_SUCCESS/true/ and s/_FAIL/false/
> > with appropriate conversions to bool
> 
> Yes this is another improvement possible on this function.

Not just this function, globally in the driver.