From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936205AbeEYOGr (ORCPT ); Fri, 25 May 2018 10:06:47 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:58242 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934614AbeEYOGp (ORCPT ); Fri, 25 May 2018 10:06:45 -0400 X-IronPort-AV: E=Sophos;i="5.49,440,1520924400"; d="scan'208";a="14347743" Subject: Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd To: Richard Genoud , "devicetree@vger.kernel.org" , , , , CC: , , , , , , , References: <20180511103822.31698-1-radu.pirea@microchip.com> <20180511103822.31698-7-radu.pirea@microchip.com> <4a75568e-a52e-3872-f465-d707372a5c12@sorico.fr> <95a51c6c69bf1a2422f545ac1f06846ebcdb186a.camel@microchip.com> <4d70c73e-9db7-bdff-7414-04a4843acae3@sorico.fr> <391de5c1-45d7-4773-fe57-7f2bc747214b@microchip.com> From: Radu Pirea Message-ID: Date: Fri, 25 May 2018 17:07:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2018 04:35 PM, Richard Genoud wrote: > On 25/05/2018 14:17, Radu Pirea wrote: >> >> >> On 05/15/2018 04:14 PM, Richard Genoud wrote: >>> On 15/05/2018 14:47, Radu Pirea wrote: >>>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>>> After your patch, the DMA is not selected anymore: >>>>> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >>>>> available, switch to pio >>>>> instead of: >>>>> atmel_usart fffff200.serial: using dma1chan2 for tx DMA transfers >>>>> >>>> Fixed. >>>>> And the kernel doesn't log anymore on the serial console, despite the >>>>> loglevel=8 >>>>> (after reverting this series, the kernel logs reappears on the serial >>>>> console) >>>>> >>>> Which serial are you using as console? >>> fffff200.serial (sam9g35-cm) >>> ( stdout-path = "serial0:115200n8"; in the DTS ) >>> >>> With this series applied, all the kernel log goes on the screen. >>> Without, it goes on the serial debug. >>> >> I tested again with archlinux arm and poky-linux4sam release as distros >> and kernel log goes on the serial debug. Can you give me more details >> like cmdline? > I used kernel 4.17-rc6 > at91_dt_defconfig > at91sam9g35ek.dtb > > Kernel command line: root=/dev/mtdblock1 rw rootfstype=ubifs ubi.mtd=1 root=ubi0:rootfs I reproduced your issue. If in cmdline console is not set like this "console=ttyS0,115200", the console goes to the lcd. > ( the one from the DTS ) > > Detailed instructions: > > git checkout v4.17-rc6 > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 at91_dt_defconfig > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I see the logs on the serial debug ] > > git am \[PATCH\ v3\ [1-6]* > > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I don't see the logs on the serial debug anymore ] > > >>>>> (tests done on sam9g35) >>>>> >>>> I will consider the rest of suggestions. >>>>> regards, >>>>> Richard >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radu Pirea Subject: Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd Date: Fri, 25 May 2018 17:07:56 +0300 Message-ID: References: <20180511103822.31698-1-radu.pirea@microchip.com> <20180511103822.31698-7-radu.pirea@microchip.com> <4a75568e-a52e-3872-f465-d707372a5c12@sorico.fr> <95a51c6c69bf1a2422f545ac1f06846ebcdb186a.camel@microchip.com> <4d70c73e-9db7-bdff-7414-04a4843acae3@sorico.fr> <391de5c1-45d7-4773-fe57-7f2bc747214b@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Richard Genoud , "devicetree@vger.kernel.org" , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Cc: mark.rutland@arm.com, robh+dt@kernel.org, lee.jones@linaro.org, gregkh@linuxfoundation.org, jslaby@suse.com, alexandre.belloni@bootlin.com, nicolas.ferre@microchip.com, broonie@kernel.org List-Id: devicetree@vger.kernel.org On 05/25/2018 04:35 PM, Richard Genoud wrote: > On 25/05/2018 14:17, Radu Pirea wrote: >> >> >> On 05/15/2018 04:14 PM, Richard Genoud wrote: >>> On 15/05/2018 14:47, Radu Pirea wrote: >>>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>>> After your patch, the DMA is not selected anymore: >>>>> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >>>>> available, switch to pio >>>>> instead of: >>>>> atmel_usart fffff200.serial: using dma1chan2 for tx DMA transfers >>>>> >>>> Fixed. >>>>> And the kernel doesn't log anymore on the serial console, despite the >>>>> loglevel=8 >>>>> (after reverting this series, the kernel logs reappears on the serial >>>>> console) >>>>> >>>> Which serial are you using as console? >>> fffff200.serial (sam9g35-cm) >>> ( stdout-path = "serial0:115200n8"; in the DTS ) >>> >>> With this series applied, all the kernel log goes on the screen. >>> Without, it goes on the serial debug. >>> >> I tested again with archlinux arm and poky-linux4sam release as distros >> and kernel log goes on the serial debug. Can you give me more details >> like cmdline? > I used kernel 4.17-rc6 > at91_dt_defconfig > at91sam9g35ek.dtb > > Kernel command line: root=/dev/mtdblock1 rw rootfstype=ubifs ubi.mtd=1 root=ubi0:rootfs I reproduced your issue. If in cmdline console is not set like this "console=ttyS0,115200", the console goes to the lcd. > ( the one from the DTS ) > > Detailed instructions: > > git checkout v4.17-rc6 > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 at91_dt_defconfig > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I see the logs on the serial debug ] > > git am \[PATCH\ v3\ [1-6]* > > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I don't see the logs on the serial debug anymore ] > > >>>>> (tests done on sam9g35) >>>>> >>>> I will consider the rest of suggestions. >>>>> regards, >>>>> Richard >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: radu.pirea@microchip.com (Radu Pirea) Date: Fri, 25 May 2018 17:07:56 +0300 Subject: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd In-Reply-To: References: <20180511103822.31698-1-radu.pirea@microchip.com> <20180511103822.31698-7-radu.pirea@microchip.com> <4a75568e-a52e-3872-f465-d707372a5c12@sorico.fr> <95a51c6c69bf1a2422f545ac1f06846ebcdb186a.camel@microchip.com> <4d70c73e-9db7-bdff-7414-04a4843acae3@sorico.fr> <391de5c1-45d7-4773-fe57-7f2bc747214b@microchip.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/25/2018 04:35 PM, Richard Genoud wrote: > On 25/05/2018 14:17, Radu Pirea wrote: >> >> >> On 05/15/2018 04:14 PM, Richard Genoud wrote: >>> On 15/05/2018 14:47, Radu Pirea wrote: >>>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>>> After your patch, the DMA is not selected anymore: >>>>> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >>>>> available, switch to pio >>>>> instead of: >>>>> atmel_usart fffff200.serial: using dma1chan2 for tx DMA transfers >>>>> >>>> Fixed. >>>>> And the kernel doesn't log anymore on the serial console, despite the >>>>> loglevel=8 >>>>> (after reverting this series, the kernel logs reappears on the serial >>>>> console) >>>>> >>>> Which serial are you using as console? >>> fffff200.serial (sam9g35-cm) >>> ( stdout-path = "serial0:115200n8"; in the DTS ) >>> >>> With this series applied, all the kernel log goes on the screen. >>> Without, it goes on the serial debug. >>> >> I tested again with archlinux arm and poky-linux4sam release as distros >> and kernel log goes on the serial debug. Can you give me more details >> like cmdline? > I used kernel 4.17-rc6 > at91_dt_defconfig > at91sam9g35ek.dtb > > Kernel command line: root=/dev/mtdblock1 rw rootfstype=ubifs ubi.mtd=1 root=ubi0:rootfs I reproduced your issue. If in cmdline console is not set like this "console=ttyS0,115200", the console goes to the lcd. > ( the one from the DTS ) > > Detailed instructions: > > git checkout v4.17-rc6 > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 at91_dt_defconfig > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I see the logs on the serial debug ] > > git am \[PATCH\ v3\ [1-6]* > > ARCH=arm CROSS_COMPILE=path_to_my_Xchain/arm-linux- LOADADDR=0x20008000 make -j 12 uImage at91sam9g35ek.dtb > cp arch/arm/boot/uImage arch/arm/boot/dts/at91sam9g35ek.dtb /tftpboot/ > > From uboot: > tftpboot 0x20007FC0 uImage > tftpboot 0x26400000 at91sam9g35ek.dtb > bootm 0x20007FC0 - 0x26400000 > > [ I don't see the logs on the serial debug anymore ] > > >>>>> (tests done on sam9g35) >>>>> >>>> I will consider the rest of suggestions. >>>>> regards, >>>>> Richard >>> >