From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C700CCA47C for ; Sun, 26 Jun 2022 14:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234393AbiFZOKR (ORCPT ); Sun, 26 Jun 2022 10:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbiFZOKQ (ORCPT ); Sun, 26 Jun 2022 10:10:16 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EADF9588; Sun, 26 Jun 2022 07:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656252590; bh=yTusrjLOKRKwRvbd8R+ykK/3/JvyRwhEMn0DfEPv1UQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=OEFvmYruw9c/MQw0Bb57+QhL/P3LfieAzofQsvHzfZU4qHFtZ6YCY8fGF49l0nlN7 d91HEORwKcv5+VjBO7JThNTMwrXuURI0wsAnEPtqyY2qup8tlyKEsWkJ4ssvDt+5UI zowxewehHN5/BKy76GTg0uolk6B6+T4mtj0AoFvw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.33] ([46.223.2.248]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mk0NU-1nLMYg0rea-00kNyS; Sun, 26 Jun 2022 16:09:50 +0200 Subject: Re: [PATCH 7/8] serial: ar933x: Remove redundant assignment in rs485_config To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= Cc: Greg Kroah-Hartman , Jiri Slaby , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Andy Shevchenko , vz@mleia.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-serial , LKML , lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-8-LinoSanfilippo@gmx.de> From: Lino Sanfilippo Message-ID: Date: Sun, 26 Jun 2022 16:09:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:HPs9BkINPOugQ76QtMRekLInNgNbeZHcwpIRkgAQ+/3JpS8T0E5 na8Gv2u7zhVw+/nGBiNBdETNueMeS2z0KYd8T+thup1HRX8cPEQWHJCRUme+sLjOVrY9j/v HGcmWJriW/REC6uIJyGdMquWHsEvzy69rHxqpAYt9v/R5gyUAza+rlq5uqy7XN/wV2Lgtdk vRA0qQqnky+Ef3Gyj9OZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:0M5kIdMhVrk=:srVvd9zQL+xSR57YuedoOV /klAYSy3rvIMzmA00If2+O4UcMWsOhuIcPzEln880XwVg6Y45DlNZbRfjjT31dPXqvdzb8edr DqkggG9E11HTUgKrHMvl+zNrkd6B5STjmN4B5ApRWcta0kz5TcyaDndDYHh7HH9ytgM0JSFjS jLgPGGM9A9zzfi2kz4N+dcXgHAagTGwhxgYU+1scp7M6qsXGVv2Z5mOtitep1jMYajpZ643ek L+gM5O/J39AHGSHMaS2+YS2i4ley2UnoIUOhG8gb8QW+XmGYHAT8hR9p+3opzut2JT4hH27W+ NwBeHqNfN+wDP9HnGwIufJRrYw1OaNcS3zotqpRIYeNf0zSzGgdRBg1kbElmD5JKY6N+ePIK7 BwHjI/Sh/OOYxShROfH+airEgIlq2E1P+jC5YM19MFhJi0yb+DLtgXKQWziVQ3F+AYexp9FhG YQVM59n1577iA7LSKWdR90/P3trIpAn3QGdHBXMs6sReNShW1yPmpMK5SzTrK0sidY0MQddb5 zPE44nmHBqceHQFGwpLTL5/S03oMo24+BFb7XAIZoa5mtINsVnN07oUkUUAtRY7fLXX98sa3g JvvtASfBu5+OKrlMoSJ9t4kp/bKPDcUbSla/Ar8+Lk0edH/zqswF27WVb6FKK4wj4EspC5w2F c77ZUt8MuJZ+f5QO+KP88UxrcnHlIZAp6L2W6hpjDclzIPNfPhDALw+S4jclNRAm9G5G9pkBu HfAU3VcEEh5PKS6zfkrDr/Wp3FrJnKDyR1QoHtsCjYwJrjT5D1nNfLLQTbuvMzVTnoX8q+ZKU xO9r3a7e1WOdqLE6dW15E9lerGP26whbH6uMdePSU5WHnErLNgd60EmRqkruUfUViCipkI3Az ON7noMgBcVNDapFc0YeKr0bEKtlkuC+F035YTYAi+oeVSIw0kTIK1xYwIayFY8wrvTuIGSjwc cz4wXmFxGI/UgqL0sXvTQb/R0lRAwaMtmo4hpfLlbjeldAFHLliY9p7Z+yXFEFwX7azljTmAp PkAutccHGbPK82e4mOOsstpwmh0K74VrAizX2IGTo72I8CDF5czBic0XQBrEPXpOZWAcBZp/P hZrP9muQ960wbyBcKxKfZtxKyDt/F5TJtG/VlEkRrA9qGIgA1s23EPv/Q== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.06.22 at 12:14, Ilpo J=C3=A4rvinen wrote: > On Wed, 22 Jun 2022, Lino Sanfilippo wrote: > >> From: Lino Sanfilippo >> >> In uart_set_rs485_config() the serial core already assigns the passed >> serial_rs485 struct to the uart port. >> >> So remove the assignment in the drivers rs485_config() function to avoi= d >> redundancy. >> >> Signed-off-by: Lino Sanfilippo >> --- >> drivers/tty/serial/ar933x_uart.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/tty/serial/ar933x_uart.c b/drivers/tty/serial/ar93= 3x_uart.c >> index ab2c5b2a1ce8..857e010d01dc 100644 >> --- a/drivers/tty/serial/ar933x_uart.c >> +++ b/drivers/tty/serial/ar933x_uart.c >> @@ -591,7 +591,6 @@ static int ar933x_config_rs485(struct uart_port *po= rt, >> dev_err(port->dev, "RS485 needs rts-gpio\n"); >> return 1; >> } >> - port->rs485 =3D *rs485conf; >> return 0; >> } > > Hmm, I realize that for some reason I missed cleaning up this particular > driver after introducing the serial_rs485 sanitization. It shouldn't nee= d > that preceeding if block either because ar933x_no_rs485 gets applied if > there's no rts_gpiod so the core clears SER_RS485_ENABLED. > I think we still need that "if" in case that RS485 was not enabled at driv= er startup (no rs485-enabled-at-boot-time) and no RTS GPIO was defined but th= en RS485 is enabled via TIOCSRS485. Maybe in ar933x_uart_probe() if ((port->rs485.flags & SER_RS485_ENABLED) && !up->rts_gpiod) { dev_err(&pdev->dev, "lacking rts-gpio, disabling RS485\n"); port->rs485.flags &=3D ~SER_RS485_ENABLED; port->rs485_supported =3D &ar933x_no_rs485; } should rather be if (!up->rts_gpiod) { dev_err(&pdev->dev, "lacking rts-gpio, disabling RS485\n"); port->rs485.flags &=3D ~SER_RS485_ENABLED; port->rs485_supported =3D &ar933x_no_rs485; } Regards, Lino From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC6ECC43334 for ; Sun, 26 Jun 2022 14:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=c60T6R4boiu2JyTD8aI28IQtmBw1/qhDZang0RBMrfU=; b=sr2eZocotCX92CFYLPNGGqTRvb n+SctbP5XmCyAaQ9FI8B77CzX5lzxFdr5chX4cPaIpfhsrlZoUpksobsHmMoA/T9oAq3sVYyML6Yr GXqIrlnIncmywo55hox+tbE0LoCvfgwMUM0IHSaxJVaSHhURf7pMvxHodYViW5ru+f60Ww62zR7lH 5VL+H5QwivKv9ax+iD/p6MNZlHislI8ojMsH/jsOCeKVniwcP3HBYUvixC3Uc9KYiWg+ECQmLrvDt NjJcJSCu8Z9uSLT2rgKToknpjrRqoRSgF9ujtG4Di94Tu15X9hG1gArB4jdKFP5M15yoK7TFlvcha Ll1tPnng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Sxl-00C6Ky-PU; Sun, 26 Jun 2022 14:10:09 +0000 Received: from mout.gmx.net ([212.227.17.22]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5Sxi-00C6K3-7D for linux-arm-kernel@lists.infradead.org; Sun, 26 Jun 2022 14:10:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656252590; bh=yTusrjLOKRKwRvbd8R+ykK/3/JvyRwhEMn0DfEPv1UQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=OEFvmYruw9c/MQw0Bb57+QhL/P3LfieAzofQsvHzfZU4qHFtZ6YCY8fGF49l0nlN7 d91HEORwKcv5+VjBO7JThNTMwrXuURI0wsAnEPtqyY2qup8tlyKEsWkJ4ssvDt+5UI zowxewehHN5/BKy76GTg0uolk6B6+T4mtj0AoFvw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.33] ([46.223.2.248]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mk0NU-1nLMYg0rea-00kNyS; Sun, 26 Jun 2022 16:09:50 +0200 Subject: Re: [PATCH 7/8] serial: ar933x: Remove redundant assignment in rs485_config To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= Cc: Greg Kroah-Hartman , Jiri Slaby , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Andy Shevchenko , vz@mleia.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-serial , LKML , lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-8-LinoSanfilippo@gmx.de> From: Lino Sanfilippo Message-ID: Date: Sun, 26 Jun 2022 16:09:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:HPs9BkINPOugQ76QtMRekLInNgNbeZHcwpIRkgAQ+/3JpS8T0E5 na8Gv2u7zhVw+/nGBiNBdETNueMeS2z0KYd8T+thup1HRX8cPEQWHJCRUme+sLjOVrY9j/v HGcmWJriW/REC6uIJyGdMquWHsEvzy69rHxqpAYt9v/R5gyUAza+rlq5uqy7XN/wV2Lgtdk vRA0qQqnky+Ef3Gyj9OZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:0M5kIdMhVrk=:srVvd9zQL+xSR57YuedoOV /klAYSy3rvIMzmA00If2+O4UcMWsOhuIcPzEln880XwVg6Y45DlNZbRfjjT31dPXqvdzb8edr DqkggG9E11HTUgKrHMvl+zNrkd6B5STjmN4B5ApRWcta0kz5TcyaDndDYHh7HH9ytgM0JSFjS jLgPGGM9A9zzfi2kz4N+dcXgHAagTGwhxgYU+1scp7M6qsXGVv2Z5mOtitep1jMYajpZ643ek L+gM5O/J39AHGSHMaS2+YS2i4ley2UnoIUOhG8gb8QW+XmGYHAT8hR9p+3opzut2JT4hH27W+ NwBeHqNfN+wDP9HnGwIufJRrYw1OaNcS3zotqpRIYeNf0zSzGgdRBg1kbElmD5JKY6N+ePIK7 BwHjI/Sh/OOYxShROfH+airEgIlq2E1P+jC5YM19MFhJi0yb+DLtgXKQWziVQ3F+AYexp9FhG YQVM59n1577iA7LSKWdR90/P3trIpAn3QGdHBXMs6sReNShW1yPmpMK5SzTrK0sidY0MQddb5 zPE44nmHBqceHQFGwpLTL5/S03oMo24+BFb7XAIZoa5mtINsVnN07oUkUUAtRY7fLXX98sa3g JvvtASfBu5+OKrlMoSJ9t4kp/bKPDcUbSla/Ar8+Lk0edH/zqswF27WVb6FKK4wj4EspC5w2F c77ZUt8MuJZ+f5QO+KP88UxrcnHlIZAp6L2W6hpjDclzIPNfPhDALw+S4jclNRAm9G5G9pkBu HfAU3VcEEh5PKS6zfkrDr/Wp3FrJnKDyR1QoHtsCjYwJrjT5D1nNfLLQTbuvMzVTnoX8q+ZKU xO9r3a7e1WOdqLE6dW15E9lerGP26whbH6uMdePSU5WHnErLNgd60EmRqkruUfUViCipkI3Az ON7noMgBcVNDapFc0YeKr0bEKtlkuC+F035YTYAi+oeVSIw0kTIK1xYwIayFY8wrvTuIGSjwc cz4wXmFxGI/UgqL0sXvTQb/R0lRAwaMtmo4hpfLlbjeldAFHLliY9p7Z+yXFEFwX7azljTmAp PkAutccHGbPK82e4mOOsstpwmh0K74VrAizX2IGTo72I8CDF5czBic0XQBrEPXpOZWAcBZp/P hZrP9muQ960wbyBcKxKfZtxKyDt/F5TJtG/VlEkRrA9qGIgA1s23EPv/Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220626_071006_599403_FD357D5F X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjUuMDYuMjIgYXQgMTI6MTQsIElscG8gSsOkcnZpbmVuIHdyb3RlOgo+IE9uIFdlZCwgMjIg SnVuIDIwMjIsIExpbm8gU2FuZmlsaXBwbyB3cm90ZToKPgo+PiBGcm9tOiBMaW5vIFNhbmZpbGlw cG8gPGwuc2FuZmlsaXBwb0BrdW5idXMuY29tPgo+Pgo+PiBJbiB1YXJ0X3NldF9yczQ4NV9jb25m aWcoKSB0aGUgc2VyaWFsIGNvcmUgYWxyZWFkeSBhc3NpZ25zIHRoZSBwYXNzZWQKPj4gc2VyaWFs X3JzNDg1IHN0cnVjdCB0byB0aGUgdWFydCBwb3J0Lgo+Pgo+PiBTbyByZW1vdmUgdGhlIGFzc2ln bm1lbnQgaW4gdGhlIGRyaXZlcnMgcnM0ODVfY29uZmlnKCkgZnVuY3Rpb24gdG8gYXZvaWQKPj4g cmVkdW5kYW5jeS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTGlubyBTYW5maWxpcHBvIDxsLnNhbmZp bGlwcG9Aa3VuYnVzLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL3R0eS9zZXJpYWwvYXI5MzN4X3Vh cnQuYyB8IDEgLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvdHR5L3NlcmlhbC9hcjkzM3hfdWFydC5jIGIvZHJpdmVycy90dHkvc2Vy aWFsL2FyOTMzeF91YXJ0LmMKPj4gaW5kZXggYWIyYzViMmExY2U4Li44NTdlMDEwZDAxZGMgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC9hcjkzM3hfdWFydC5jCj4+ICsrKyBiL2Ry aXZlcnMvdHR5L3NlcmlhbC9hcjkzM3hfdWFydC5jCj4+IEBAIC01OTEsNyArNTkxLDYgQEAgc3Rh dGljIGludCBhcjkzM3hfY29uZmlnX3JzNDg1KHN0cnVjdCB1YXJ0X3BvcnQgKnBvcnQsCj4+ICAJ CWRldl9lcnIocG9ydC0+ZGV2LCAiUlM0ODUgbmVlZHMgcnRzLWdwaW9cbiIpOwo+PiAgCQlyZXR1 cm4gMTsKPj4gIAl9Cj4+IC0JcG9ydC0+cnM0ODUgPSAqcnM0ODVjb25mOwo+PiAgCXJldHVybiAw Owo+PiAgfQo+Cj4gSG1tLCBJIHJlYWxpemUgdGhhdCBmb3Igc29tZSByZWFzb24gSSBtaXNzZWQg Y2xlYW5pbmcgdXAgdGhpcyBwYXJ0aWN1bGFyCj4gZHJpdmVyIGFmdGVyIGludHJvZHVjaW5nIHRo ZSBzZXJpYWxfcnM0ODUgc2FuaXRpemF0aW9uLiBJdCBzaG91bGRuJ3QgbmVlZAo+IHRoYXQgcHJl Y2VlZGluZyBpZiBibG9jayBlaXRoZXIgYmVjYXVzZSBhcjkzM3hfbm9fcnM0ODUgZ2V0cyBhcHBs aWVkIGlmCj4gdGhlcmUncyBubyBydHNfZ3Bpb2Qgc28gdGhlIGNvcmUgY2xlYXJzIFNFUl9SUzQ4 NV9FTkFCTEVELgo+CgpJIHRoaW5rIHdlIHN0aWxsIG5lZWQgdGhhdCAiaWYiIGluIGNhc2UgdGhh dCBSUzQ4NSB3YXMgbm90IGVuYWJsZWQgYXQgZHJpdmVyCnN0YXJ0dXAgKG5vIHJzNDg1LWVuYWJs ZWQtYXQtYm9vdC10aW1lKSBhbmQgbm8gUlRTIEdQSU8gd2FzIGRlZmluZWQgYnV0IHRoZW4KUlM0 ODUgaXMgZW5hYmxlZCB2aWEgVElPQ1NSUzQ4NS4KCk1heWJlIGluIGFyOTMzeF91YXJ0X3Byb2Jl KCkKCglpZiAoKHBvcnQtPnJzNDg1LmZsYWdzICYgU0VSX1JTNDg1X0VOQUJMRUQpICYmCgkgICAg IXVwLT5ydHNfZ3Bpb2QpIHsKCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJsYWNraW5nIHJ0cy1ncGlv LCBkaXNhYmxpbmcgUlM0ODVcbiIpOwoJCXBvcnQtPnJzNDg1LmZsYWdzICY9IH5TRVJfUlM0ODVf RU5BQkxFRDsKCQlwb3J0LT5yczQ4NV9zdXBwb3J0ZWQgPSAmYXI5MzN4X25vX3JzNDg1OwoJfQoK c2hvdWxkIHJhdGhlciBiZQoKCWlmICghdXAtPnJ0c19ncGlvZCkgewoJCWRldl9lcnIoJnBkZXYt PmRldiwgImxhY2tpbmcgcnRzLWdwaW8sIGRpc2FibGluZyBSUzQ4NVxuIik7CgkJcG9ydC0+cnM0 ODUuZmxhZ3MgJj0gflNFUl9SUzQ4NV9FTkFCTEVEOwoJCXBvcnQtPnJzNDg1X3N1cHBvcnRlZCA9 ICZhcjkzM3hfbm9fcnM0ODU7Cgl9CgoKCgpSZWdhcmRzLApMaW5vCgoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==