From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
"Joseph S. Barrera III" <joebar@chromium.org>
Subject: Re: [PATCH 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
Date: Fri, 29 Apr 2022 08:30:46 +0200 [thread overview]
Message-ID: <df1e8dd6-5d26-f3de-b9f5-643a73390517@linaro.org> (raw)
In-Reply-To: <CAE-0n50ORzU52KpSPUNeEke-16uWo+Vn8WVhcdtdCc6WJiji6A@mail.gmail.com>
On 28/04/2022 18:01, Stephen Boyd wrote:
>>
>>> Given that none of the properties are
>>> required for google,cros-ec-keyb it didn't seem necessary to make having
>>> the google,cros-ec-keyb-switches compatible deny the existence of the
>>> matrix-keymap properties.
>>
>> Maybe I misunderstood the commit msg. Are the
>> "google,cros-ec-keyb-switches" devices coming with matrix keyboard or
>> not? I mean physically.
>>
>
> The answer is "sometimes, physically". Sometimes there are switches like
> volume buttons and power buttons and also a matrix keyboard (convertible
> and clamshells). Other times there are volume buttons and power buttons
> and no matrix keyboard (detachable). This device node represents both
> the keyboard and the switches.
>
> Unfortunately the EC firmware on older Chromebooks that don't have a
> matrix keyboard still report that they have some number of columns and
> rows. I was hoping to make this fully dynamic by querying the EC but
> that isn't possible.
OK, then it's indeed slightly different case. Let's skip my comment.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-29 6:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 20:30 [PATCH 0/2] Input: cros-ec-keyb: Better matrixless support Stephen Boyd
2022-04-27 20:30 ` [PATCH 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible Stephen Boyd
2022-04-28 6:12 ` Krzysztof Kozlowski
2022-04-28 6:24 ` Stephen Boyd
2022-04-28 7:27 ` Krzysztof Kozlowski
2022-04-28 16:01 ` Stephen Boyd
2022-04-29 6:30 ` Krzysztof Kozlowski [this message]
2022-04-29 6:31 ` Krzysztof Kozlowski
2022-04-29 16:31 ` Doug Anderson
2022-04-29 16:35 ` Krzysztof Kozlowski
2022-04-29 19:34 ` Stephen Boyd
2022-04-27 20:30 ` [PATCH 2/2] Input: cros-ec-keyb - skip keyboard registration for switches compatible Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df1e8dd6-5d26-f3de-b9f5-643a73390517@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=hsinyi@chromium.org \
--cc=joebar@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.