From: Adrian Hunter <adrian.hunter@intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Leo Yan <leo.yan@linaro.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 6/6] perf intel-pt: Add guest_code support
Date: Fri, 13 May 2022 18:14:49 +0300 [thread overview]
Message-ID: <df56f04b-cb25-5a47-ffef-b2e2ee0f6b74@intel.com> (raw)
In-Reply-To: <875ym9h4mt.fsf@linux.intel.com>
On 13/05/22 17:46, Andi Kleen wrote:
> Adrian Hunter <adrian.hunter@intel.com> writes:
>
>> A common case for KVM test programs is that the guest object code can be
>> found in the hypervisor process (i.e. the test program running on the
>> host). To support that, a new option "--guest-code" has been added in
>> previous patches.
>>
>> In this patch, add support also to Intel PT.
>>
>> In particular, ensure guest_code thread is set up before attempting to
>> walk object code or synthesize samples.
>
> Can you make it clear in the documentation what parts runs on the host
> and what parts on the guest?
That is up to the test program. All the host thread maps are
copied, so perf tools doesn't have to know.
>
> I'm still not fully sure how it exactly finds the code on the host,
> how is the code transferred?
I don't know. From a quick look at the code in
tools/testing/selftests/kvm/lib/kvm_util.c it seems to be using
KVM_SET_USER_MEMORY_REGION IOCTL.
>
> Other than that more support for this use case is very useful.
>
> -Andi
next prev parent reply other threads:[~2022-05-13 15:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 9:02 [PATCH 0/6] perf intel-pt: Add support for tracing KVM test programs Adrian Hunter
2022-05-13 9:02 ` [PATCH 1/6] perf tools: Add machine to machines back pointer Adrian Hunter
2022-05-13 9:02 ` [PATCH 2/6] perf tools: Factor out thread__set_guest_comm() Adrian Hunter
2022-05-13 9:02 ` [PATCH 3/6] perf tools: Add guest_code support Adrian Hunter
2022-05-17 3:13 ` Namhyung Kim
2022-05-17 4:54 ` Adrian Hunter
2022-05-13 9:02 ` [PATCH 4/6] perf script: " Adrian Hunter
2022-05-13 9:02 ` [PATCH 5/6] perf kvm report: " Adrian Hunter
2022-05-13 9:02 ` [PATCH 6/6] perf intel-pt: " Adrian Hunter
2022-05-13 14:46 ` Andi Kleen
2022-05-13 15:14 ` Adrian Hunter [this message]
2022-05-13 18:13 ` Andi Kleen
2022-05-15 7:27 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df56f04b-cb25-5a47-ffef-b2e2ee0f6b74@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.