From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7FDC433E0 for ; Sat, 18 Jul 2020 18:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C9E12073A for ; Sat, 18 Jul 2020 18:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k/rCH+bE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbgGRSx4 (ORCPT ); Sat, 18 Jul 2020 14:53:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRSx4 (ORCPT ); Sat, 18 Jul 2020 14:53:56 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED289C0619D2 for ; Sat, 18 Jul 2020 11:53:55 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id a9so2402643pjd.3 for ; Sat, 18 Jul 2020 11:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KQ0gu/5Hh5Q+9P9R+O/Myovmxbwkp3lHGHtP06q+gic=; b=k/rCH+bE4VDJdnsnQph887pSuAPa1DklyXIO/nVVTnsJ/bAj3Aey62Zl/cC3QSYV27 gDKNV9gZtXVNg/a48K4uWok6wwbLR9VxQdk1unpnGVIXXzXSrSbejEm3RJOWxUr1xcjP 7oGpPmm4hQuK3W569hNs5UM8FHKCkFmEpzGpOwHXRS29LpCoThD2xMQDx6iM4Ux82iWn 1ZlSoeaFZWuDIWZ6ogolUbF4QIko9m/nvt3S3UG9DayyyGdPdoKXthXLsZRhkY8L8ohO KlHbM/kfzZjwLUj+xo/TgwZCsz7gTQBK1/L9EPbzFFt4LOPYxWoHtWaFo+CKFQCj5TCK 3qyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KQ0gu/5Hh5Q+9P9R+O/Myovmxbwkp3lHGHtP06q+gic=; b=hJVetq487hM3V3ahoMgIcWM7/H2c/3rm5+nCcSx0MOBlfYCXtmWXb71zd+7J2GYrT2 Csw6bFYJT70l9/pP1m1D8pRqPFNiW+i8jpfbGKLtT0mr/6o/Dj2gv4WWT9hwomeROgK+ QENQaNPdNLXNC+O2tDzn9CS+KS7hEdYb4zT16II+9+lIO+VfTDADQC3F/CYm5Ht5rP71 eUZWK4s57y1JBf9DkkKXGW0e2WJd0FN+qE3/fstaS1hRrgGUO7d3D3vUi9ZQwFqXLaQ5 KUUg7uvKaA0Y+LIfkSahRvdhvO30WRFReiZFwNJgi2QslffyiNqzv4KzngA2QB/uw+P1 wxdQ== X-Gm-Message-State: AOAM530UiMM5TNWwahzgVQlti/G519bdofCuVsCByrXaZ9Ovu5FrAWrw DRm5NT0+JtvT7YtN45NNQRc= X-Google-Smtp-Source: ABdhPJyYUvpgUCAhGyBdNw1j0oD/lFY+5UPxawhwfYC652pWEs7ATpP2r3YFMgr7x+jZXnFfQkL/0A== X-Received: by 2002:a17:902:d34a:: with SMTP id l10mr12308013plk.190.1595098435372; Sat, 18 Jul 2020 11:53:55 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id j8sm11572930pfd.145.2020.07.18.11.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jul 2020 11:53:54 -0700 (PDT) Subject: Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops To: kernel test robot , netdev@vger.kernel.org Cc: kbuild-all@lists.01.org, Andrew Lunn , Vivien Didelot , Jakub Kicinski , Jiri Pirko , Eric Dumazet , Taehee Yoo , Cong Wang , Maxim Mikityanskiy References: <20200718030533.171556-3-f.fainelli@gmail.com> <202007181226.RGMXcERR%lkp@intel.com> From: Florian Fainelli Message-ID: Date: Sat, 18 Jul 2020 11:53:52 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202007181226.RGMXcERR%lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/17/2020 9:53 PM, kernel test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dcc82bb0727c08f93a91fa7532b950bafa2598f2 > config: i386-allyesconfig (attached as .config) > compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 > reproduce (this is a W=1 build): > # save the attached .config to linux build tree > make W=1 ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > In file included from drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:18: >>> include/net/dsa.h:720:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] > 720 | dsa_build_ndo_op(ndo_do_ioctl, struct ifreq *, ifr, int, cmd); > | ^~~~~~~~~~~~~~~~ > include/net/dsa.h:721:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration] > 721 | dsa_build_ndo_op(ndo_get_phys_port_name, char *, name, size_t, len); > | ^~~~~~~~~~~~~~~~ > > vim +/inline +720 include/net/dsa.h This is a macro invocation, not function declaration so I am not exactly sure why this is a problem here? I could capitalize the macro name if that avoids the compiler thinking this is a function declaration or move out the static inline away from the macro invocation. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7780503093095441664==" MIME-Version: 1.0 From: Florian Fainelli To: kbuild-all@lists.01.org Subject: Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops Date: Sat, 18 Jul 2020 11:53:52 -0700 Message-ID: In-Reply-To: <202007181226.RGMXcERR%lkp@intel.com> List-Id: --===============7780503093095441664== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 7/17/2020 9:53 PM, kernel test robot wrote: > Hi Florian, > = > I love your patch! Perhaps something to improve: > = > [auto build test WARNING on net-next/master] > = > url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa= -Setup-dsa_netdev_ops/20200718-110931 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.gi= t dcc82bb0727c08f93a91fa7532b950bafa2598f2 > config: i386-allyesconfig (attached as .config) > compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 > reproduce (this is a W=3D1 build): > # save the attached .config to linux build tree > make W=3D1 ARCH=3Di386 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > In file included from drivers/net/ethernet/stmicro/stmmac/dwmac1000_co= re.c:18: >>> include/net/dsa.h:720:1: warning: 'inline' is not at beginning of decla= ration [-Wold-style-declaration] > 720 | dsa_build_ndo_op(ndo_do_ioctl, struct ifreq *, ifr, int, cmd); > | ^~~~~~~~~~~~~~~~ > include/net/dsa.h:721:1: warning: 'inline' is not at beginning of decl= aration [-Wold-style-declaration] > 721 | dsa_build_ndo_op(ndo_get_phys_port_name, char *, name, size_t,= len); > | ^~~~~~~~~~~~~~~~ > = > vim +/inline +720 include/net/dsa.h This is a macro invocation, not function declaration so I am not exactly sure why this is a problem here? I could capitalize the macro name if that avoids the compiler thinking this is a function declaration or move out the static inline away from the macro invocation. -- = Florian --===============7780503093095441664==--