From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdDCRI2 (ORCPT ); Mon, 3 Apr 2017 13:08:28 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:46522 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdDCRI0 (ORCPT ); Mon, 3 Apr 2017 13:08:26 -0400 Subject: Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller To: Rob Herring , Gregory CLEMENT References: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> CC: Ulf Hansson , Adrian Hunter , , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , , Mike Turquette , Stephen Boyd , , , , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin From: Hu Ziji Message-ID: Date: Tue, 4 Apr 2017 01:07:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-03_14:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704030152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >> Signed-off-by: Hu Ziji >> Signed-off-by: Gregory CLEMENT >> --- >> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt | 170 +++++++- >> 1 file changed, 170 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > > I acked v6 and it seems like a minor change, though I had to search for > both because there is no revision history nor explanation why you didn't > add my ack. > Sorry for missing your ACK. I add a few but important comments on common Xenon power implementations in the examples. It is recorded in the cover letter. v6->v7: - Add comments on vqmmc and vmmc in examples in dt binding doc. I was a little unsure if we can still add your ACK after adding the comment. We will add your ACK back if we have to release another version later. Thank you. Best regards, Hu Ziji > Acked-by: Rob Herring > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hu Ziji Subject: Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller Date: Tue, 4 Apr 2017 01:07:26 +0800 Message-ID: References: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring , Gregory CLEMENT Cc: Jimmy Xu , Andrew Lunn , Ulf Hansson , linux-mmc@vger.kernel.org, Mike Turquette , linux-kernel@vger.kernel.org, Nadav Haklai , Victor Gu , Doug Jones , linux-clk@vger.kernel.org, Jisheng Zhang , Yehuda Yitschak , Marcin Wojtas , Kostya Porotchkin , Hanna Hawa , Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Ryan Gao , "Wei(SOCP) Liu" , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Stephen Boyd , Adrian Hunter , Wilson Ding List-Id: devicetree@vger.kernel.org Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >> Signed-off-by: Hu Ziji >> Signed-off-by: Gregory CLEMENT >> --- >> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt | 170 +++++++- >> 1 file changed, 170 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > > I acked v6 and it seems like a minor change, though I had to search for > both because there is no revision history nor explanation why you didn't > add my ack. > Sorry for missing your ACK. I add a few but important comments on common Xenon power implementations in the examples. It is recorded in the cover letter. v6->v7: - Add comments on vqmmc and vmmc in examples in dt binding doc. I was a little unsure if we can still add your ACK after adding the comment. We will add your ACK back if we have to release another version later. Thank you. Best regards, Hu Ziji > Acked-by: Rob Herring > From mboxrd@z Thu Jan 1 00:00:00 1970 From: huziji@marvell.com (Hu Ziji) Date: Tue, 4 Apr 2017 01:07:26 +0800 Subject: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller In-Reply-To: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> References: <20170403161926.wfj7foddu33gxuae@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xenon-specific properties. >> Also add properties for Xenon PHY setting. >> >> Signed-off-by: Hu Ziji >> Signed-off-by: Gregory CLEMENT >> --- >> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt | 170 +++++++- >> 1 file changed, 170 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > > I acked v6 and it seems like a minor change, though I had to search for > both because there is no revision history nor explanation why you didn't > add my ack. > Sorry for missing your ACK. I add a few but important comments on common Xenon power implementations in the examples. It is recorded in the cover letter. v6->v7: - Add comments on vqmmc and vmmc in examples in dt binding doc. I was a little unsure if we can still add your ACK after adding the comment. We will add your ACK back if we have to release another version later. Thank you. Best regards, Hu Ziji > Acked-by: Rob Herring >