From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDEFC636CA for ; Mon, 19 Jul 2021 02:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B230261168 for ; Mon, 19 Jul 2021 02:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233964AbhGSCXf (ORCPT ); Sun, 18 Jul 2021 22:23:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233713AbhGSCXe (ORCPT ); Sun, 18 Jul 2021 22:23:34 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C66DC061762 for ; Sun, 18 Jul 2021 19:20:36 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id w194so19058406oie.5 for ; Sun, 18 Jul 2021 19:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EsGNcxhUNDjpw3jd2PBLWZrFBrLemsllXRQ5T8XmNN4=; b=i/+5sh9nbghabMKPFon1cWSeCuZG+3hzirZxIEbeq1aVY1aSNB5SD/64V/P2ljBLGj 0TH9h9ViC9rx7AtbR6Qm6zLtvezcyoObd3p78GjXf9qjNBEhGhQUXPPccJhqqQhfmMF0 Jwn9N0TciYjAkDCYLaUcqZBplJ2qImSZw/AAzASnYHSf0/J6PgO83rWzKlK6YsRP+w6t cpXI0KrJ9WGHHSDfelz0EEaQ27mPxsBBE7T/HDHHwiUrBN1QacUTEBrH8YbGEmYJCREw C12qyBEEbRl6jPth9ZX2gFrxRXqgSonPBxkFsfaI9fbQx4ePhtX6GjTqQpayA9JC7uP/ g2AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EsGNcxhUNDjpw3jd2PBLWZrFBrLemsllXRQ5T8XmNN4=; b=Y2zH6qxABh7TpTtLUGo6m5GQYqAya/bHD0cfVg28SUH8PBF6UrdF+ev+vCozklBGqL B5HOhGoDBHJeeXiFGzwOQ6T6ttJh67Wc3qtkMQ0leldbiWwlA58P5ll8lEKyGaO8PZVX ZlMoxXwcK6FYy+9Yn9E4Cvze2bO2OzRiqf8Pdz7io+pBDHo6awhgR0XeMQQKI4lT4Pe1 xh22YSeM8Bi8PTp72AZIxIqUGt5Dr+dFnHUJ4nGVJgH7ciPZ9Ad4eHClh9bPG8tREybD yG0eBrHcF94W7vsu06jTEHwKDo6+ZAX4fYcbrPokbnfn5xsgdB7p4TpAcx5RHl8MruZG scMQ== X-Gm-Message-State: AOAM532q7wklFmoPm56Trvfpl2g02EjfA+OUebqOoP13Ax7HMUNs4UHd tHOTvJso6Ie73uG56mOrmqY= X-Google-Smtp-Source: ABdhPJyNFO+4UoyqeKBQQXE1MSOxEiWK5bPw/Goz3ersRXBweXP/wHIYqtXpsjs8PILbS4QZhtbBxw== X-Received: by 2002:aca:4f57:: with SMTP id d84mr16412279oib.71.1626661235474; Sun, 18 Jul 2021 19:20:35 -0700 (PDT) Received: from ?IPv6:2600:1700:dfe0:49f0:49e1:751f:b992:b4f3? ([2600:1700:dfe0:49f0:49e1:751f:b992:b4f3]) by smtp.gmail.com with ESMTPSA id k67sm3601668oia.8.2021.07.18.19.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jul 2021 19:20:35 -0700 (PDT) Subject: Re: [PATCH v4 net-next 05/15] net: marvell: prestera: refactor prechangeupper sanity checks To: Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Jiri Pirko , Ido Schimmel , Tobias Waldekranz , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger , bridge@lists.linux-foundation.org, Grygorii Strashko , Marek Behun , DENG Qingfang , Vadym Kochan , Taras Chornyi References: <20210718214434.3938850-1-vladimir.oltean@nxp.com> <20210718214434.3938850-6-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: Date: Sun, 18 Jul 2021 19:20:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210718214434.3938850-6-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/18/2021 2:44 PM, Vladimir Oltean wrote: > In preparation of adding more code to the NETDEV_PRECHANGEUPPER handler, > move the existing sanity checks into a dedicated function. > > Cc: Vadym Kochan > Cc: Taras Chornyi > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EsGNcxhUNDjpw3jd2PBLWZrFBrLemsllXRQ5T8XmNN4=; b=i/+5sh9nbghabMKPFon1cWSeCuZG+3hzirZxIEbeq1aVY1aSNB5SD/64V/P2ljBLGj 0TH9h9ViC9rx7AtbR6Qm6zLtvezcyoObd3p78GjXf9qjNBEhGhQUXPPccJhqqQhfmMF0 Jwn9N0TciYjAkDCYLaUcqZBplJ2qImSZw/AAzASnYHSf0/J6PgO83rWzKlK6YsRP+w6t cpXI0KrJ9WGHHSDfelz0EEaQ27mPxsBBE7T/HDHHwiUrBN1QacUTEBrH8YbGEmYJCREw C12qyBEEbRl6jPth9ZX2gFrxRXqgSonPBxkFsfaI9fbQx4ePhtX6GjTqQpayA9JC7uP/ g2AA== References: <20210718214434.3938850-1-vladimir.oltean@nxp.com> <20210718214434.3938850-6-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: Date: Sun, 18 Jul 2021 19:20:34 -0700 MIME-Version: 1.0 In-Reply-To: <20210718214434.3938850-6-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v4 net-next 05/15] net: marvell: prestera: refactor prechangeupper sanity checks List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Grygorii Strashko , Jiri Pirko , DENG Qingfang , Vadym Kochan , bridge@lists.linux-foundation.org, Ido Schimmel , Nikolay Aleksandrov , Roopa Prabhu , Marek Behun , Taras Chornyi , Vivien Didelot , Tobias Waldekranz On 7/18/2021 2:44 PM, Vladimir Oltean wrote: > In preparation of adding more code to the NETDEV_PRECHANGEUPPER handler, > move the existing sanity checks into a dedicated function. > > Cc: Vadym Kochan > Cc: Taras Chornyi > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian