From: Guenter Roeck <linux@roeck-us.net>
To: Frank Rowand <frowand.list@gmail.com>, Rob Herring <robh+dt@kernel.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] of: unittest: overlay: ensure proper alignment of copied FDT
Date: Thu, 8 Apr 2021 13:22:02 -0700 [thread overview]
Message-ID: <df760aa2-6446-f8b2-b0a4-0102a5ac138d@roeck-us.net> (raw)
In-Reply-To: <baee7388-5183-cf98-2cf4-52cf338a0cbb@gmail.com>
On 4/8/21 1:06 PM, Frank Rowand wrote:
>>> +#define FDT_ALIGN_SIZE 8
>>> +
>>
>> Use existing define ? Or was that local in libfdt ?
>
> I don't see a define in libfdt. If anyone finds one,
> I'll switch to it.
>
Turns out that was hardcoded in scripts/dtc/libfdt/fdt.c
+ /* The device tree must be at an 8-byte aligned address */
+ if ((uintptr_t)fdt & 7)
+ return -FDT_ERR_ALIGNMENT;
+
Guenter
next prev parent reply other threads:[~2021-04-08 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 15:17 [PATCH v3 1/1] of: unittest: overlay: ensure proper alignment of copied FDT frowand.list
2021-04-08 15:32 ` Guenter Roeck
2021-04-08 20:06 ` Frank Rowand
2021-04-08 20:22 ` Guenter Roeck [this message]
2021-04-08 18:27 ` Rob Herring
2021-04-08 20:20 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df760aa2-6446-f8b2-b0a4-0102a5ac138d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.