All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ruien Zhang <zhangruien@bytedance.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: peter.maydell@linaro.org, berrange@redhat.com,
	richard.henderson@linaro.org, qemu-devel@nongnu.org,
	pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH 0/2] Introduce printer subsystem and USB printer device
Date: Fri, 14 Jan 2022 21:38:30 +0800	[thread overview]
Message-ID: <df772eaf-b042-d44d-392d-5f9204b3f5b2@bytedance.com> (raw)
In-Reply-To: <20220114093216.aqrh6h3ukzavtasq@sirius.home.kraxel.org>

On 1/14/22 5:32 PM, Gerd Hoffmann wrote:
>    Hi,
> 
>> This patchset introduces:
>>
>> 1) Skeleton of QEMU printer subsystem with a dummy builtin driver.
>>
>> 2) USB printer device emulation, with definitions in the extension of IPP-over-
>>     USB [3].
>>
>> WIP:
>>
>> 1) QEMU printer subsystem interfaces, which will be finalized with a concrete
>>     backend driver.
>>
>> 2) IPP-over-USB implementation.
> 
> Hmm, I'm wondering what uses cases you have in mind and whenever
> it makes sense to introduce a printer subsystem?
> 

Simply for the "potential" backend diversity. I have to admit that I 
haven't figured out another backend which would be commonly-seen either, 
which is also one part of the reason why the interfaces are not firming 
up right now.

> Having an ipp-over-usb device looks useful, but the only use case I can
> see is to allow guests access a network printer.  I can't see the
> benefits of a printer subsystem, especially in a world where non-ipp
> printers are going extinct.  We would most likely have just a single
> kind of printer backend, where the only job qemu will have is to
> forwarding requests and replies, maybe with some http header rewriting.
> 
> Likewise usb would be the one and only device (parallel ports are long
> gone in printers).  So the indirection added by a printer subsystem
> doesn't buy us anything because we just don't need that flexibility.
> I'd suggest to pass the url directly to the device instead:
> 
> qemu -device usb-ipp-printer,url=ipp://hostname/ipp/printer
> 
> take care,
>    Gerd
> 

Indeed, the subsystem is an over-abstraction. The forwarding way is much 
neater, considering how things really work nowadays.

Anyway, thanks for the practical suggestion, it will be revised, along 
with other designs around the path I'm currently working on.

Regards,
Ruien




  reply	other threads:[~2022-01-14 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 11:56 [PATCH 0/2] Introduce printer subsystem and USB printer device Ruien Zhang
2022-01-13 11:56 ` [PATCH 1/2] printer: Introduce printer subsystem Ruien Zhang
2022-01-13 11:56 ` [PATCH 2/2] usb-printer: Introduce USB printer class Ruien Zhang
2022-01-14  9:32 ` [PATCH 0/2] Introduce printer subsystem and USB printer device Gerd Hoffmann
2022-01-14 13:38   ` Ruien Zhang [this message]
2022-01-15 15:31   ` Ruien Zhang
2022-01-17  7:17     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df772eaf-b042-d44d-392d-5f9204b3f5b2@bytedance.com \
    --to=zhangruien@bytedance.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.