From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573E0C4338F for ; Sat, 31 Jul 2021 07:45:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7940B60EE6 for ; Sat, 31 Jul 2021 07:45:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7940B60EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC5A68325B; Sat, 31 Jul 2021 09:45:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1627717547; bh=cwfj7xXLCm71dcH+2LQogZYuZImSqrFvyT/PsG0DZb8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F6yXxbQjH0kzhc0ziTV/NabbtbTc78Lif5ShFCy1HtSwg8ukFsWMYcCeWUVwt3/Zj 0PqtW5+e0AbepvawtjAHE21C+P9KJRoXLjyF5fyp96XiDIpIA4v+QFAu46xOf1jXfw oUPXd1tV3x9ZjoYVzyemnyC3xtbPZ5Lz5AeqowmAbQQmsrhRsfKbpaBt4KcKamgAHc SYTQcp+HUoUaXckJACy4k1d7sjOEb2ZjfyLJurTcPwGKqBQ9oI4S3/a4TDGt9tl0aQ creq5Fj0p7gmGxh16kyGIXtcdfmrj93N5DfeUOOexrjAxVcZ2b0JjwrC+0mlYw7SU3 iPBVO4UmFAqoQ== Received: by phobos.denx.de (Postfix, from userid 109) id 2228C8325E; Sat, 31 Jul 2021 09:45:45 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1876F83253 for ; Sat, 31 Jul 2021 09:45:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4GcGXQ010kzQk31; Sat, 31 Jul 2021 09:45:42 +0200 (CEST) Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id E-OwlcCJgvPL; Sat, 31 Jul 2021 09:45:39 +0200 (CEST) Subject: Re: [PATCH 1/2] serial: a37xx: Use CONFIG_BAUDRATE for initializing early debug UART To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Konstantin Porotchkin , =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20210726125859.5588-1-pali@kernel.org> From: Stefan Roese Message-ID: Date: Sat, 31 Jul 2021 09:45:38 +0200 MIME-Version: 1.0 In-Reply-To: <20210726125859.5588-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 08F731898 X-Rspamd-UID: c7346c X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 26.07.21 14:58, Pali Rohár wrote: > CONFIG_BAUDRATE should be used for setting the baudrate for the early debug > UART. This replaces current hardcoded 115200 value. > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/serial/serial_mvebu_a3700.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/serial/serial_mvebu_a3700.c b/drivers/serial/serial_mvebu_a3700.c > index c7e66fef8768..52dc3fdad7b4 100644 > --- a/drivers/serial/serial_mvebu_a3700.c > +++ b/drivers/serial/serial_mvebu_a3700.c > @@ -309,7 +309,7 @@ U_BOOT_DRIVER(serial_mvebu) = { > static inline void _debug_uart_init(void) > { > void __iomem *base = (void __iomem *)CONFIG_DEBUG_UART_BASE; > - u32 baudrate, parent_rate, divider; > + u32 parent_rate, divider; > > /* reset FIFOs */ > writel(UART_CTRL_RXFIFO_RESET | UART_CTRL_TXFIFO_RESET, > @@ -322,9 +322,8 @@ static inline void _debug_uart_init(void) > * Calculate divider > * baudrate = clock / 16 / divider > */ > - baudrate = 115200; > parent_rate = get_ref_clk() * 1000000; > - divider = DIV_ROUND_CLOSEST(parent_rate, baudrate * 16); > + divider = DIV_ROUND_CLOSEST(parent_rate, CONFIG_BAUDRATE * 16); > writel(divider, base + UART_BAUD_REG); > > /* > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de