From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C23C433B4 for ; Thu, 22 Apr 2021 06:31:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D25566144D for ; Thu, 22 Apr 2021 06:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234823AbhDVGcS (ORCPT ); Thu, 22 Apr 2021 02:32:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:43868 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbhDVGcR (ORCPT ); Thu, 22 Apr 2021 02:32:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AA872B008; Thu, 22 Apr 2021 06:31:42 +0000 (UTC) Subject: Re: [PATCH 07/42] scsi: Kill DRIVER_SENSE To: Bart Van Assche , "Martin K. Petersen" Cc: Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org References: <20210421174749.11221-1-hare@suse.de> <20210421174749.11221-8-hare@suse.de> From: Hannes Reinecke Message-ID: Date: Thu, 22 Apr 2021 08:31:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 4/21/21 11:06 PM, Bart Van Assche wrote: > On 4/21/21 10:47 AM, Hannes Reinecke wrote: >> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c >> b/drivers/scsi/megaraid/megaraid_mbox.c >> index 6a5b844a8499..2b6138a7c71f 100644 >> --- a/drivers/scsi/megaraid/megaraid_mbox.c >> +++ b/drivers/scsi/megaraid/megaraid_mbox.c >> @@ -2299,8 +2299,7 @@ megaraid_mbox_dpc(unsigned long devp) >>                   memcpy(scp->sense_buffer, pthru->reqsensearea, >>                           14); >> -                scp->result = DRIVER_SENSE << 24 | >> -                    DID_OK << 16 | CHECK_CONDITION << 1; >> +                scp->result = DID_OK << 16 | SAM_STAT_CHECK_CONDITION; >>               } >>               else { >>                   if (mbox->cmd == MBOXCMD_EXTPTHRU) { >> @@ -2308,9 +2307,8 @@ megaraid_mbox_dpc(unsigned long devp) >>                       memcpy(scp->sense_buffer, >>                           epthru->reqsensearea, 14); >> -                    scp->result = DRIVER_SENSE << 24 | >> -                        DID_OK << 16 | >> -                        CHECK_CONDITION << 1; >> +                    scp->result = DID_OK << 16 | >> +                        SAM_STAT_CHECK_CONDITION; >>                   } else >>                       scsi_build_sense(scp, 0, >>                                ABORTED_COMMAND, 0, 0); > > Since DID_OK == 0 I prefer to leave out the 'DID_OK << 16' expressions > from code that is modified. > Okay, will do. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer