From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762086AbcINLST (ORCPT ); Wed, 14 Sep 2016 07:18:19 -0400 Received: from mail-db5eur01on0106.outbound.protection.outlook.com ([104.47.2.106]:3136 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761448AbcINLSM (ORCPT ); Wed, 14 Sep 2016 07:18:12 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [patch v5] i2c: mux: mellanox: add driver To: Vadim Pasternak , "wsa@the-dreams.de" References: <1473799071-12830-1-git-send-email-vadimp@mellanox.com> CC: "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jiri@resnulli.us" , Michael Shych From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Wed, 14 Sep 2016 10:42:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: AM4PR0902CA0004.eurprd09.prod.outlook.com (10.171.89.14) To DB6PR0201MB2312.eurprd02.prod.outlook.com (10.169.222.151) X-MS-Office365-Filtering-Correlation-Id: 624db6fe-60c2-4b20-884d-08d3dc7b21e4 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;2:w43T8N1lFBG+zPOKhGiX265pQJlmOQvJ2z8bdBITGis1593zRFcWuykA6BrBkvpTKTEmbv+JmN3OZOCUYfCdxnzuB2pZwGH7cx0nCKCGWrAtEmHF6gdYaspB+63IM9sLP21qGzXrEHUB/tHzp59PjP+zUM/lx2IcqhRrVd3GKiHIxeTL/1wWFyw0HGyKgrir;3:4gsXGQA68ALU6mYzU0uKKgrETE2TKTxti4vfNcVNZm9WF6rslJqlwazZnGkxUQTJC+/Lxpkg/wNoHonC+TcoFlCZ0zV1mS2aw/9BkWy4thf1hUa2HF6D4Qf6zmZjZYN7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2312; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;25:mJsXP3VIXpjcRJ2D9MWiDSuSXL1Bonb31EnHRZFpD1D6lqyDuxSq2MxD5PkDVRLdsyzl2qxVNu62T0r1wsRYMwfE39gTS3rlKCqB1M1NYyiEL0khXazaXOLtZrW1AbXxeGsdVn6DuTJmUl4Gjjiff2sBwdjdsrd5ergg0YJ/IpE77A+fwcu/KmlJ0cITTt0Xg/dSfLxqz8QB3idZj2PHFW6UYfQaG838S8QYVd7V/U+aKqkijaROSP2bYyTFSlcc7kILvAS2tFTQOBrrZDRQDHT9BebeC4ssL7Ug3Kg+4U4PsxdWdDPaUz625L0HtdqGHizXHqblDON/97sl7IwWNgcoxVoGrd7zsJ/VunzkfX/+pkT5eGJYUNm3xJC8d9h+kHbEuCOFUBEmiaBqy7FpHtz1Bv0e/b5WCgFblE/8pwakfvo6khi8uxHH+019ax7xlyaJZAB+ii/bSS7M+e+fbmrkcUbZLf6zum/tstsTmWay0yFbGzLPY96zG96O03wxj+sF+zCQkvXQgCoL//I6o9JWGh59qtiIDMEvdd+t4R45HsUlAFjurdcmLv3tiWKdilHJpYFEXOB6nR4uwf66OTN89EkLkHbTxsxhekUfPfVfOqMNseQPHU5DAC5zbOrCDjbekZPbbJC+v7EU6QSy3dHWaNN4ZY+m0TZHsJbPWetxpvB5Hs7p9W1zVWEo+ht79P8K3n7gaJ7jIbYQAXg/3A==;31:WeDfChySQGYKC3HyqPkuRMf9iO5pd76Zn4sioiK3yL8kROwlgxOHfw3JDQ0yTRImmukMypUlO1d7N8KOBFD+N6TLVT5Ri3qBL/xPTj9in3xavKCr12ti8Ab0m+J2v61Qr6auD5BNAdmBYJnbLktlgCCg9DETk5CJmjwyDB6KDRDKYrEYxt7n/1kEPv9TnSgkgFw7zD5A+21trYqBbQokuFg5tp3eemQxANw6o9g3xHw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6043046)(6042046);SRVR:DB6PR0201MB2312;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2312; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;4:NkSiyc52Y6RJ4A8AQRprg1ISJBql2j4eR65wb1MzSPhXhe2sTt9HyyZL/csHZ0IBOJUVymgHobIn1xILXQIHjAGWFrTwVtIYSXoCg+Wkwe7GhPIdlK4BYZnd8te1IcPLz3y1hjKK2F/qM/AikJ3fEn+aC26fhObqCHMYD8VjQO4GgM4MSgMjulRQ96r/9jvv3VMqKc7wSiqVi4VhS1jJT/j0gN6r5AmTzoJlNJv0P45eY+WTaPDfjrVcyjOWpjaXe5w7hsEmkkucsDjrSJiLwobKm+8hnxwAXfC21n7Yxs2q5DIglPzKx6FQ0eTaCQELGCN56Q/OhelaNvAEBl8v2uzKhfW6qzs1fHgx9ofKoV3uAXX5K/cV9ip/tMn+IivEYSOjJyujjT623qyzL30IzFXU45Ed2y7SnllpKKrqHUw= X-Forefront-PRVS: 006546F32A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377424004)(24454002)(199003)(189002)(117156001)(64126003)(81166006)(81156014)(305945005)(5001770100001)(230700001)(54356999)(50986999)(76176999)(3846002)(86362001)(5660300001)(2906002)(36756003)(47776003)(31696002)(101416001)(6116002)(66066001)(65826007)(65956001)(65806001)(2501003)(50466002)(106356001)(586003)(7736002)(42186005)(4326007)(77096005)(68736007)(8676002)(105586002)(23746002)(7846002)(31686004)(33646002)(19580395003)(92566002)(74482002)(19580405001)(97736004)(4001350100001)(83506001)(2950100001)(189998001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0201MB2312;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0201MB2312;23:WrN4ABMiuwNd7u8K7mzcllKhLnfYrJYvOL5?= =?Windows-1252?Q?kucGuPSKdXROFVLeFNq995aJdauz8bajR1LnTW7NPUYJO6TWxd7qG7Zz?= =?Windows-1252?Q?xrjHagfTjfe4v7UUNF0jVcerz0dzPrtxFvUbJTm6BI1xaEgLhKYZ+2g0?= =?Windows-1252?Q?cCEYyFp26ggml9UB3jfwcDprakoW9IKz9ZJhj+bQHHyb3vLpwgtvywRC?= =?Windows-1252?Q?Km/JuvJGldJjHO1faUy5Vt8R1CB9AkJpuVvVngKW8zptFrlXLJOKc1Ki?= =?Windows-1252?Q?Mlnsd4EsGasNjtv2hwjQA3BeOGDr9RbfxxeSM1OGWH7CQmPXuLTkSHdR?= =?Windows-1252?Q?17Ifwu+lmm8JlACldhkbHuk/HhfgtqEp1TQxlN0N8B/+YZknYnMPiEHB?= =?Windows-1252?Q?FrDAGyExNPP2yGpa6jdhP806L2rsLNzVGI+DsBhpQouF9kQ0Z2g4nqYy?= =?Windows-1252?Q?VSuGAqSjg/N0DFQHQNSsgsbnN2zJm+HCioXKJU3FaIFfX5IMPORySYNW?= =?Windows-1252?Q?nGks8F+qGwiIMSNPnExRev3FEkAjfGbeibbz8ePAUhT1D/P5ueGCnwxx?= =?Windows-1252?Q?3EuIp3nUIaR7Gnb0ZUdO0StkVIcBp/NEA/rw8C1W5z+jHIwp5xL+ATbO?= =?Windows-1252?Q?w4T9D8onV/WqLEfJkMjcPPgJ2lJcnuWpdfM6XYlYRbXdeyNiqZTXuggE?= =?Windows-1252?Q?B4tdjftdoEan2+S2KptG2V66E1AhMgQzTJRPONJJBlpP1tfMPwwUjaLY?= =?Windows-1252?Q?lWHspsbtj8KvIWGiKCqzMmLty7dxDyr5Ja6vLU5l7sAmKx22jQGYE3Tt?= =?Windows-1252?Q?Rv7hYYxf212kILYb7ce+urBbg5sowetI9lx3gJJ6J90v99Bam2/BHyOC?= =?Windows-1252?Q?+pKDYndmkYEkNIMa1Gf1Q/jwB82OZ8xWqidmL7xpWPdUOFGYNY6ndOOp?= =?Windows-1252?Q?S+/cVvZRqlIEf8/NjTpduHvVLJ2XMfGJjPfrLswu/aAYpbij9IW8aipb?= =?Windows-1252?Q?Zjs09U1/lcaylZY32XOpu0J8JnmLIbfg5kq13JJAkxbjHewJ9IbfwqS9?= =?Windows-1252?Q?8xv4+Mj1wTG7qhl0cJc3y0T8YZukBlv/Tg54kx1R1WYlcq5YqNAMcORL?= =?Windows-1252?Q?pXFFqjhbi0SbMKS0Yk2HlmRRy6PCVU/MvYJDmZqwJ3My5p3vokcRlitd?= =?Windows-1252?Q?m2i50tCWWfdSOPDClfaDvgBX35G2qKiC5wMPaGFRf3A9oLbwsMt4ggSN?= =?Windows-1252?Q?4eZO5e30OHLirfuCjxYzBarYb8b3DGSJX9zYVkQGtb787nvrgq6oTFud?= =?Windows-1252?Q?66rd1MKTFHDYyv7c67u35x7UPmdj777WtwseS+wL5lfXtQVgZoci/rdL?= =?Windows-1252?Q?8PS/fqTi7aiqFzg4EVBRcrnlF03Abn9EOiaT9W3M3xpNq48X1l/gzrCz?= =?Windows-1252?Q?F2JDxR6CyAkyOCxOaBD5UpCbVG1bCf8Ny0TDbzG7jQg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;6:WURm00Qqyc/MtOthNB0rGtzT8SGiP4GM49rzzfUv+DNs8jfgRv+NwA4BQ5qD2hwBOIA1PLvQslYyoyNk8o5tTb6NRcRp760dHo+FdgQdOJDZITLO6O90H2tkND9f2SyZZOWxx0TECeDUOTpjwUSMs880TRXihK4EUfzf5uY+OyhtoXiBbuys2VlmXH9c5YebtwQiCjwki20xAOcDSOlxPhiUgv7miCO92MFWS6mTrtT+TroJeyaqfxQu4/Qdwapn4TMgUSGpngBJFuTKLF2S3o6vJLXT10xX/MtL1lpUUgeyHq+KdA6ihsyqOcdwYv4V;5:YSn6jTsLEViVirwpg03u4Vif0CeEFWnBQhnV3S+cNxQnEdhuSev7uHxNKQ7memJ1mm40HI8+RAiYexjHYS2v6zNoKiOv+ZUWaOh6odRCM4s/i5Ir/i1+f5im26jY3/dqY+/VsOdxKPVir/kBAWdFfw==;24:ZZY/r+Jl/lGhxaWHkBk1jwn8x3PASn83h8yo3JUlxIOHF3w6MBaK5i3Ab9J56I765temrtDg0iZD3mDdFu4c90cYj0tbMMW0e1agK9V1LdQ=;7:NB9dZjiS7h82HGO/OtNcLBdJ0pSHkvyUwxO0W39BSQ02XsF2HitxSdFSxruZzl+xhpHK1zbpwBoIUNzCjeZ6dVNZuHzQQWVzuLeWF8IX/C1fRujiuNr2lZNw5PuvLlviKLhrbAJ0Lx4bhuFz7HcrWeSVpN8yFOPcgjDyXZu6buUR3uJJLkdpg0gyahkeE+R/89ICKNC4IFfhr4ZBLlpm0UkC9+FI8y9rq9gPNH/1ZC4hVpFp2amSldyU6ZiD+VGr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2016 08:42:58.9949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram, please pick up v5 for i2c-next whenever timing is right so that it gets more testing etc. I didn't do any recent compile-testing myself, but if you think that is required on the final version I can of course spend some time on it. (But isn't that what all the infrastructure is there to help with?) Thanks! On 2016-09-14 10:10, Vadim Pasternak wrote: > Peter Rosin wrote: >> On 2016-09-13 22:37, vadimp@mellanox.com wrote: >>> From: Vadim Pasternak >>> >>> This driver allows I2C routing controlled through CPLD select >>> registers on a wide range of Mellanox systems (CPLD Lattice device). >>> MUX selection is provided by digital and analog HW. Analog part is not >>> under SW control. >>> Digital part is under CPLD control (channel selection/de-selection). >> >> *snip* >> >>> +/* Platform data for the CPLD I2C multiplexers */ >>> + >>> +/* mlxcpld_mux_plat_data - per mux data, used with >>> +i2c_register_board_info >>> + * @adap_ids - adapter array >>> + * @num_adaps - number of adapters >>> + * @sel_reg_addr - mux select register offset in CPLD space */ >>> +struct mlxcpld_mux_plat_data { >>> + int *adap_ids; >>> + int num_adaps; >>> + int sel_reg_addr; >>> +}; >>> + >>> +#endif /* _LINUX_I2C_MLXCPLD_H */ >>> >> >> Hmm, you never confirmed that you need to support different register values in >> the CPLD with sel_reg_addr. I can see that there is a possibility that you actually >> really need it, but I'd like to remove that variable if at all possible. > > Yes, it could be different register values. > Actually CPLD can also be programmed in different way. > So, I really need it. Oh well :-) Cheers, Peter >> >> If you can confirm that you need that, this is >> >> Acked-by: Peter Rosin