From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7AEC04A95 for ; Wed, 28 Sep 2022 17:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234670AbiI1Ruk (ORCPT ); Wed, 28 Sep 2022 13:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234078AbiI1Rui (ORCPT ); Wed, 28 Sep 2022 13:50:38 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74D683F32D for ; Wed, 28 Sep 2022 10:50:36 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id z4so3699036lft.2 for ; Wed, 28 Sep 2022 10:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=szYRUNTBzhtYD1dEwWP+61BLschhE4HnOh0yg58NYWc=; b=mC7G9bQo9HU0f6epli3GndKdWBSE8mKRNHsJbfkCwBZ7Ul8WpsecgIkm8+ZNy2E/dR 0HrdfJS1VZjm0/7ynVDeqMsQDJoQ0ZAurec+DhV40EWxROgQOG8HPTt0UiF2d9aKQ0BM RwsL+gAlJ2kLN4JFQeKYkymK3z6xGwiVXeqOR84hVPaDIndoofLqwt3rOjJSl8pvKcJD 1LdIdHyU9WzWpBu7lSWCaRpFh7TB+qx+LC+nG8sbqQ+tsDoGCqE0nfUk+up8twztsbjb hyKGsUKPSG37/aORpxP1YRncPExyozhskt2hNplrHLzoQpVJGBi4FDXYrClymntdLOCk mj+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=szYRUNTBzhtYD1dEwWP+61BLschhE4HnOh0yg58NYWc=; b=3JmFvre0Dh1VN06WJ/ntGGLXQs7yMHFUMzJsotMY7Z1ExyLMfGvqr7+Mld1nvT7mdA 2OS0h82rmAYoI+LiOblDICKCUEvbWfGFskx1Jch+xWRNEAod9blcMoYrAri7liocH4dx V4pPfUEKIhJUlBI0XC33WvgPeEY2oG5qMlZ8Gz3V4fINu0plGmOKzbHhY9GJyM/UVORE kCL1IYlR/GRgKtYWXRI49tYgb2bDEyh01/hNmcZNPw8h5Q1oCy1BtomNTTYfQSvPXcxi AVm4zmNYhRTop6hTmqphbmdFh0I6KNE36/Sql0I0rgIbMhJ03KVwPIG0lfht5AfviVnd NQCQ== X-Gm-Message-State: ACrzQf1SRV3HDPV7+I86gWiyATJDCya5SQhdZmtOEgXCTcvi9yvzJq8I DDxMDbPP+AvY1lar4qXwlMJFmw== X-Google-Smtp-Source: AMsMyM5rxIZDytENB8AHhahxxOtrIFCEJdUiYcgZbpXU+ZEkOnoiYOmcLtFg6ddHKwNiFLOfdB0k8A== X-Received: by 2002:a05:6512:1056:b0:498:efaf:5bd1 with SMTP id c22-20020a056512105600b00498efaf5bd1mr13304252lfb.64.1664387434846; Wed, 28 Sep 2022 10:50:34 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x25-20020a056512131900b00498ebd60c35sm532566lfu.165.2022.09.28.10.50.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 10:50:34 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 19:50:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 02/11] dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP Content-Language: en-US To: =?UTF-8?B?VGluZ0hhbiBTaGVuICjmsojlu7fnv7Ap?= , "robh+dt@kernel.org" , =?UTF-8?B?VGlmZmFueSBMaW4gKOael+aFp+ePiik=?= , "mchehab@kernel.org" , =?UTF-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= , "peng.fan@oss.nxp.com" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "andersson@kernel.org" , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , "mathieu.poirier@linaro.org" Cc: "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20220927025606.26673-1-tinghan.shen@mediatek.com> <20220927025606.26673-3-tinghan.shen@mediatek.com> <08abade9-f6f5-77cf-b83d-739b0b81543a@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 28/09/2022 11:17, TingHan Shen (沈廷翰) wrote: > On Wed, 2022-09-28 at 15:01 +0800, Peng Fan wrote: >> >> On 9/27/2022 10:55 AM, Tinghan Shen wrote: >>> The MT8195 SCP is a dual-core RISC-V MCU. Extend the yaml file >>> to describe the 2nd core as a subnode of the boot core. >>> >>> The configuration register is shared by MT8195 SCP core 0 >>> and core 1. The core 1 can retrieve the information of configuration >>> registers from parent node. >> >> I think the commit message would not convince people you put >> scp 1 as subnode of scp 0. >> >> Regards, >> Peng. >> > Hi Peng, > > Thanks for your review. I should give the most reasonable explanation > for why SCP 1 is a subnode. > > Adding SCP 1 as a subnode helps to assure finish probing SCP 1 > before starting SCP 0 by using of_platform_populate. It's because > that I want to probe SCP 1 as a remoteproc subdevice of SCP 0. > such that when SCP 0 crashed, SCP 0 can reboot SCP 1. As Peng noted, this is not proper description of hardware. The SCP 0/1 do not have parent-child relationship, so do not model it that way in Devicetree. Probe ordering is operating system specific, not related to bindings. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 902DCC32771 for ; Wed, 28 Sep 2022 17:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R6FyivR5fIyKIr6/5yOPC2BabYTHJfVMzgS1msnVbT0=; b=KCCbInu41oA72V XiN3Mzq7PyiNaf04r/eCiyrxMK5xJS516ojy7583YTznq54l75zXLhbKKZXShHsJyn+PrxkHL1q88 p1OIVHuqBDZ2+7Nz3WZ/Qm3ouaT/P44B21tgXbSCrR0/Hx6oGlfzabXA64v17KCrjsMhAt0PkAFDt VOIQ6N503qhuY1ydFN8UOpgtPScmAkkCBfqLR+kICBj0MXkOw2IxcQZH9013q4Ex8pvRq6Yk2/Wj4 r3x2YV3wfj1JB0477EQi4Xff3/KTyLS6AZzUnY+0WtLPlDAFYbxWIvW55Uq03DyPqPmBxHxXloZ94 ACPFFWm/gY0XFUBHp5Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odbCm-00HSQ8-78; Wed, 28 Sep 2022 17:50:44 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odbCg-00HSMu-Gu for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 17:50:40 +0000 Received: by mail-lf1-x131.google.com with SMTP id 10so21504823lfy.5 for ; Wed, 28 Sep 2022 10:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=szYRUNTBzhtYD1dEwWP+61BLschhE4HnOh0yg58NYWc=; b=mC7G9bQo9HU0f6epli3GndKdWBSE8mKRNHsJbfkCwBZ7Ul8WpsecgIkm8+ZNy2E/dR 0HrdfJS1VZjm0/7ynVDeqMsQDJoQ0ZAurec+DhV40EWxROgQOG8HPTt0UiF2d9aKQ0BM RwsL+gAlJ2kLN4JFQeKYkymK3z6xGwiVXeqOR84hVPaDIndoofLqwt3rOjJSl8pvKcJD 1LdIdHyU9WzWpBu7lSWCaRpFh7TB+qx+LC+nG8sbqQ+tsDoGCqE0nfUk+up8twztsbjb hyKGsUKPSG37/aORpxP1YRncPExyozhskt2hNplrHLzoQpVJGBi4FDXYrClymntdLOCk mj+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=szYRUNTBzhtYD1dEwWP+61BLschhE4HnOh0yg58NYWc=; b=JSxiHkqqLAY8daZfMVgRSYQhiXlA1wL9R5MIL1u32VHUCmuu3UFYf57t+2lLMcgrdO fPFU8XJqicGyguamR3o1k0px4RGzAUqdK7pW0kGsvsbnBS+D9IGJbjhXgv0vz/m+21cA 60NuGZlerK8TzENeXo34u+A2BzOKNm0LzhynbO4pmX8LwiPMJgFq+RHt5xn2Mmv57aub I2qRuOBqiCjuQqnOrJD6uukppqlM7rlHeC9HqBZCLIYoIjpA24In03IOCCHL2nZJES0d WBdn1y8FqDx5lTpeDHzJihBAeIgxpSj99/dYyy0JWnse0EEX9AswFn/4oOhxiXSL7Itn SqRw== X-Gm-Message-State: ACrzQf0bBZqT5u2Hi881gtthkDBVlcSwq7D78SF6QqmPeOjm66o5Cuwh Oxph7zQc4o2JFRUKpT+DNPMGXQ== X-Google-Smtp-Source: AMsMyM5rxIZDytENB8AHhahxxOtrIFCEJdUiYcgZbpXU+ZEkOnoiYOmcLtFg6ddHKwNiFLOfdB0k8A== X-Received: by 2002:a05:6512:1056:b0:498:efaf:5bd1 with SMTP id c22-20020a056512105600b00498efaf5bd1mr13304252lfb.64.1664387434846; Wed, 28 Sep 2022 10:50:34 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x25-20020a056512131900b00498ebd60c35sm532566lfu.165.2022.09.28.10.50.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 10:50:34 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 19:50:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 02/11] dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP Content-Language: en-US To: =?UTF-8?B?VGluZ0hhbiBTaGVuICjmsojlu7fnv7Ap?= , "robh+dt@kernel.org" , =?UTF-8?B?VGlmZmFueSBMaW4gKOael+aFp+ePiik=?= , "mchehab@kernel.org" , =?UTF-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= , "peng.fan@oss.nxp.com" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "andersson@kernel.org" , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , "mathieu.poirier@linaro.org" Cc: "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20220927025606.26673-1-tinghan.shen@mediatek.com> <20220927025606.26673-3-tinghan.shen@mediatek.com> <08abade9-f6f5-77cf-b83d-739b0b81543a@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_105038_597223_975C7145 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjgvMDkvMjAyMiAxMToxNywgVGluZ0hhbiBTaGVuICjmsojlu7fnv7ApIHdyb3RlOgo+IE9u IFdlZCwgMjAyMi0wOS0yOCBhdCAxNTowMSArMDgwMCwgUGVuZyBGYW4gd3JvdGU6Cj4+Cj4+IE9u IDkvMjcvMjAyMiAxMDo1NSBBTSwgVGluZ2hhbiBTaGVuIHdyb3RlOgo+Pj4gVGhlIE1UODE5NSBT Q1AgaXMgYSBkdWFsLWNvcmUgUklTQy1WIE1DVS4gRXh0ZW5kIHRoZSB5YW1sIGZpbGUKPj4+IHRv IGRlc2NyaWJlIHRoZSAybmQgY29yZSBhcyBhIHN1Ym5vZGUgb2YgdGhlIGJvb3QgY29yZS4KPj4+ Cj4+PiBUaGUgY29uZmlndXJhdGlvbiByZWdpc3RlciBpcyBzaGFyZWQgYnkgTVQ4MTk1IFNDUCBj b3JlIDAKPj4+IGFuZCBjb3JlIDEuIFRoZSBjb3JlIDEgY2FuIHJldHJpZXZlIHRoZSBpbmZvcm1h dGlvbiBvZiBjb25maWd1cmF0aW9uCj4+PiByZWdpc3RlcnMgZnJvbSBwYXJlbnQgbm9kZS4KPj4K Pj4gSSB0aGluayB0aGUgY29tbWl0IG1lc3NhZ2Ugd291bGQgbm90IGNvbnZpbmNlIHBlb3BsZSB5 b3UgcHV0Cj4+IHNjcCAxIGFzIHN1Ym5vZGUgb2Ygc2NwIDAuCj4+Cj4+IFJlZ2FyZHMsCj4+IFBl bmcuCj4+Cj4gSGkgUGVuZywKPiAKPiBUaGFua3MgZm9yIHlvdXIgcmV2aWV3LiBJIHNob3VsZCBn aXZlIHRoZSBtb3N0IHJlYXNvbmFibGUgZXhwbGFuYXRpb24KPiBmb3Igd2h5IFNDUCAxIGlzIGEg c3Vibm9kZS4KPiAKPiBBZGRpbmcgU0NQIDEgYXMgYSBzdWJub2RlIGhlbHBzIHRvIGFzc3VyZSBm aW5pc2ggcHJvYmluZyBTQ1AgMQo+IGJlZm9yZSBzdGFydGluZyBTQ1AgMCBieSB1c2luZyBvZl9w bGF0Zm9ybV9wb3B1bGF0ZS4gSXQncyBiZWNhdXNlCj4gdGhhdCBJIHdhbnQgdG8gcHJvYmUgU0NQ IDEgYXMgYSByZW1vdGVwcm9jIHN1YmRldmljZSBvZiBTQ1AgMC4KPiBzdWNoIHRoYXQgd2hlbiBT Q1AgMCBjcmFzaGVkLCBTQ1AgMCBjYW4gcmVib290IFNDUCAxLgoKQXMgUGVuZyBub3RlZCwgdGhp cyBpcyBub3QgcHJvcGVyIGRlc2NyaXB0aW9uIG9mIGhhcmR3YXJlLiBUaGUgU0NQIDAvMQpkbyBu b3QgaGF2ZSBwYXJlbnQtY2hpbGQgcmVsYXRpb25zaGlwLCBzbyBkbyBub3QgbW9kZWwgaXQgdGhh dCB3YXkgaW4KRGV2aWNldHJlZS4KClByb2JlIG9yZGVyaW5nIGlzIG9wZXJhdGluZyBzeXN0ZW0g c3BlY2lmaWMsIG5vdCByZWxhdGVkIHRvIGJpbmRpbmdzLgoKQmVzdCByZWdhcmRzLApLcnp5c3p0 b2YKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==