From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99E1C3F2C6 for ; Tue, 3 Mar 2020 13:49:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A230B20838 for ; Tue, 3 Mar 2020 13:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A230B20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j97v0-000333-2L; Tue, 03 Mar 2020 13:49:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j97uy-00032x-Su for xen-devel@lists.xenproject.org; Tue, 03 Mar 2020 13:49:04 +0000 X-Inumbo-ID: be65358a-5d55-11ea-8efe-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id be65358a-5d55-11ea-8efe-bc764e2007e4; Tue, 03 Mar 2020 13:49:04 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 59BB8B14B; Tue, 3 Mar 2020 13:49:03 +0000 (UTC) Message-ID: From: Dario Faggioli To: Juergen Gross , xen-devel@lists.xenproject.org Date: Tue, 03 Mar 2020 14:49:01 +0100 In-Reply-To: <20200303092733.14983-1-jgross@suse.com> References: <20200303092733.14983-1-jgross@suse.com> Organization: SUSE User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v2] xen/sched: fix error path in cpupool_unassign_cpu_start() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap Content-Type: multipart/mixed; boundary="===============8163087557368132595==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============8163087557368132595== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-4YUXJ/9jclaIlfghsppQ" --=-4YUXJ/9jclaIlfghsppQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-03-03 at 10:27 +0100, Juergen Gross wrote: > In case moving away all domains from the cpu to be removed is failing > in cpupool_unassign_cpu_start() the error path is missing to release > sched_res_rculock. >=20 > The normal exit path is releasing domlist_read_lock instead (this is > currently no problem as the reference to the specific rcu lock is not > used by rcu_read_unlock()). >=20 > While at it indent the present error label by one space. >=20 > Reported-by: Igor Druzhinin > Signed-off-by: Juergen Gross > Reviewed-by: Jan Beulich > Reviewed-by: Dario Faggioli Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-4YUXJ/9jclaIlfghsppQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl5eYE4ACgkQFkJ4iaW4 c+7tshAAmf+ma4oNWAr1gXw13CmuQapxMaZchkSwXgLvnTx+Qs/3tgbBpeTMXpxx R+VweABD8rQIgMAC5wg7Vey4WvLwEXcTepRwbMyebrQ8yHZovFzFB61P3Lh1iTDA cyUlmvkLw3hbJ6icdCevr3aJOo2MqKYKajLikkdk09U1VGnU59rSea7wOkuRcqgw rYmhqLpyV2uppHRHVrKrlK0w1mxeuLShZgzVRMUi9AcXnRUDkglVmKSX6TdQ37P5 6JF5as53C5KYLvzkleczzoVMA3KGTULUYs2yn2d262p5PLbAIlJKvbT2/HTvEzqO fMQ0lKSloxHX/iBvy4GqvPugRdfJJCWGUS4t6sFC5muCCI9jnYcbTEOAZ5llzT7n 0HFs2btSH0lbFLMQBB6hPF1ihTMA0vxAQXeugToGupR+HhFePknYmaYLTSOgSH2T DDljF5m+nrVlElCzFqdaNiyj+6wdkIf4Wlri3917Wq0pGZbJT9l1WbOGbMG6wSb+ 430m//L0pOoaIB/0tmn1Lj0IQs3Rh3TRx+RkU2VbA7lfQ9ts6sLsLdwiN1WGAzHF VMBN5w+liK9SFZUUmjdaFLwrETlNXOCqs09nOx3Vg76HxhBYsclEngeUqVaGtlHM Y6+9oAsLnWV0ZD1sAHScBKLH1E437adb7fCUMK5E3ZeoVpoAWqQ= =xkZs -----END PGP SIGNATURE----- --=-4YUXJ/9jclaIlfghsppQ-- --===============8163087557368132595== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============8163087557368132595==--