From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0C1C05027 for ; Mon, 20 Feb 2023 11:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbjBTLYm (ORCPT ); Mon, 20 Feb 2023 06:24:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231827AbjBTLYc (ORCPT ); Mon, 20 Feb 2023 06:24:32 -0500 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 932371ABE9 for ; Mon, 20 Feb 2023 03:24:13 -0800 (PST) Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 327FD20009; Mon, 20 Feb 2023 19:24:09 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1676892251; bh=2CrjEgYe8SBTNfJBvAZ15H122fXa8P+V4hEaKlRMaeU=; h=Subject:From:To:Date:In-Reply-To:References; b=F9/04s3MmpTCAHOgUEYcZAf1ovz/oB7zy9S9v7vYz2BvEBkzMJOAsD5NFxDCDN+XA IOcPegwDjeRPDzWo3GegjETA7YBPcO2keRbo0pYxmFk2iJqvXCgwqms83wvqpqDoCs UtHjJ8v4qgHiQF2ew8kkRxpbQUvQAli8XS86a9TY16ikbHeaQ0RSHhiU099QNZxwKr q6RyRMlVt0wGLNKxq1oDPozTcrYmYU4+cS0JWXDsudQy+tSpzvYRha8zB5tetPU6bj C9KMCICL+5eRUFlObId47XekZId6X+Llxh53w6mjqpZHA5MZHrVylGpQ8YRwuaXmCu Bg/ElQqASFFjg== Message-ID: Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 From: Jeremy Kerr To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Philipp Zabel , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Mon, 20 Feb 2023 19:24:08 +0800 In-Reply-To: References: <20230220061745.1973981-1-ryan_chen@aspeedtech.com> <20230220061745.1973981-2-ryan_chen@aspeedtech.com> <2141e513acc750bf26775f5b435f4dccd41244aa.camel@codeconstruct.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ryan, > > > +=C2=A0 clock-frequency: > > > +=C2=A0=C2=A0=C2=A0 description: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Desired I2C bus clock frequency in Hz= . default 100khz. > > > + > > > +=C2=A0 multi-master: > > > +=C2=A0=C2=A0=C2=A0 type: boolean > > > +=C2=A0=C2=A0=C2=A0 description: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states that there is another master a= ctive on this bus > >=20 > > These are common to all i2c controllers, but I see that i2c-controller.= yaml > > doesn't include them (while i2c.text does). > >=20 > > I assume we're OK to include these in the device bindings in the meanti= me. > > But in that case, you may also want to include the common "smbus-alert" > > property, which you consume in your driver. > >=20 > Since i2c.text have multi-master, smbus-alert. I don't need those two rig= ht? Depends whether the maintainers consider i2c.text as part of the schema, I figure. Might be best to get their input on this. > > > +=C2=A0 timeout: > > > +=C2=A0=C2=A0=C2=A0 type: boolean > > > +=C2=A0=C2=A0=C2=A0 description: Enable i2c bus timeout for master/sl= ave (35ms) > > > + > > > +=C2=A0 byte-mode: > > > +=C2=A0=C2=A0=C2=A0 type: boolean > > > +=C2=A0=C2=A0=C2=A0 description: Force i2c driver use byte mode trans= mit > > > + > > > +=C2=A0 buff-mode: > > > +=C2=A0=C2=A0=C2=A0 type: boolean > > > +=C2=A0=C2=A0=C2=A0 description: Force i2c driver use buffer mode tra= nsmit > >=20 > > These three aren't really a property of the hardware, more of the inten= ded > > driver configuration. Do they really belong in the DT? > >=20 > Sorry, I am confused.=20 > This is hardware controller mode setting for each i2c transfer.=20 > So I add it in property for change different i2c transfer mode. > Is my mis-understand the property setting? It depends what this is configuration is for. Would you set the transfer mode based on the design of the board? Is there something about the physical i2c bus wiring (or some other hardware design choice) that would mean you use one setting over another? On the other hand, if it's just because of OS behaviour, then this doesn't belong in the DT. Maybe to help us understand: why would you ever *not* want DMA mode? Isn't that always preferable? Cheers, Jeremy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0275EC636CC for ; Mon, 20 Feb 2023 11:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H909qg0IAydortdkWWcRvEhl4Qh5EgTiPTNWHb6famk=; b=ZIraBSOWN9ory6 D82eVk2tK01aCwWVkw7QKPZXZXEqlj86cWXLAnR1IyyiIC4QPxO9uHVNg4r+ocBzx+g1Caf7xO2sM /8iEuIGmfexhBkqBw7+QhyMPVHGCdATkQLskOqMbiEHopfYiYdi/1WaiWk6noorVwnrRxrnGZmp4B gBKt8LiUw/7zABRuhQuJpvZFxCTGsO/aS0k16fz7F6RuPxDhWB1TmZkHan60YU1qcJIy2aMxkgnjm HWMJshCf6ws7SX1lI+fEKabsxm2Zfq0jJtb09tmbwL75n/OjUS0tes4JroC66Pw3oT59SIrm1jv74 fb4+IF+v8OzDxhte79MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU4HN-003r5Q-Lm; Mon, 20 Feb 2023 11:24:21 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pU4HK-003r2a-Er for linux-arm-kernel@lists.infradead.org; Mon, 20 Feb 2023 11:24:19 +0000 Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 327FD20009; Mon, 20 Feb 2023 19:24:09 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1676892251; bh=2CrjEgYe8SBTNfJBvAZ15H122fXa8P+V4hEaKlRMaeU=; h=Subject:From:To:Date:In-Reply-To:References; b=F9/04s3MmpTCAHOgUEYcZAf1ovz/oB7zy9S9v7vYz2BvEBkzMJOAsD5NFxDCDN+XA IOcPegwDjeRPDzWo3GegjETA7YBPcO2keRbo0pYxmFk2iJqvXCgwqms83wvqpqDoCs UtHjJ8v4qgHiQF2ew8kkRxpbQUvQAli8XS86a9TY16ikbHeaQ0RSHhiU099QNZxwKr q6RyRMlVt0wGLNKxq1oDPozTcrYmYU4+cS0JWXDsudQy+tSpzvYRha8zB5tetPU6bj C9KMCICL+5eRUFlObId47XekZId6X+Llxh53w6mjqpZHA5MZHrVylGpQ8YRwuaXmCu Bg/ElQqASFFjg== Message-ID: Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 From: Jeremy Kerr To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Philipp Zabel , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Mon, 20 Feb 2023 19:24:08 +0800 In-Reply-To: References: <20230220061745.1973981-1-ryan_chen@aspeedtech.com> <20230220061745.1973981-2-ryan_chen@aspeedtech.com> <2141e513acc750bf26775f5b435f4dccd41244aa.camel@codeconstruct.com.au> User-Agent: Evolution 3.46.3-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_032418_715797_5C730824 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUnlhbiwKCj4gPiA+ICvCoCBjbG9jay1mcmVxdWVuY3k6Cj4gPiA+ICvCoMKgwqAgZGVzY3Jp cHRpb246Cj4gPiA+ICvCoMKgwqDCoMKgIERlc2lyZWQgSTJDIGJ1cyBjbG9jayBmcmVxdWVuY3kg aW4gSHouIGRlZmF1bHQgMTAwa2h6Lgo+ID4gPiArCj4gPiA+ICvCoCBtdWx0aS1tYXN0ZXI6Cj4g PiA+ICvCoMKgwqAgdHlwZTogYm9vbGVhbgo+ID4gPiArwqDCoMKgIGRlc2NyaXB0aW9uOgo+ID4g PiArwqDCoMKgwqDCoCBzdGF0ZXMgdGhhdCB0aGVyZSBpcyBhbm90aGVyIG1hc3RlciBhY3RpdmUg b24gdGhpcyBidXMKPiA+IAo+ID4gVGhlc2UgYXJlIGNvbW1vbiB0byBhbGwgaTJjIGNvbnRyb2xs ZXJzLCBidXQgSSBzZWUgdGhhdCBpMmMtY29udHJvbGxlci55YW1sCj4gPiBkb2Vzbid0IGluY2x1 ZGUgdGhlbSAod2hpbGUgaTJjLnRleHQgZG9lcykuCj4gPiAKPiA+IEkgYXNzdW1lIHdlJ3JlIE9L IHRvIGluY2x1ZGUgdGhlc2UgaW4gdGhlIGRldmljZSBiaW5kaW5ncyBpbiB0aGUgbWVhbnRpbWUu Cj4gPiBCdXQgaW4gdGhhdCBjYXNlLCB5b3UgbWF5IGFsc28gd2FudCB0byBpbmNsdWRlIHRoZSBj b21tb24gInNtYnVzLWFsZXJ0Igo+ID4gcHJvcGVydHksIHdoaWNoIHlvdSBjb25zdW1lIGluIHlv dXIgZHJpdmVyLgo+ID4gCj4gU2luY2UgaTJjLnRleHQgaGF2ZSBtdWx0aS1tYXN0ZXIsIHNtYnVz LWFsZXJ0LiBJIGRvbid0IG5lZWQgdGhvc2UgdHdvIHJpZ2h0PwoKRGVwZW5kcyB3aGV0aGVyIHRo ZSBtYWludGFpbmVycyBjb25zaWRlciBpMmMudGV4dCBhcyBwYXJ0IG9mIHRoZQpzY2hlbWEsIEkg ZmlndXJlLiBNaWdodCBiZSBiZXN0IHRvIGdldCB0aGVpciBpbnB1dCBvbiB0aGlzLgoKCj4gPiA+ ICvCoCB0aW1lb3V0Ogo+ID4gPiArwqDCoMKgIHR5cGU6IGJvb2xlYW4KPiA+ID4gK8KgwqDCoCBk ZXNjcmlwdGlvbjogRW5hYmxlIGkyYyBidXMgdGltZW91dCBmb3IgbWFzdGVyL3NsYXZlICgzNW1z KQo+ID4gPiArCj4gPiA+ICvCoCBieXRlLW1vZGU6Cj4gPiA+ICvCoMKgwqAgdHlwZTogYm9vbGVh bgo+ID4gPiArwqDCoMKgIGRlc2NyaXB0aW9uOiBGb3JjZSBpMmMgZHJpdmVyIHVzZSBieXRlIG1v ZGUgdHJhbnNtaXQKPiA+ID4gKwo+ID4gPiArwqAgYnVmZi1tb2RlOgo+ID4gPiArwqDCoMKgIHR5 cGU6IGJvb2xlYW4KPiA+ID4gK8KgwqDCoCBkZXNjcmlwdGlvbjogRm9yY2UgaTJjIGRyaXZlciB1 c2UgYnVmZmVyIG1vZGUgdHJhbnNtaXQKPiA+IAo+ID4gVGhlc2UgdGhyZWUgYXJlbid0IHJlYWxs eSBhIHByb3BlcnR5IG9mIHRoZSBoYXJkd2FyZSwgbW9yZSBvZiB0aGUgaW50ZW5kZWQKPiA+IGRy aXZlciBjb25maWd1cmF0aW9uLiBEbyB0aGV5IHJlYWxseSBiZWxvbmcgaW4gdGhlIERUPwo+ID4g Cj4gU29ycnksIEkgYW0gY29uZnVzZWQuIAo+IFRoaXMgaXMgaGFyZHdhcmUgY29udHJvbGxlciBt b2RlIHNldHRpbmcgZm9yIGVhY2ggaTJjIHRyYW5zZmVyLiAKPiBTbyBJIGFkZCBpdCBpbiBwcm9w ZXJ0eSBmb3IgY2hhbmdlIGRpZmZlcmVudCBpMmMgdHJhbnNmZXIgbW9kZS4KPiBJcyBteSBtaXMt dW5kZXJzdGFuZCB0aGUgcHJvcGVydHkgc2V0dGluZz8KCkl0IGRlcGVuZHMgd2hhdCB0aGlzIGlz IGNvbmZpZ3VyYXRpb24gaXMgZm9yLgoKV291bGQgeW91IHNldCB0aGUgdHJhbnNmZXIgbW9kZSBi YXNlZCBvbiB0aGUgZGVzaWduIG9mIHRoZSBib2FyZD8gSXMKdGhlcmUgc29tZXRoaW5nIGFib3V0 IHRoZSBwaHlzaWNhbCBpMmMgYnVzIHdpcmluZyAob3Igc29tZSBvdGhlcgpoYXJkd2FyZSBkZXNp Z24gY2hvaWNlKSB0aGF0IHdvdWxkIG1lYW4geW91IHVzZSBvbmUgc2V0dGluZyBvdmVyCmFub3Ro ZXI/CgpPbiB0aGUgb3RoZXIgaGFuZCwgaWYgaXQncyBqdXN0IGJlY2F1c2Ugb2YgT1MgYmVoYXZp b3VyLCB0aGVuIHRoaXMKZG9lc24ndCBiZWxvbmcgaW4gdGhlIERULgoKTWF5YmUgdG8gaGVscCB1 cyB1bmRlcnN0YW5kOiB3aHkgd291bGQgeW91IGV2ZXIgKm5vdCogd2FudCBETUEgbW9kZT8KSXNu J3QgdGhhdCBhbHdheXMgcHJlZmVyYWJsZT8KCkNoZWVycywKCgpKZXJlbXkKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK