All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fred Konrad <konrad@adacore.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, alex.bennee@linaro.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	frederic.konrad@adacore.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] semihosting: remove the pthread include which seems unused
Date: Mon, 1 Jun 2020 11:19:17 +0200	[thread overview]
Message-ID: <dfd77414-83e8-755f-1386-13188b968aef@adacore.com> (raw)
In-Reply-To: <5ab6f370-6725-1cdb-1b82-24a58cb7642e@redhat.com>



Le 5/18/20 à 3:50 PM, Philippe Mathieu-Daudé a écrit :
> On 5/18/20 3:02 PM, konrad@adacore.com wrote:
>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>
>> This have been introduced by:
>>    8de702cb677c8381fb702cae252d6b69aa4c653b
>>
>> It doesn't seem to be used so remove it.
>>
>> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
>> ---
>>   hw/semihosting/console.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
>> index 6346bd7..22e7827 100644
>> --- a/hw/semihosting/console.c
>> +++ b/hw/semihosting/console.c
>> @@ -23,7 +23,6 @@
>>   #include "exec/exec-all.h"
>>   #include "qemu/log.h"
>>   #include "chardev/char.h"
>> -#include <pthread.h>
>>   #include "chardev/char-fe.h"
>>   #include "sysemu/sysemu.h"
>>   #include "qemu/main-loop.h"
>>
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Thanks for the review, Philippe.  Can this go through qemu-trivial?

Regards,
Fred


  reply	other threads:[~2020-06-01  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 13:02 [PATCH] semihosting: remove the pthread include which seems unused konrad
2020-05-18 13:50 ` Philippe Mathieu-Daudé
2020-06-01  9:19   ` Fred Konrad [this message]
2020-06-01 10:29     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfd77414-83e8-755f-1386-13188b968aef@adacore.com \
    --to=konrad@adacore.com \
    --cc=alex.bennee@linaro.org \
    --cc=frederic.konrad@adacore.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.