From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52665369 for ; Thu, 5 May 2022 00:42:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5D6FE1F40A4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651711327; bh=MyOm9L9WGRdUCHRglVPQ6r+0Az2kPrdmLi4U0cgQB+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OzGMoesSvl76vDw/rGqLDlidJ30q+2p8JVEemntpZj/HiFybMjDA64LAQlAuBXCDv ddHuD/R0AiRd0qGdMOQU3IKMpL6cUYyiB31hXaFcPGYOYx15QobmdbztD8c/AXll9M lYER4eSv4WHNv/f/509FCX0O9Ua8VzNlrO6VQRjlHwPvWSWIsgIebs3WMHvGbp8N7o 0lFvG17/neKrcP9HzEJoUMcWLxIwEsnUcmqyLhU9MLmB+usJiGbxRms1is1I5UqkFm jgzYyWq1GtDPthuLF7d3zG6wxigGxTqKdnuXjSx809hL8eBmphREbxwV2r+4VMyHZx Q8lrF5JxdXuTw== Message-ID: Date: Thu, 5 May 2022 03:42:03 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist Content-Language: en-US To: Nicolas Dufresne , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Ezequiel Garcia , Philipp Zabel , Greg Kroah-Hartman , Heiko Stuebner , Matthias Brugger Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> <20220426125751.108293-6-nicolas.dufresne@collabora.com> From: Dmitry Osipenko In-Reply-To: <20220426125751.108293-6-nicolas.dufresne@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/26/22 15:57, Nicolas Dufresne wrote: > static int tegra_vde_wait_mbe(struct tegra_vde *vde) > @@ -768,7 +768,7 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > struct h264_reflists reflists; > struct vb2_buffer *ref; > unsigned int i; > - u8 *dpb_id; > + struct v4l2_h264_reference *dpb_id; nit: will be nice to preserve to reverse Xmas coding style, but only if you'll need to make v5 with more important changes > int err; > > /* > @@ -811,14 +811,16 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > } > > for (i = 0; i < b.num_valid; i++) { > - ref = get_ref_buf(ctx, dst, dpb_id[i]); > + int dpb_idx = dpb_id[i].index; > > - err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_id[i], > + ref = get_ref_buf(ctx, dst, dpb_idx); > + > + err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_idx, > h264->dpb_frames_nb++); > if (err) > return err; > > - if (b.refs[dpb_id[i]].pic_order_count < b.cur_pic_order_count) > + if (b.refs[dpb_idx].top_field_order_cnt < b.cur_pic_order_count) > h264->dpb_ref_frames_with_earlier_poc_nb++; Tested-by: Dmitry Osipenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F572C433F5 for ; Thu, 5 May 2022 00:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JKI/qP26+TcvjNpQsAxRyCv/SnHiK+Ux/Mah2+mJIQk=; b=imboLa6aCvmiwk n4sP8FuZ6YRQSPFpomaoSiRrtXnafiDcP5Udwgv4IHyvN6gxS6zibYiTEGpgaQTqDlTI+sDDAEp1o eBmeUTP7d7bcWHbU0K5EUN/gPyW36lt9pi2vl8//KoLJ2zto4aOBiJXvK+RzQO6FxJ0z0sWL2/711 E31iALBEKwZq+zTlbVQYOPf+lKeqIQEXA/m0Vu+vZzG5s76a2wibdbZ4icck+k8npQrLvhjI/ja3Y tXCZzDkr4e9FW0A/iZacK0YLc8ZN0+3Ov/Q69z3UyuFMBST/ozGgJLJvpXBrC6LFYTGedue519W1D QPTDrOOqDR5Lcm8b6Uuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZZ-00DM2n-SF; Thu, 05 May 2022 00:42:25 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZN-00DLt0-D7; Thu, 05 May 2022 00:42:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5D6FE1F40A4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651711327; bh=MyOm9L9WGRdUCHRglVPQ6r+0Az2kPrdmLi4U0cgQB+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OzGMoesSvl76vDw/rGqLDlidJ30q+2p8JVEemntpZj/HiFybMjDA64LAQlAuBXCDv ddHuD/R0AiRd0qGdMOQU3IKMpL6cUYyiB31hXaFcPGYOYx15QobmdbztD8c/AXll9M lYER4eSv4WHNv/f/509FCX0O9Ua8VzNlrO6VQRjlHwPvWSWIsgIebs3WMHvGbp8N7o 0lFvG17/neKrcP9HzEJoUMcWLxIwEsnUcmqyLhU9MLmB+usJiGbxRms1is1I5UqkFm jgzYyWq1GtDPthuLF7d3zG6wxigGxTqKdnuXjSx809hL8eBmphREbxwV2r+4VMyHZx Q8lrF5JxdXuTw== Message-ID: Date: Thu, 5 May 2022 03:42:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist Content-Language: en-US To: Nicolas Dufresne , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Ezequiel Garcia , Philipp Zabel , Greg Kroah-Hartman , Heiko Stuebner , Matthias Brugger Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> <20220426125751.108293-6-nicolas.dufresne@collabora.com> From: Dmitry Osipenko In-Reply-To: <20220426125751.108293-6-nicolas.dufresne@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_174213_605951_16F48129 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 4/26/22 15:57, Nicolas Dufresne wrote: > static int tegra_vde_wait_mbe(struct tegra_vde *vde) > @@ -768,7 +768,7 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > struct h264_reflists reflists; > struct vb2_buffer *ref; > unsigned int i; > - u8 *dpb_id; > + struct v4l2_h264_reference *dpb_id; nit: will be nice to preserve to reverse Xmas coding style, but only if you'll need to make v5 with more important changes > int err; > > /* > @@ -811,14 +811,16 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > } > > for (i = 0; i < b.num_valid; i++) { > - ref = get_ref_buf(ctx, dst, dpb_id[i]); > + int dpb_idx = dpb_id[i].index; > > - err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_id[i], > + ref = get_ref_buf(ctx, dst, dpb_idx); > + > + err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_idx, > h264->dpb_frames_nb++); > if (err) > return err; > > - if (b.refs[dpb_id[i]].pic_order_count < b.cur_pic_order_count) > + if (b.refs[dpb_idx].top_field_order_cnt < b.cur_pic_order_count) > h264->dpb_ref_frames_with_earlier_poc_nb++; Tested-by: Dmitry Osipenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29EF5C433F5 for ; Thu, 5 May 2022 00:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7ZXHAVpAUIt4zd3X/klpAzhLtvEhSKbOPVXegPoBvaw=; b=2AWGTFyyKVfQSg 2yCAP4s/1PV2bmpIurcWo0UuNSwBt0sKKlIsdeONYtE5hGMmuCdorABqyP41c1X17opgesAwku7Vo EZasJbaKbQ3BxaRSnG3iUmyblOQ45qHV17MPUWBdPNeYiHiUgE01FznA82viXllgykIaVae33Pl65 kuRFG6iJfWtO6L8+ZS93xnuBRe5ix4dhvEW+/GH3IYLQ9foC16BAdFhbFzWzz5W2PM46biTfqT1ct qEzdLXV7N0Gi9iSiYujfjsjJvVN3MOtyuhgKeGtlon/cE7B+XzgDgUBar25SyhIZXjY+6jZQkU5cJ ELxApDwo2zdOuO2bkuAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZZ-00DM2R-7K; Thu, 05 May 2022 00:42:25 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZN-00DLt0-D7; Thu, 05 May 2022 00:42:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5D6FE1F40A4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651711327; bh=MyOm9L9WGRdUCHRglVPQ6r+0Az2kPrdmLi4U0cgQB+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OzGMoesSvl76vDw/rGqLDlidJ30q+2p8JVEemntpZj/HiFybMjDA64LAQlAuBXCDv ddHuD/R0AiRd0qGdMOQU3IKMpL6cUYyiB31hXaFcPGYOYx15QobmdbztD8c/AXll9M lYER4eSv4WHNv/f/509FCX0O9Ua8VzNlrO6VQRjlHwPvWSWIsgIebs3WMHvGbp8N7o 0lFvG17/neKrcP9HzEJoUMcWLxIwEsnUcmqyLhU9MLmB+usJiGbxRms1is1I5UqkFm jgzYyWq1GtDPthuLF7d3zG6wxigGxTqKdnuXjSx809hL8eBmphREbxwV2r+4VMyHZx Q8lrF5JxdXuTw== Message-ID: Date: Thu, 5 May 2022 03:42:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist Content-Language: en-US To: Nicolas Dufresne , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Ezequiel Garcia , Philipp Zabel , Greg Kroah-Hartman , Heiko Stuebner , Matthias Brugger Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> <20220426125751.108293-6-nicolas.dufresne@collabora.com> From: Dmitry Osipenko In-Reply-To: <20220426125751.108293-6-nicolas.dufresne@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_174213_605951_16F48129 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 4/26/22 15:57, Nicolas Dufresne wrote: > static int tegra_vde_wait_mbe(struct tegra_vde *vde) > @@ -768,7 +768,7 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > struct h264_reflists reflists; > struct vb2_buffer *ref; > unsigned int i; > - u8 *dpb_id; > + struct v4l2_h264_reference *dpb_id; nit: will be nice to preserve to reverse Xmas coding style, but only if you'll need to make v5 with more important changes > int err; > > /* > @@ -811,14 +811,16 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > } > > for (i = 0; i < b.num_valid; i++) { > - ref = get_ref_buf(ctx, dst, dpb_id[i]); > + int dpb_idx = dpb_id[i].index; > > - err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_id[i], > + ref = get_ref_buf(ctx, dst, dpb_idx); > + > + err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_idx, > h264->dpb_frames_nb++); > if (err) > return err; > > - if (b.refs[dpb_id[i]].pic_order_count < b.cur_pic_order_count) > + if (b.refs[dpb_idx].top_field_order_cnt < b.cur_pic_order_count) > h264->dpb_ref_frames_with_earlier_poc_nb++; Tested-by: Dmitry Osipenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26281C433F5 for ; Thu, 5 May 2022 00:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f6DyCBXPFDQ9KhdP0k7dx2WiSyRt94SF37WD01auNK8=; b=qycmzq+U1HA+sS r+Yby/VCD9OtZx6gmpuNzIrb4ah7i5T2XL0VsDkUxqT4nElORxSiJjrYhNgMG0vlFd/zu6L5NRZdF ZLQWs5uVDvHhyJagXLvR0KJJ+jXQCE+Ztogkrj4a4GUp8mO0OZWFVSwoDaEmbfGYLtNM6oaSmsONL XIkvi/Vo6nyz6NGp1PcwuWK7A+lCAgj13B3QfMhjnUryyTm1F4aNMAefKOsAoBOnz6jGc6qJV8DyU yDRPX6GsA0ivI8lP+ytNBAqQXsNNmOLlpJRiqnclW3OS8JoybQorvijodtkvqEChr69YhJZARiTyv Kf/n3+onY5Gw1MwRuDAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZQ-00DLvl-4O; Thu, 05 May 2022 00:42:16 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmPZN-00DLt0-D7; Thu, 05 May 2022 00:42:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5D6FE1F40A4D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651711327; bh=MyOm9L9WGRdUCHRglVPQ6r+0Az2kPrdmLi4U0cgQB+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OzGMoesSvl76vDw/rGqLDlidJ30q+2p8JVEemntpZj/HiFybMjDA64LAQlAuBXCDv ddHuD/R0AiRd0qGdMOQU3IKMpL6cUYyiB31hXaFcPGYOYx15QobmdbztD8c/AXll9M lYER4eSv4WHNv/f/509FCX0O9Ua8VzNlrO6VQRjlHwPvWSWIsgIebs3WMHvGbp8N7o 0lFvG17/neKrcP9HzEJoUMcWLxIwEsnUcmqyLhU9MLmB+usJiGbxRms1is1I5UqkFm jgzYyWq1GtDPthuLF7d3zG6wxigGxTqKdnuXjSx809hL8eBmphREbxwV2r+4VMyHZx Q8lrF5JxdXuTw== Message-ID: Date: Thu, 5 May 2022 03:42:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 05/24] media: h264: Use v4l2_h264_reference for reflist Content-Language: en-US To: Nicolas Dufresne , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Ezequiel Garcia , Philipp Zabel , Greg Kroah-Hartman , Heiko Stuebner , Matthias Brugger Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> <20220426125751.108293-6-nicolas.dufresne@collabora.com> From: Dmitry Osipenko In-Reply-To: <20220426125751.108293-6-nicolas.dufresne@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_174213_605951_16F48129 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/26/22 15:57, Nicolas Dufresne wrote: > static int tegra_vde_wait_mbe(struct tegra_vde *vde) > @@ -768,7 +768,7 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > struct h264_reflists reflists; > struct vb2_buffer *ref; > unsigned int i; > - u8 *dpb_id; > + struct v4l2_h264_reference *dpb_id; nit: will be nice to preserve to reverse Xmas coding style, but only if you'll need to make v5 with more important changes > int err; > > /* > @@ -811,14 +811,16 @@ static int tegra_vde_h264_setup_frames(struct tegra_ctx *ctx, > } > > for (i = 0; i < b.num_valid; i++) { > - ref = get_ref_buf(ctx, dst, dpb_id[i]); > + int dpb_idx = dpb_id[i].index; > > - err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_id[i], > + ref = get_ref_buf(ctx, dst, dpb_idx); > + > + err = tegra_vde_h264_setup_frame(ctx, h264, &b, ref, dpb_idx, > h264->dpb_frames_nb++); > if (err) > return err; > > - if (b.refs[dpb_id[i]].pic_order_count < b.cur_pic_order_count) > + if (b.refs[dpb_idx].top_field_order_cnt < b.cur_pic_order_count) > h264->dpb_ref_frames_with_earlier_poc_nb++; Tested-by: Dmitry Osipenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel