From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA194C432BE for ; Thu, 26 Aug 2021 08:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3EB060F4A for ; Thu, 26 Aug 2021 08:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240451AbhHZIaE (ORCPT ); Thu, 26 Aug 2021 04:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240315AbhHZIaD (ORCPT ); Thu, 26 Aug 2021 04:30:03 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05695C061757 for ; Thu, 26 Aug 2021 01:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ChWPK7ox2IYbPXxDUF/DiOKMbfiJndJaeviCuolqwVE=; t=1629966557; x=1631176157; b=lcV3LLQECc81ntahHXyr0dJ3gu2ZkDk1bN2qLKmKaEgRjbK LkaEBskW5WDK7mCANrF95Nyp6ukmkD8Pzi6JgATx4PJkr7NyNKY7jN1zQTU9vQftDZNLqS5v4ogoR cn7FJdBQNOS2VBpMq9IyP83aXWnJwBlJzb2p71+ygSddhGcsaXH+ko3B3YviP/LYxI5bI8FeElaRN 93FJs//DBdoVW3jWp8u9CVeT+h6ia+q9B/cD8TiR/BdU7ZsjrgK0rA0LmEEhPO+zz/30btyuhKSOp T+AjzYq1y6hYb/sLjEafY3qe8aaeJM6RWMoRCSqxTMf2+gTMWnVdigIbLajn3M3w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1mJAl6-00G4rR-ET; Thu, 26 Aug 2021 10:29:12 +0200 Message-ID: Subject: Re: [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint From: Johannes Berg To: Wen Gong , ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Thu, 26 Aug 2021 10:29:11 +0200 In-Reply-To: <20210820122041.12157-9-wgong@codeaurora.org> References: <20210820122041.12157-1-wgong@codeaurora.org> <20210820122041.12157-9-wgong@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2021-08-20 at 08:20 -0400, Wen Gong wrote: > >   if (!(ifmgd->flags & IEEE80211_STA_DISABLE_HE)) { >   const struct cfg80211_bss_ies *ies; > + struct ieee80211_bss_conf *bss_conf; am I missing where you set this? > + if (is_6ghz) { > + struct ieee802_11_elems elems; This is pretty big, not sure we want it on the stack (causes warnings for me in build). Also, if we're doing this anyway, then we can change the code above (perhaps as a separate patch) to not do cfg80211_find_ext_ie() but rather take it out of the parsed. > + u8 i, j = 0; > + > + ieee802_11_parse_elems(ies->data, ies->len, false, &elems, (line too long) > + NULL, NULL); > + > + if (elems.pwr_constr_elem) > + bss_conf->pwr_reduction = *elems.pwr_constr_elem; before using it? > + > + BUILD_BUG_ON(ARRAY_SIZE(bss_conf->tx_pwr_env) != > + ARRAY_SIZE(elems.tx_pwr_env)); > + > + for (i = 0; i < elems.tx_pwr_env_num; i++) { > + if (elems.tx_pwr_env_len[i] > > + sizeof(bss_conf->tx_pwr_env[j])) > + continue; I did that in the parsing itself. > + > + bss_conf->tx_pwr_env_num++; > + memcpy(&bss_conf->tx_pwr_env[j], elems.tx_pwr_env[i], > + elems.tx_pwr_env_len[i]); You're never resetting any of this for the next connection (if it's not 6 GHz for example, or doesn't have any data) - should probably memset all the new members to 0 before the "if (is_6ghz)" or so? johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBB4C432BE for ; Thu, 26 Aug 2021 08:29:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE5CF600CC for ; Thu, 26 Aug 2021 08:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DE5CF600CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1rXd0MBykFlI76bYRZ5LzkqETBnlb/nYkVxuX84qSVE=; b=shd8/ijHcKQwNx bMxT2t/yV3fRCptnn+HFgo0rPSSsRM/KsVHW7NN13kSjAAaxIT918Q9onLmXbjFb3OvZ0T7VIMQPu 408qiCAwHxRl7kSIqjrT2NC1I2HUraXmNuvt27nMra67Eyp6lsG53NIFccTb6DjjObxoEEzXaepd1 UKJj/1gKcIcW6y/hqD+TEfeFXTxtwhDIGSLhEpVOzWKbiFnBYDWr7Hia4mKqZE57wQoC21H5yfYYf mysCaBRIXdnbFyQpYqYbIvSByHKMXG8JECF/HGE1h64bG/tteVoXXX5ugij4u2dWJKXg6HlOKLBr4 +42dPCd/2ipZPOzX0tng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJAlC-009YGs-RR; Thu, 26 Aug 2021 08:29:18 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJAl8-009YGL-0Q for ath11k@lists.infradead.org; Thu, 26 Aug 2021 08:29:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ChWPK7ox2IYbPXxDUF/DiOKMbfiJndJaeviCuolqwVE=; t=1629966553; x=1631176153; b=rd41ePepwBO/0fiiy/ziW9itczKaLCeK9ErJ2dvVsazMgz8 Vi6vVJdrecz/xOWmrgkjtbF1DNKZqEip6e5sEMDp7APAV6fOBcodLjfg/uNTbqRqWNO6e/ZYOCYbv OsMOAd+jIYTjbevuJ2OevpqTyWDJaBQxPfEK246MlnAX0yG7fIfqFPa2e7rmmobdTR68uzVdVFXNt fKWASNRo4ZMufg+boipLZ5jMLGQA5dlPQENZcS0EnhCl9PwBIyuJKL6IR6FbLi4qG1CgcCH5hE/R7 BSl3HQ7scCel0qoYeCJm81fTpwld3J+3qjRb1yMWK0WWXTIhqKlUteH283411FrA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1mJAl6-00G4rR-ET; Thu, 26 Aug 2021 10:29:12 +0200 Message-ID: Subject: Re: [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint From: Johannes Berg To: Wen Gong , ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Thu, 26 Aug 2021 10:29:11 +0200 In-Reply-To: <20210820122041.12157-9-wgong@codeaurora.org> References: <20210820122041.12157-1-wgong@codeaurora.org> <20210820122041.12157-9-wgong@codeaurora.org> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_012914_091964_9336FECD X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMDIxLTA4LTIwIGF0IDA4OjIwIC0wNDAwLCBXZW4gR29uZyB3cm90ZToKPiAKPiDC oAlpZiAoIShpZm1nZC0+ZmxhZ3MgJiBJRUVFODAyMTFfU1RBX0RJU0FCTEVfSEUpKSB7Cj4gwqAJ CWNvbnN0IHN0cnVjdCBjZmc4MDIxMV9ic3NfaWVzICppZXM7Cj4gKwkJc3RydWN0IGllZWU4MDIx MV9ic3NfY29uZiAqYnNzX2NvbmY7CgphbSBJIG1pc3Npbmcgd2hlcmUgeW91IHNldCB0aGlzPwoK PiArCQlpZiAoaXNfNmdoeikgewo+ICsJCQlzdHJ1Y3QgaWVlZTgwMl8xMV9lbGVtcyBlbGVtczsK ClRoaXMgaXMgcHJldHR5IGJpZywgbm90IHN1cmUgd2Ugd2FudCBpdCBvbiB0aGUgc3RhY2sgKGNh dXNlcyB3YXJuaW5ncwpmb3IgbWUgaW4gYnVpbGQpLiBBbHNvLCBpZiB3ZSdyZSBkb2luZyB0aGlz IGFueXdheSwgdGhlbiB3ZSBjYW4gY2hhbmdlCnRoZSBjb2RlIGFib3ZlIChwZXJoYXBzIGFzIGEg c2VwYXJhdGUgcGF0Y2gpIHRvIG5vdCBkbwpjZmc4MDIxMV9maW5kX2V4dF9pZSgpIGJ1dCByYXRo ZXIgdGFrZSBpdCBvdXQgb2YgdGhlIHBhcnNlZC4KCj4gKwkJCXU4IGksIGogPSAwOwo+ICsKPiAr CQkJaWVlZTgwMl8xMV9wYXJzZV9lbGVtcyhpZXMtPmRhdGEsIGllcy0+bGVuLCBmYWxzZSwgJmVs ZW1zLAoKKGxpbmUgdG9vIGxvbmcpCgo+ICsJCQkJCSAgICAgICBOVUxMLCBOVUxMKTsKPiArCj4g KwkJCWlmIChlbGVtcy5wd3JfY29uc3RyX2VsZW0pCj4gKwkJCQlic3NfY29uZi0+cHdyX3JlZHVj dGlvbiA9ICplbGVtcy5wd3JfY29uc3RyX2VsZW07CgpiZWZvcmUgdXNpbmcgaXQ/Cgo+ICsKPiAr CQkJQlVJTERfQlVHX09OKEFSUkFZX1NJWkUoYnNzX2NvbmYtPnR4X3B3cl9lbnYpICE9Cj4gKwkJ CQkgICAgIEFSUkFZX1NJWkUoZWxlbXMudHhfcHdyX2VudikpOwo+ICsKPiArCQkJZm9yIChpID0g MDsgaSA8IGVsZW1zLnR4X3B3cl9lbnZfbnVtOyBpKyspIHsKPiArCQkJCWlmIChlbGVtcy50eF9w d3JfZW52X2xlbltpXSA+Cj4gKwkJCQkgICAgc2l6ZW9mKGJzc19jb25mLT50eF9wd3JfZW52W2pd KSkKPiArCQkJCQljb250aW51ZTsKCkkgZGlkIHRoYXQgaW4gdGhlIHBhcnNpbmcgaXRzZWxmLgoK PiArCj4gKwkJCQlic3NfY29uZi0+dHhfcHdyX2Vudl9udW0rKzsKPiArCQkJCW1lbWNweSgmYnNz X2NvbmYtPnR4X3B3cl9lbnZbal0sIGVsZW1zLnR4X3B3cl9lbnZbaV0sCj4gKwkJCQkgICAgICAg ZWxlbXMudHhfcHdyX2Vudl9sZW5baV0pOwoKWW91J3JlIG5ldmVyIHJlc2V0dGluZyBhbnkgb2Yg dGhpcyBmb3IgdGhlIG5leHQgY29ubmVjdGlvbiAoaWYgaXQncyBub3QKNiBHSHogZm9yIGV4YW1w bGUsIG9yIGRvZXNuJ3QgaGF2ZSBhbnkgZGF0YSkgLSBzaG91bGQgcHJvYmFibHkgbWVtc2V0CmFs bCB0aGUgbmV3IG1lbWJlcnMgdG8gMCBiZWZvcmUgdGhlICJpZiAoaXNfNmdoeikiIG9yIHNvPwoK am9oYW5uZXMKCgotLSAKYXRoMTFrIG1haWxpbmcgbGlzdAphdGgxMWtAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDExawo=